From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Frank Li" <Frank.Li@nxp.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/12] PCI: dwc: Convert Link-up status method to using dw_pcie_readl_dbi()
Date: Thu, 24 Mar 2022 17:50:34 +0530 [thread overview]
Message-ID: <20220324122034.GI2854@thinkpad> (raw)
In-Reply-To: <20220324012524.16784-10-Sergey.Semin@baikalelectronics.ru>
On Thu, Mar 24, 2022 at 04:25:20AM +0300, Serge Semin wrote:
> While the rest of the generic DWC PCIe code is using the dedicated IO-mem
> accessors, the dw_pcie_link_up() method for some unobvious reason directly
> calls readl() to get PortLogic.DEBUG1 register content. Since the way the
> dbi-bus is accessed can be platform-specific let's replace the direct dbi
> memory space read procedure with the readl-wrapper invocation. Thus we'll
> have a slightly more generic dw_pcie_link_up() method.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> index e3d2c11e6998..6e81264fdfb4 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -548,7 +548,7 @@ int dw_pcie_link_up(struct dw_pcie *pci)
> if (pci->ops && pci->ops->link_up)
> return pci->ops->link_up(pci);
>
> - val = readl(pci->dbi_base + PCIE_PORT_DEBUG1);
> + val = dw_pcie_readl_dbi(pci, PCIE_PORT_DEBUG1);
> return ((val & PCIE_PORT_DEBUG1_LINK_UP) &&
> (!(val & PCIE_PORT_DEBUG1_LINK_IN_TRAINING)));
> }
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-03-24 12:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 1:25 [PATCH 00/12] PCI: dwc: Various fixes and cleanups Serge Semin
2022-03-24 1:25 ` [PATCH 01/12] PCI: dwc: Stop link in the host init error and de-initialization Serge Semin
2022-03-24 8:11 ` Manivannan Sadhasivam
2022-03-24 1:25 ` [PATCH 02/12] PCI: dwc: Don't use generic IO-ops for DBI-space access Serge Semin
2022-03-24 8:27 ` Manivannan Sadhasivam
2022-04-13 21:03 ` Serge Semin
2022-03-24 1:25 ` [PATCH 03/12] PCI: dwc: Add unroll iATU space support to the regions disable method Serge Semin
2022-03-24 8:59 ` Manivannan Sadhasivam
2022-03-28 21:34 ` kernel test robot
2022-03-28 21:34 ` kernel test robot
2022-03-24 1:25 ` [PATCH 04/12] PCI: dwc: Disable outbound windows for controllers with iATU Serge Semin
2022-03-24 9:05 ` Manivannan Sadhasivam
2022-03-24 1:25 ` [PATCH 05/12] PCI: dwc: Set INCREASE_REGION_SIZE flag based on limit address Serge Semin
2022-03-24 12:05 ` Manivannan Sadhasivam
2022-04-13 21:54 ` Serge Semin
2022-03-24 1:25 ` [PATCH 06/12] PCI: dwc: Add braces to the multi-line if-else statements Serge Semin
2022-03-24 12:13 ` Manivannan Sadhasivam
2022-03-24 1:25 ` [PATCH 07/12] PCI: dwc: Add trailing new-line literals to the log messages Serge Semin
2022-03-24 12:16 ` Manivannan Sadhasivam
2022-03-24 1:25 ` [PATCH 08/12] PCI: dwc: Discard IP-core version checking on unrolled iATU detection Serge Semin
2022-03-24 12:19 ` Manivannan Sadhasivam
2022-03-24 1:25 ` [PATCH 09/12] PCI: dwc: Convert Link-up status method to using dw_pcie_readl_dbi() Serge Semin
2022-03-24 12:20 ` Manivannan Sadhasivam [this message]
2022-03-24 1:25 ` [PATCH 10/12] PCI: dwc-plat: Simplify the probe method return value handling Serge Semin
2022-03-24 12:23 ` Manivannan Sadhasivam
2022-03-24 1:25 ` [PATCH 11/12] PCI: dwc-plat: Discard unused regmap pointer Serge Semin
2022-03-24 12:24 ` Manivannan Sadhasivam
2022-03-24 1:25 ` [PATCH 12/12] PCI: dwc-plat: Drop dw_plat_pcie_of_match forward declaration Serge Semin
2022-03-24 12:26 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324122034.GI2854@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).