From: Herve Codina <herve.codina@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clement Leger" <clement.leger@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v2 2/8] dt-bindings: PCI: renesas-pci-usb: Convert bindings to json-schema
Date: Tue, 19 Apr 2022 16:41:05 +0200 [thread overview]
Message-ID: <20220419164105.14bf82cf@bootlin.com> (raw)
In-Reply-To: <CAMuHMdUhr7emtsxoxGP5EH2EzNK=PM_7+-32cesecjQjoW1ryQ@mail.gmail.com>
Hi Geert,
On Thu, 14 Apr 2022 10:28:47 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Hervé,
>
> On Thu, Apr 14, 2022 at 9:40 AM Herve Codina <herve.codina@bootlin.com> wrote:
> > Convert Renesas PCI bridge bindings documentation to json-schema.
> > Also name it 'renesas,pci-usb' as it is specifically used to
> > connect the PCI USB controllers to AHB bus.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
>
> Thanks a lot for tackling this DT binding file!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/renesas,pci-usb.yaml
> > @@ -0,0 +1,134 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> scripts/checkpatch.pl says:
> WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)
Right, changed to "GPL-2.0-only OR BSD-2-Clause"
>
> > + reg:
> > + description: |
> > + A list of physical regions to access the device. The first is
> > + the operational registers for the OHCI/EHCI controllers and the
> > + second is for the bridge configuration and control registers.
> > + minItems: 2
> > + maxItems: 2
>
> reg:
> items:
> - description: Operational registers for the OHCI/EHCI controllers.
> - description: Bridge configuration and control registers.
Ok, changed.
>
> > +
> > + interrupts:
> > + description: Interrupt for the device.
>
> maxItems: 1
>
> The description is not needed.
Ok, changed.
>
> > +
> > + interrupt-map:
> > + description: |
> > + Standard property used to define the mapping of the PCI interrupts
> > + to the GIC interrupts.
> > +
> > + interrupt-map-mask:
> > + description:
> > + Standard property that helps to define the interrupt mapping.
> > +
> > + clocks:
> > + description: The reference to the device clock.
>
> maxItems: 1
>
> The description is not needed.
Ok, changed
>
> Missing "resets" and "power-domains" properties.
>
> Missing description of the child nodes.
"resets", "power-domains" dans child nodes added
>
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - interrupt-map
> > + - interrupt-map-mask
> > + - clocks
>
> Missing "resets" and "power-domains".
Added
>
> > + - bus-range
> > + - "#address-cells"
> > + - "#size-cells"
> > + - "#interrupt-cells"
> > +
> > +unevaluatedProperties: false
>
> Why doesn't "make dtbs_check" complain about the presence of
> e.g. "resets" in the actual DTS files?
>
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/r8a7790-cpg-mssr.h>
> > +
> > + bus {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
>
> I think you should drop this (and the corresponding high addresses
> below).
>
Ok
> > +
> > + pci0: pci@ee090000 {
> > + compatible = "renesas,pci-r8a7790", "renesas,pci-rcar-gen2";
> > + device_type = "pci";
> > + clocks = <&cpg CPG_MOD 703>;
> > + reg = <0 0xee090000 0 0xc00>,
> > + <0 0xee080000 0 0x1100>;
> > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
>
> power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> resets = <&cpg 703>;
Ok
>
> > + status = "disabled";
> > +
> > + bus-range = <0 0>;
> > + #address-cells = <3>;
> > + #size-cells = <2>;
> > + #interrupt-cells = <1>;
> > + ranges = <0x02000000 0 0xee080000 0 0xee080000 0 0x00010000>;
> > + dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x40000000>;
> > + interrupt-map-mask = <0xf800 0 0 0x7>;
> > + interrupt-map = <0x0000 0 0 1 &gic GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
> > + <0x0800 0 0 1 &gic GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
> > + <0x1000 0 0 2 &gic GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > + usb@1,0 {
> > + reg = <0x800 0 0 0 0>;
> > + phys = <&usb0 0>;
> > + phy-names = "usb";
> > + };
> > +
>
> ERROR: trailing whitespace
> #249: FILE: Documentation/devicetree/bindings/pci/renesas,pci-usb.yaml:127:
> + $
Ok
>
> > + usb@2,0 {
> > + reg = <0x1000 0 0 0 0>;
> > + phys = <&usb0 0>;
> > + phy-names = "usb";
> > + };
> > + };
> > + };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Thanks for the review,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2022-04-19 14:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 7:40 [PATCH v2 0/8] RZN1 USB Host support Herve Codina
2022-04-14 7:40 ` [PATCH v2 1/8] PCI: rcar-gen2: Add support for clocks Herve Codina
2022-04-14 8:45 ` Geert Uytterhoeven
2022-04-14 11:29 ` Herve Codina
2022-04-14 11:48 ` Geert Uytterhoeven
2022-04-14 13:42 ` Herve Codina
2022-04-14 7:40 ` [PATCH v2 2/8] dt-bindings: PCI: renesas-pci-usb: Convert bindings to json-schema Herve Codina
2022-04-14 8:08 ` Miquel Raynal
2022-04-14 8:28 ` Geert Uytterhoeven
2022-04-19 14:41 ` Herve Codina [this message]
2022-04-14 18:15 ` Rob Herring
2022-04-20 12:44 ` Herve Codina
2022-04-20 13:18 ` Rob Herring
2022-04-20 13:46 ` Herve Codina
2022-04-20 21:37 ` Rob Herring
2022-04-14 7:40 ` [PATCH v2 3/8] dt-bindings: PCI: renesas-pci-usb: Allow multiple clocks Herve Codina
2022-04-14 8:35 ` Geert Uytterhoeven
2022-04-20 13:07 ` Herve Codina
2022-04-20 13:24 ` Rob Herring
2022-04-20 14:55 ` Herve Codina
2022-04-20 13:32 ` Geert Uytterhoeven
2022-04-20 14:56 ` Herve Codina
2022-04-14 7:40 ` [PATCH v2 4/8] dt-bindings: PCI: renesas-pci-usb: Add device tree support for r9a06g032 Herve Codina
2022-04-14 7:40 ` [PATCH v2 5/8] PCI: rcar-gen2: Add R9A06G032 support Herve Codina
2022-04-14 7:40 ` [PATCH v2 6/8] ARM: dts: r9a06g032: Add internal PCI bridge node Herve Codina
2022-04-18 9:02 ` Sergey Shtylyov
2022-04-20 13:19 ` Herve Codina
2022-04-20 19:56 ` Rob Herring
2022-04-14 7:40 ` [PATCH v2 7/8] ARM: dts: r9a06g032: Add USB PHY DT support Herve Codina
2022-04-14 7:40 ` [PATCH v2 8/8] ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419164105.14bf82cf@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.shtylyov@omp.ru \
--cc=thomas.petazzoni@bootlin.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).