From: Rob Herring <robh@kernel.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci <linux-pci@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clement Leger" <clement.leger@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v2 3/8] dt-bindings: PCI: renesas-pci-usb: Allow multiple clocks
Date: Wed, 20 Apr 2022 08:24:59 -0500 [thread overview]
Message-ID: <YmAJq+qUF34IvfiZ@robh.at.kernel.org> (raw)
In-Reply-To: <20220420150759.713fcd02@bootlin.com>
On Wed, Apr 20, 2022 at 03:07:59PM +0200, Herve Codina wrote:
> Hi Geert, Rob,
>
> On Thu, 14 Apr 2022 10:35:07 +0200
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> > Hi Hervé,
> >
> > On Thu, Apr 14, 2022 at 9:40 AM Herve Codina <herve.codina@bootlin.com> wrote:
> > > Define that multiple clocks can be present at clocks property.
> > >
> > > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/pci/renesas,pci-usb.yaml
> > > +++ b/Documentation/devicetree/bindings/pci/renesas,pci-usb.yaml
> > > @@ -54,7 +54,8 @@ properties:
> > > Standard property that helps to define the interrupt mapping.
> > >
> > > clocks:
> > > - description: The reference to the device clock.
> > > + description:
> > > + The references to the device clocks (several clocks can be referenced).
> >
> > Please describe the clocks, and add the missing "clock-names" property.
> >
> > >
> > > bus-range:
> > > description: |
> >
> > I think it would be better to combine this with [PATCH v2 4/8], as the
> > additional clocks are only present on RZ/N1.
> >
> > Then you can easily add json-schema logic to enforce the correct
> > number of clocks, depending on the compatible value.
>
> Sure.
>
> Is there a way to have the clocks description depending on the compatible value.
> I mean something like:
> --- 8< ---
> properties:
> clocks:
> maxItems: 1
This would need to cover both cases:
minItems: 1
maxItems: 3
>
> if:
> properties:
> compatible:
> contains:
> enum:
> - renesas,pci-r9a06g032
> - renesas,pci-rzn1
>
> then:
> properties:
> clocks:
> items:
> - description: Internal bus clock (AHB) for HOST
> - description: Internal bus clock (AHB) Power Management
> - description: PCI clock for USB subsystem
> minItems: 3
> maxItems: 3
Don't need minItems or maxItems here. 3 is the default size based on
'items' length.
>
> else:
> properties:
> items:
I think you meant for this to be under 'clocks'.
> - description: Device clock
> clocks:
> minItems: 1
> maxItems: 1
Just 'maxItems' is enough.
> --- 8< ---
>
> In fact, I would like to describe the 3 clocks only for the r9a06g032 SOC
> and the rzn1 family and have an other description for the other 'compatible'.
>
> I cannot succeed to do it.
>
> The only thing I can do is to leave the description of the 3 clocks out of the
> conditional part. This leads to :
>
> --- 8< ---
> properties:
> clocks:
> items:
> - description: Internal bus clock (AHB) for HOST
> - description: Internal bus clock (AHB) Power Management
> - description: PCI clock for USB subsystem
> minItems: 1
>
> if:
> properties:
> compatible:
> contains:
> enum:
> - renesas,pci-r9a06g032
> - renesas,pci-rzn1
>
> then:
> properties:
> clocks:
> minItems: 3
> maxItems: 3
minItems is enough.
>
> else:
> properties:
> clocks:
> minItems: 1
> maxItems: 1
This doesn't seem right as the description of the first clock is wrong
for this case.
I would go with the first way.
Rob
next prev parent reply other threads:[~2022-04-20 13:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 7:40 [PATCH v2 0/8] RZN1 USB Host support Herve Codina
2022-04-14 7:40 ` [PATCH v2 1/8] PCI: rcar-gen2: Add support for clocks Herve Codina
2022-04-14 8:45 ` Geert Uytterhoeven
2022-04-14 11:29 ` Herve Codina
2022-04-14 11:48 ` Geert Uytterhoeven
2022-04-14 13:42 ` Herve Codina
2022-04-14 7:40 ` [PATCH v2 2/8] dt-bindings: PCI: renesas-pci-usb: Convert bindings to json-schema Herve Codina
2022-04-14 8:08 ` Miquel Raynal
2022-04-14 8:28 ` Geert Uytterhoeven
2022-04-19 14:41 ` Herve Codina
2022-04-14 18:15 ` Rob Herring
2022-04-20 12:44 ` Herve Codina
2022-04-20 13:18 ` Rob Herring
2022-04-20 13:46 ` Herve Codina
2022-04-20 21:37 ` Rob Herring
2022-04-14 7:40 ` [PATCH v2 3/8] dt-bindings: PCI: renesas-pci-usb: Allow multiple clocks Herve Codina
2022-04-14 8:35 ` Geert Uytterhoeven
2022-04-20 13:07 ` Herve Codina
2022-04-20 13:24 ` Rob Herring [this message]
2022-04-20 14:55 ` Herve Codina
2022-04-20 13:32 ` Geert Uytterhoeven
2022-04-20 14:56 ` Herve Codina
2022-04-14 7:40 ` [PATCH v2 4/8] dt-bindings: PCI: renesas-pci-usb: Add device tree support for r9a06g032 Herve Codina
2022-04-14 7:40 ` [PATCH v2 5/8] PCI: rcar-gen2: Add R9A06G032 support Herve Codina
2022-04-14 7:40 ` [PATCH v2 6/8] ARM: dts: r9a06g032: Add internal PCI bridge node Herve Codina
2022-04-18 9:02 ` Sergey Shtylyov
2022-04-20 13:19 ` Herve Codina
2022-04-20 19:56 ` Rob Herring
2022-04-14 7:40 ` [PATCH v2 7/8] ARM: dts: r9a06g032: Add USB PHY DT support Herve Codina
2022-04-14 7:40 ` [PATCH v2 8/8] ARM: dts: r9a06g032: Link the PCI USB devices to the USB PHY Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmAJq+qUF34IvfiZ@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=herve.codina@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=s.shtylyov@omp.ru \
--cc=thomas.petazzoni@bootlin.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).