* [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property
@ 2022-05-26 1:41 Rob Herring
2022-05-26 12:40 ` Rob Herring
2022-05-26 13:48 ` Sven Peter
0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring @ 2022-05-26 1:41 UTC (permalink / raw)
To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Bjorn Helgaas,
Krzysztof Kozlowski, Mark Kettenis
Cc: linux-arm-kernel, linux-pci, devicetree, linux-kernel
The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples.
The Apple PCIe host has 3 power domains at least according to the example.
Add the 'power-domains' property to the schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Ideally, we'd define what each power domain is, but I don't know what
they are.
---
Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/apple,pcie.yaml b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
index daf602ac0d0f..2cf6b4586071 100644
--- a/Documentation/devicetree/bindings/pci/apple,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
@@ -68,6 +68,9 @@ properties:
iommu-map: true
iommu-map-mask: true
+ power-domains:
+ maxItems: 3
+
required:
- compatible
- reg
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property
2022-05-26 1:41 [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property Rob Herring
@ 2022-05-26 12:40 ` Rob Herring
2022-05-26 13:48 ` Sven Peter
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-05-26 12:40 UTC (permalink / raw)
To: Rob Herring
Cc: Sven Peter, Hector Martin, Krzysztof Kozlowski, Mark Kettenis,
linux-pci, linux-arm-kernel, Bjorn Helgaas, linux-kernel,
Alyssa Rosenzweig, devicetree
On Wed, 25 May 2022 20:41:07 -0500, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
>
> The Apple PCIe host has 3 power domains at least according to the example.
> Add the 'power-domains' property to the schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Ideally, we'd define what each power domain is, but I don't know what
> they are.
> ---
> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
pcie@690000000: power-domains: [[59]] is too short
arch/arm64/boot/dts/apple/t8103-j274.dtb
arch/arm64/boot/dts/apple/t8103-j293.dtb
arch/arm64/boot/dts/apple/t8103-j313.dtb
arch/arm64/boot/dts/apple/t8103-j456.dtb
arch/arm64/boot/dts/apple/t8103-j457.dtb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property
2022-05-26 1:41 [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property Rob Herring
2022-05-26 12:40 ` Rob Herring
@ 2022-05-26 13:48 ` Sven Peter
2022-05-26 21:45 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Sven Peter @ 2022-05-26 13:48 UTC (permalink / raw)
To: Rob Herring, Hector Martin, Alyssa Rosenzweig, Bjorn Helgaas,
Krzysztof Kozlowski, Mark Kettenis
Cc: linux-arm-kernel, linux-pci, devicetree, linux-kernel
Hi,
On Thu, May 26, 2022, at 03:41, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
>
> The Apple PCIe host has 3 power domains at least according to the example.
> Add the 'power-domains' property to the schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Ideally, we'd define what each power domain is, but I don't know what
> they are.
> ---
I think the example is just wrong (or outdated) and we only need a single
power-domain for pcie.
The hierarchy is ps_pcie_ref -> ps_apcie -> ps_apcie_gp and the pcie
node then only depends on ps_apcie_gp.
Sven
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property
2022-05-26 13:48 ` Sven Peter
@ 2022-05-26 21:45 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-05-26 21:45 UTC (permalink / raw)
To: Sven Peter
Cc: Hector Martin, Alyssa Rosenzweig, Bjorn Helgaas,
Krzysztof Kozlowski, Mark Kettenis, linux-arm-kernel, linux-pci,
devicetree, linux-kernel
On Thu, May 26, 2022 at 03:48:15PM +0200, Sven Peter wrote:
> Hi,
>
>
> On Thu, May 26, 2022, at 03:41, Rob Herring wrote:
> > The 'unevaluatedProperties' schema checks is not fully working and doesn't
> > catch some cases where there's a $ref to another schema. A fix is pending,
> > but results in new warnings in examples.
> >
> > The Apple PCIe host has 3 power domains at least according to the example.
> > Add the 'power-domains' property to the schema.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Ideally, we'd define what each power domain is, but I don't know what
> > they are.
> > ---
>
> I think the example is just wrong (or outdated) and we only need a single
> power-domain for pcie.
>
> The hierarchy is ps_pcie_ref -> ps_apcie -> ps_apcie_gp and the pcie
> node then only depends on ps_apcie_gp.
Okay, I'll update the example and schema.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-26 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 1:41 [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property Rob Herring
2022-05-26 12:40 ` Rob Herring
2022-05-26 13:48 ` Sven Peter
2022-05-26 21:45 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).