From: Bjorn Helgaas <helgaas@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, bhelgaas@google.com, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, kuba@kernel.org, gospo@broadcom.com,
Pavan Chebbi <pavan.chebbi@broadcom.com>
Subject: Re: [PATCH] PCI: Add ACS quirk for Broadcom BCM5750x NICs
Date: Mon, 13 Jun 2022 19:15:56 -0500 [thread overview]
Message-ID: <20220614001556.GA728570@bhelgaas> (raw)
In-Reply-To: <20220609185811.GA524052@bhelgaas>
On Thu, Jun 09, 2022 at 01:58:13PM -0500, Bjorn Helgaas wrote:
> On Thu, Jun 09, 2022 at 01:41:47PM -0400, Michael Chan wrote:
> > From: Pavan Chebbi <pavan.chebbi@broadcom.com>
> >
> > The Broadcom BCM5750x NICs may be multi-function devices. They do
> > not advertise ACS capability. Peer-to-peer transactions are not
> > possible between the individual functions, so it is safe to treat
> > them as fully isolated.
> >
> > Add an ACS quirk for these devices so the functions can be in
> > independent IOMMU groups and attached individually to userspace
> > applications using VFIO.
> >
> > Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
> > Signed-off-by: Michael Chan <michael.chan@broadcom.com>
>
> Applied to pci/virtualization for v5.20, thanks!
I forgot to ask: is there a plan for future devices to include an ACS
capability? Or will we be stuck adding quirks forever?
> > ---
> > drivers/pci/quirks.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index 41aeaa235132..2e68f50bc7ae 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -4924,6 +4924,9 @@ static const struct pci_dev_acs_enabled {
> > { PCI_VENDOR_ID_AMPERE, 0xE00C, pci_quirk_xgene_acs },
> > /* Broadcom multi-function device */
> > { PCI_VENDOR_ID_BROADCOM, 0x16D7, pci_quirk_mf_endpoint_acs },
> > + { PCI_VENDOR_ID_BROADCOM, 0x1750, pci_quirk_mf_endpoint_acs },
> > + { PCI_VENDOR_ID_BROADCOM, 0x1751, pci_quirk_mf_endpoint_acs },
> > + { PCI_VENDOR_ID_BROADCOM, 0x1752, pci_quirk_mf_endpoint_acs },
> > { PCI_VENDOR_ID_BROADCOM, 0xD714, pci_quirk_brcm_acs },
> > /* Amazon Annapurna Labs */
> > { PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS, 0x0031, pci_quirk_al_acs },
> > --
> > 2.18.1
> >
>
>
next prev parent reply other threads:[~2022-06-14 0:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 17:41 [PATCH] PCI: Add ACS quirk for Broadcom BCM5750x NICs Michael Chan
2022-06-09 18:58 ` Bjorn Helgaas
2022-06-14 0:15 ` Bjorn Helgaas [this message]
2022-06-27 7:30 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614001556.GA728570@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).