From: Michael Chan <michael.chan@broadcom.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Bjorn Helgaas <bhelgaas@google.com>,
Netdev <netdev@vger.kernel.org>,
linux-pci@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Andrew Gospodarek <gospo@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>
Subject: Re: [PATCH] PCI: Add ACS quirk for Broadcom BCM5750x NICs
Date: Mon, 27 Jun 2022 00:30:03 -0700 [thread overview]
Message-ID: <CACKFLinvohm+jRupNZAV=G+OHg1buXvLDrs0yGgPY3o6NB8biA@mail.gmail.com> (raw)
In-Reply-To: <20220614001556.GA728570@bhelgaas>
[-- Attachment #1: Type: text/plain, Size: 1164 bytes --]
On Mon, Jun 13, 2022 at 5:16 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Thu, Jun 09, 2022 at 01:58:13PM -0500, Bjorn Helgaas wrote:
> > On Thu, Jun 09, 2022 at 01:41:47PM -0400, Michael Chan wrote:
> > > From: Pavan Chebbi <pavan.chebbi@broadcom.com>
> > >
> > > The Broadcom BCM5750x NICs may be multi-function devices. They do
> > > not advertise ACS capability. Peer-to-peer transactions are not
> > > possible between the individual functions, so it is safe to treat
> > > them as fully isolated.
> > >
> > > Add an ACS quirk for these devices so the functions can be in
> > > independent IOMMU groups and attached individually to userspace
> > > applications using VFIO.
> > >
> > > Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
> > > Signed-off-by: Michael Chan <michael.chan@broadcom.com>
> >
> > Applied to pci/virtualization for v5.20, thanks!
>
> I forgot to ask: is there a plan for future devices to include an ACS
> capability? Or will we be stuck adding quirks forever?
>
I still have not heard back definitively from the hardware team yet.
It's likely that the next device will not have ACS but the one after
that will have it.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
prev parent reply other threads:[~2022-06-27 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 17:41 [PATCH] PCI: Add ACS quirk for Broadcom BCM5750x NICs Michael Chan
2022-06-09 18:58 ` Bjorn Helgaas
2022-06-14 0:15 ` Bjorn Helgaas
2022-06-27 7:30 ` Michael Chan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACKFLinvohm+jRupNZAV=G+OHg1buXvLDrs0yGgPY3o6NB8biA@mail.gmail.com' \
--to=michael.chan@broadcom.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=gospo@broadcom.com \
--cc=helgaas@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).