* [PATCH v3] PCI: endpoint: Fix WARN() when an endpoint driver is removed
@ 2022-06-23 0:38 Yoshihiro Shimoda
2022-10-27 13:03 ` Lorenzo Pieralisi
0 siblings, 1 reply; 2+ messages in thread
From: Yoshihiro Shimoda @ 2022-06-23 0:38 UTC (permalink / raw)
To: kishon, lpieralisi, kw, bhelgaas
Cc: linux-pci, linux-renesas-soc, Yoshihiro Shimoda, Vidya Sagar,
Manivannan Sadhasivam
Since there is no release callback defined for the PCI EPC device,
the below warning is thrown by driver core when a PCI endpoint driver is
removed:
Device 'e65d0000.pcie-ep' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.
WARNING: CPU: 0 PID: 139 at drivers/base/core.c:2232 device_release+0x78/0x8c
Hence, add the release callback and also move the kfree(epc) from
pci_epc_destroy() so that the epc memory is freed when all references are
dropped.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Vidya Sagar <vidyas@nvidia.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
Changes from v2:
- Revised the commit description which is suggested by Manivannan Sadhasivam
(thanks!).
- Add Tested-by and Reviewed-by tags (thanks!).
https://lore.kernel.org/all/20220622025031.51812-1-yoshihiro.shimoda.uh@renesas.com/
Changes from v1:
- Move kfree(epc) to the release function.
- Revised the commit description.
https://lore.kernel.org/all/20220621121147.3971001-1-yoshihiro.shimoda.uh@renesas.com/
drivers/pci/endpoint/pci-epc-core.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
index 3bc9273d0a08..2542196e8c3d 100644
--- a/drivers/pci/endpoint/pci-epc-core.c
+++ b/drivers/pci/endpoint/pci-epc-core.c
@@ -724,7 +724,6 @@ void pci_epc_destroy(struct pci_epc *epc)
{
pci_ep_cfs_remove_epc_group(epc->group);
device_unregister(&epc->dev);
- kfree(epc);
}
EXPORT_SYMBOL_GPL(pci_epc_destroy);
@@ -746,6 +745,11 @@ void devm_pci_epc_destroy(struct device *dev, struct pci_epc *epc)
}
EXPORT_SYMBOL_GPL(devm_pci_epc_destroy);
+static void pci_epc_release(struct device *dev)
+{
+ kfree(to_pci_epc(dev));
+}
+
/**
* __pci_epc_create() - create a new endpoint controller (EPC) device
* @dev: device that is creating the new EPC
@@ -779,6 +783,7 @@ __pci_epc_create(struct device *dev, const struct pci_epc_ops *ops,
device_initialize(&epc->dev);
epc->dev.class = pci_epc_class;
epc->dev.parent = dev;
+ epc->dev.release = pci_epc_release;
epc->ops = ops;
ret = dev_set_name(&epc->dev, "%s", dev_name(dev));
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] PCI: endpoint: Fix WARN() when an endpoint driver is removed
2022-06-23 0:38 [PATCH v3] PCI: endpoint: Fix WARN() when an endpoint driver is removed Yoshihiro Shimoda
@ 2022-10-27 13:03 ` Lorenzo Pieralisi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2022-10-27 13:03 UTC (permalink / raw)
To: bhelgaas, Yoshihiro Shimoda, kw, kishon
Cc: Lorenzo Pieralisi, linux-renesas-soc, Manivannan Sadhasivam,
linux-pci, Vidya Sagar
On Thu, 23 Jun 2022 09:38:17 +0900, Yoshihiro Shimoda wrote:
> Since there is no release callback defined for the PCI EPC device,
> the below warning is thrown by driver core when a PCI endpoint driver is
> removed:
>
> Device 'e65d0000.pcie-ep' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.
> WARNING: CPU: 0 PID: 139 at drivers/base/core.c:2232 device_release+0x78/0x8c
>
> [...]
Applied to pci/endpoint, thanks!
[1/1] PCI: endpoint: Fix WARN() when an endpoint driver is removed
https://git.kernel.org/lpieralisi/pci/c/7711cbb4862a
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-27 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-23 0:38 [PATCH v3] PCI: endpoint: Fix WARN() when an endpoint driver is removed Yoshihiro Shimoda
2022-10-27 13:03 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).