From: Bjorn Helgaas <helgaas@kernel.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Achal Verma <a-verma1@ti.com>, Tom Joseph <tjoseph@cadence.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Wilczy_ski <kw@linux.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Milind Parab <mparab@cadence.com>
Subject: Re: [PATCH v2 2/2] PCI: j721e: Add support to build pci-j721e as module.
Date: Tue, 10 Jan 2023 09:38:05 -0600 [thread overview]
Message-ID: <20230110153805.GA1505901@bhelgaas> (raw)
In-Reply-To: <db93c472-f617-3207-af57-55b14de8e236@ti.com>
On Mon, Jan 09, 2023 at 09:06:14PM +0530, Vignesh Raghavendra wrote:
> On 09/01/23 6:05 pm, Achal Verma wrote:
> > Discussed with Vignesh the current config dependency of pcie-cadence and pci-j721e modules,
> > it seems like for now to modularize these drivers with minimal changes is to use "select"
> > as they were used before in PCI_J721E_HOST and PCI_J721E_EP config options.
>
> With this patch its now impossible to build PCI_J721E_HOST without
> pcie endpoint support (as PCI_ENDPOINT is now a dependency). I don't
> know a way to achieve this via Kconfig magic w/o splitting pci-j721e.c
> into EP/RC (like pcie-rcar* or pcie-rockchip*)
>
> > Will push updated version with "depends on PCI_ENDPOINT" in PCI_J721E config to check
> > dependency on PCI_ENDPOINT before selecting PCIE_CADENCE_EP.
> >
>
> Please don't top post and respond inline:
> https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
Apparently there was also email from Achal to Vignesh that didn't make
it to the archives, probably because it was HTML or other "fancy"
email. See the thread overview here, which is missing something:
https://lore.kernel.org/all/20230108155755.2614147-1-a-verma1@ti.com/
It's best to use plain text email when possible. See
http://vger.kernel.org/majordomo-info.html for details.
Bjorn
prev parent reply other threads:[~2023-01-10 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 15:57 [PATCH v2 0/2] Add support to build pci-j721e as a module Achal Verma
2023-01-08 15:57 ` [PATCH v2 1/2] PCI: cadence: Add support to build pcie-cadence library as module Achal Verma
2023-01-08 15:57 ` [PATCH v2 2/2] PCI: j721e: Add support to build pci-j721e " Achal Verma
2023-01-09 3:53 ` Vignesh Raghavendra
[not found] ` <20230109123550.GA2647927@desktop-3598>
2023-01-09 15:36 ` Vignesh Raghavendra
2023-01-10 15:38 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110153805.GA1505901@bhelgaas \
--to=helgaas@kernel.org \
--cc=a-verma1@ti.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mparab@cadence.com \
--cc=robh@kernel.org \
--cc=tjoseph@cadence.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).