From: Vignesh Raghavendra <vigneshr@ti.com>
To: Achal Verma <a-verma1@ti.com>, Tom Joseph <tjoseph@cadence.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Wilczy_ski <kw@linux.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Milind Parab <mparab@cadence.com>
Subject: Re: [PATCH v2 2/2] PCI: j721e: Add support to build pci-j721e as module.
Date: Mon, 9 Jan 2023 09:23:37 +0530 [thread overview]
Message-ID: <8dc31852-3d1c-860d-7844-15205f8fd6c6@ti.com> (raw)
In-Reply-To: <20230108155755.2614147-3-a-verma1@ti.com>
Hi Achal,
On 08/01/23 21:27, Achal Verma wrote:
> Add support to build pci-j721e as module.
>
> Signed-off-by: Achal Verma <a-verma1@ti.com>
> ---
> drivers/pci/controller/cadence/Kconfig | 10 +++++-----
> drivers/pci/controller/cadence/pci-j721e.c | 6 +++++-
> 2 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/controller/cadence/Kconfig b/drivers/pci/controller/cadence/Kconfig
> index 693c41fe32ce..51edf723586c 100644
> --- a/drivers/pci/controller/cadence/Kconfig
> +++ b/drivers/pci/controller/cadence/Kconfig
> @@ -43,12 +43,13 @@ config PCIE_CADENCE_PLAT_EP
> different vendors SoCs.
>
> config PCI_J721E
> - bool
> + tristate
> + select PCIE_CADENCE_HOST
> + select PCIE_CADENCE_EP
>
Please don't use select when symbol being selected, depends on
additional configs
Documentation/kbuild/kconfig-language.rst::
select should be used with care. select will force
a symbol to a value without visiting the dependencies.
By abusing select you are able to select a symbol FOO even
if FOO depends on BAR that is not set.
> config PCI_J721E_HOST
> - bool "TI J721E PCIe platform host controller"
> + tristate "TI J721E PCIe platform host controller"
> depends on OF
> - select PCIE_CADENCE_HOST
> select PCI_J721E
> help
> Say Y here if you want to support the TI J721E PCIe platform
> @@ -56,10 +57,9 @@ config PCI_J721E_HOST
> core.
>
> config PCI_J721E_EP
> - bool "TI J721E PCIe platform endpoint controller"
> + tristate "TI J721E PCIe platform endpoint controller"
> depends on OF
> depends on PCI_ENDPOINT
> - select PCIE_CADENCE_EP
> select PCI_J721E
> help
> Say Y here if you want to support the TI J721E PCIe platform
> diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
> index cc83a8925ce0..c4017fa6ae61 100644
> --- a/drivers/pci/controller/cadence/pci-j721e.c
> +++ b/drivers/pci/controller/cadence/pci-j721e.c
> @@ -13,6 +13,7 @@
> #include <linux/irqchip/chained_irq.h>
> #include <linux/irqdomain.h>
> #include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/pci.h>
> @@ -565,4 +566,7 @@ static struct platform_driver j721e_pcie_driver = {
> .suppress_bind_attrs = true,
> },
> };
> -builtin_platform_driver(j721e_pcie_driver);
> +module_platform_driver(j721e_pcie_driver);
> +
> +MODULE_AUTHOR("Kishon Vijay Abraham I <kishon@ti.com>");
> +MODULE_LICENSE("GPL v2");
--
Regards
Vignesh
next prev parent reply other threads:[~2023-01-09 3:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 15:57 [PATCH v2 0/2] Add support to build pci-j721e as a module Achal Verma
2023-01-08 15:57 ` [PATCH v2 1/2] PCI: cadence: Add support to build pcie-cadence library as module Achal Verma
2023-01-08 15:57 ` [PATCH v2 2/2] PCI: j721e: Add support to build pci-j721e " Achal Verma
2023-01-09 3:53 ` Vignesh Raghavendra [this message]
[not found] ` <20230109123550.GA2647927@desktop-3598>
2023-01-09 15:36 ` Vignesh Raghavendra
2023-01-10 15:38 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc31852-3d1c-860d-7844-15205f8fd6c6@ti.com \
--to=vigneshr@ti.com \
--cc=a-verma1@ti.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mparab@cadence.com \
--cc=robh@kernel.org \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).