linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	Robin Murphy <robin.murphy@arm.com>,
	Jingoo Han <jingoohan1@gmail.com>, Frank Li <Frank.Li@nxp.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
	"Serge Semin" <fancer.lancer@gmail.com>,
	"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
	"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	caihuoqing <caihuoqing@baidu.com>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v9 24/27] dmaengine: dw-edma: Relax driver config settings
Date: Fri, 13 Jan 2023 20:14:06 +0300	[thread overview]
Message-ID: <20230113171409.30470-25-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20230113171409.30470-1-Sergey.Semin@baikalelectronics.ru>

Since the DW PCIe RP/EP driver is about to be updated to register the DW
eDMA-based DMA-engine the drivers build modes must be synchronized.
Currently the DW PCIe RP/EP driver is always built as a builtin module.
Meanwhile the DW eDMA driver can be built as a loadable module. Thus in
the later case the kernel with DW PCIe controllers support will fail to be
linked due to lacking the DW eDMA probe/remove symbols. At the same time
forcibly selecting the DW eDMA driver from the DW PCIe RP/EP kconfig will
effectively eliminate the tristate type of the former driver fixing it to
just the builtin kernel module.

Seeing the DW eDMA engine isn't that often met built into the DW PCIe
Root-ports and End-points let's convert the DW eDMA driver config to being
more flexible instead of just forcibly selecting the DW eDMA kconfig. In
order to do that first the DW eDMA PCIe driver config should be converted
to being depended from the DW eDMA core config instead of selecting the
one. Second the DW eDMA probe and remove symbols should be referenced only
if they are reachable by the caller. Thus the user will be able to build
the DW eDMA core driver with any type, meanwhile the dependent code will
be either restricted to the same build type (e.g. DW eDMA PCIe driver if
DW eDMA driver is built as a loadable module) or just won't be able to use
the eDMA engine registration/de-registration functionality (e.g. DW PCIe
RP/EP driver if DW eDMA driver is built as a loadable module).

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

---

Changelog v8:
- This is a new patch added on v8 stage of the series in order to fix
  the tbot-reported build issues. (@tbot)
---
 drivers/dma/dw-edma/Kconfig | 5 ++++-
 include/linux/dma/edma.h    | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/dw-edma/Kconfig b/drivers/dma/dw-edma/Kconfig
index 7ff17b2db6a1..2b6f2679508d 100644
--- a/drivers/dma/dw-edma/Kconfig
+++ b/drivers/dma/dw-edma/Kconfig
@@ -9,11 +9,14 @@ config DW_EDMA
 	  Support the Synopsys DesignWare eDMA controller, normally
 	  implemented on endpoints SoCs.
 
+if DW_EDMA
+
 config DW_EDMA_PCIE
 	tristate "Synopsys DesignWare eDMA PCIe driver"
 	depends on PCI && PCI_MSI
-	select DW_EDMA
 	help
 	  Provides a glue-logic between the Synopsys DesignWare
 	  eDMA controller and an endpoint PCIe device. This also serves
 	  as a reference design to whom desires to use this IP.
+
+endif # DW_EDMA
diff --git a/include/linux/dma/edma.h b/include/linux/dma/edma.h
index 08833f12b386..c062c8db472c 100644
--- a/include/linux/dma/edma.h
+++ b/include/linux/dma/edma.h
@@ -101,7 +101,7 @@ struct dw_edma_chip {
 };
 
 /* Export to the platform drivers */
-#if IS_ENABLED(CONFIG_DW_EDMA)
+#if IS_REACHABLE(CONFIG_DW_EDMA)
 int dw_edma_probe(struct dw_edma_chip *chip);
 int dw_edma_remove(struct dw_edma_chip *chip);
 #else
-- 
2.39.0



  parent reply	other threads:[~2023-01-13 17:25 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 17:13 [PATCH v9 00/27] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2023-01-13 17:13 ` [PATCH v9 01/27] dmaengine: Fix dma_slave_config.dst_addr description Serge Semin
2023-01-13 17:13 ` [PATCH v9 02/27] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2023-01-13 17:13 ` [PATCH v9 03/27] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2023-01-13 17:13 ` [PATCH v9 04/27] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2023-01-13 17:13 ` [PATCH v9 05/27] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2023-01-13 17:13 ` [PATCH v9 06/27] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2023-01-13 17:13 ` [PATCH v9 07/27] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2023-01-13 17:13 ` [PATCH v9 08/27] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2023-01-20 23:29   ` Bjorn Helgaas
2023-01-21 20:37     ` Serge Semin
2023-01-13 17:13 ` [PATCH v9 09/27] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2023-01-20 23:54   ` Bjorn Helgaas
2023-01-21 21:10     ` Serge Semin
2023-01-13 17:13 ` [PATCH v9 10/27] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2023-01-13 17:13 ` [PATCH v9 11/27] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2023-01-13 17:13 ` [PATCH v9 12/27] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2023-01-13 17:13 ` [PATCH v9 13/27] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2023-01-13 17:13 ` [PATCH v9 14/27] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2023-01-13 17:13 ` [PATCH v9 15/27] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2023-01-13 17:13 ` [PATCH v9 16/27] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2023-01-13 17:13 ` [PATCH v9 17/27] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2023-01-13 17:14 ` [PATCH v9 18/27] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2023-01-13 17:14 ` [PATCH v9 19/27] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2023-01-21  0:54   ` Bjorn Helgaas
2023-01-21 23:03     ` Serge Semin
2023-01-23 16:37       ` Bjorn Helgaas
2023-01-24 13:44         ` Serge Semin
2023-01-13 17:14 ` [PATCH v9 20/27] dmaengine: dw-edma: Drop DT-region allocation Serge Semin
2023-01-13 17:14 ` [PATCH v9 21/27] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2023-01-13 17:14 ` [PATCH v9 22/27] dmaengine: dw-edma: Skip cleanup procedure if no private data found Serge Semin
2023-01-13 17:14 ` [PATCH v9 23/27] dmaengine: dw-edma: Add mem-mapped LL-entries support Serge Semin
2023-02-21 23:00   ` Bjorn Helgaas
2023-02-22 16:16     ` Vinod Koul
2023-01-13 17:14 ` Serge Semin [this message]
2023-01-20 22:50   ` [PATCH v9 24/27] dmaengine: dw-edma: Relax driver config settings Bjorn Helgaas
2023-01-22  0:11     ` Serge Semin
2023-01-23 16:43       ` Bjorn Helgaas
2023-01-24 14:49         ` Serge Semin
2023-01-24 23:47           ` Bjorn Helgaas
2023-01-25 14:40             ` Serge Semin
2023-01-25 23:23               ` Bjorn Helgaas
2023-01-26 16:37                 ` Serge Semin
2023-01-26 18:19                   ` Bjorn Helgaas
2023-01-26 21:16                     ` Serge Semin
2023-01-13 17:14 ` [PATCH v9 25/27] PCI: dwc: Set coherent DMA-mask on MSI-address allocation Serge Semin
2023-01-20 21:59   ` Bjorn Helgaas
2023-01-22  0:34     ` Serge Semin
2023-01-13 17:14 ` [PATCH v9 26/27] PCI: bt1: Set 64-bit DMA-mask Serge Semin
2023-01-13 17:14 ` [PATCH v9 27/27] PCI: dwc: Add DW eDMA engine support Serge Semin
2023-01-13 18:34 ` [PATCH v9 00/27] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2023-01-16  9:52 ` Lorenzo Pieralisi
2023-01-16 11:29   ` Serge Semin
2023-01-20 15:17 ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113171409.30470-25-Sergey.Semin@baikalelectronics.ru \
    --to=sergey.semin@baikalelectronics.ru \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Frank.Li@nxp.com \
    --cc=Pavel.Parkhomenko@baikalelectronics.ru \
    --cc=bhelgaas@google.com \
    --cc=cai.huoqing@linux.dev \
    --cc=caihuoqing@baidu.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=vkoul@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).