From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Cc: "Rick Wertenbroek" <rick.wertenbroek@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: [PATCH 12/12] misc: pci_endpoint_test: Add debug and error messages
Date: Wed, 15 Feb 2023 12:21:55 +0900 [thread overview]
Message-ID: <20230215032155.74993-13-damien.lemoal@opensource.wdc.com> (raw)
In-Reply-To: <20230215032155.74993-1-damien.lemoal@opensource.wdc.com>
Add dynamic debug messages with dev_dbg() to help troubleshoot issues
when running the endpoint tests. The debug messages for errors detected
in pci_endpoint_test_validate_xfer_params() are changed to error
messages.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/misc/pci_endpoint_test.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index b05d3db85da8..c47f6e708ea2 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -267,12 +267,15 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test,
u32 val;
int size;
struct pci_dev *pdev = test->pdev;
+ struct device *dev = &pdev->dev;
if (!test->bar[barno])
return false;
size = pci_resource_len(pdev, barno);
+ dev_dbg(dev, "Test BAR %d, %d B\n", (int)barno, size);
+
if (barno == test->test_reg_bar)
size = 0x4;
@@ -291,6 +294,10 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test,
static bool pci_endpoint_test_legacy_irq(struct pci_endpoint_test *test)
{
u32 val;
+ struct pci_dev *pdev = test->pdev;
+ struct device *dev = &pdev->dev;
+
+ dev_dbg(dev, "Test legacy IRQ\n");
pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE,
IRQ_TYPE_LEGACY);
@@ -310,6 +317,9 @@ static bool pci_endpoint_test_msi_irq(struct pci_endpoint_test *test,
{
u32 val;
struct pci_dev *pdev = test->pdev;
+ struct device *dev = &pdev->dev;
+
+ dev_dbg(dev, "Test MSI%s %d\n", msix ? "X" : "", msi_num);
pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE,
msix ? IRQ_TYPE_MSIX : IRQ_TYPE_MSI);
@@ -329,12 +339,12 @@ static int pci_endpoint_test_validate_xfer_params(struct device *dev,
struct pci_endpoint_test_xfer_param *param, size_t alignment)
{
if (!param->size) {
- dev_dbg(dev, "Data size is zero\n");
+ dev_err(dev, "Data size is zero\n");
return -EINVAL;
}
if (param->size > SIZE_MAX - alignment) {
- dev_dbg(dev, "Maximum transfer data size exceeded\n");
+ dev_err(dev, "Maximum transfer data size exceeded\n");
return -EINVAL;
}
@@ -444,6 +454,10 @@ static bool pci_endpoint_test_copy(struct pci_endpoint_test *test,
dst_addr = orig_dst_addr;
}
+ dev_dbg(dev,
+ "Test COPY align %zu, src phys addr 0x%llx, dst phys addr 0x%llx, %zu B\n",
+ alignment, src_phys_addr, dst_phys_addr, size);
+
pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_LOWER_DST_ADDR,
lower_32_bits(dst_phys_addr));
pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_UPPER_DST_ADDR,
@@ -549,6 +563,10 @@ static bool pci_endpoint_test_write(struct pci_endpoint_test *test,
addr = orig_addr;
}
+ dev_dbg(dev,
+ "Test WRITE align %zu, phys addr 0x%llx, %zu B\n",
+ alignment, phys_addr, size);
+
crc32 = crc32_le(~0, addr, size);
pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_CHECKSUM,
crc32);
@@ -647,6 +665,10 @@ static bool pci_endpoint_test_read(struct pci_endpoint_test *test,
addr = orig_addr;
}
+ dev_dbg(dev,
+ "Test READ align %zu, phys addr 0x%llx, %zu B\n",
+ alignment, phys_addr, size);
+
pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_LOWER_DST_ADDR,
lower_32_bits(phys_addr));
pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_UPPER_DST_ADDR,
--
2.39.1
next prev parent reply other threads:[~2023-02-15 3:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 3:21 [PATCH 00/12] PCI endpoint fixes and improvements Damien Le Moal
2023-02-15 3:21 ` [PATCH 01/12] pci: endpoint: Automatically create a function type attributes group Damien Le Moal
2023-02-16 10:04 ` Manivannan Sadhasivam
2023-02-16 12:31 ` Damien Le Moal
2023-02-15 3:21 ` [PATCH 02/12] pci: endpoint: do not export pci_epf_type_add_cfs() Damien Le Moal
2023-02-16 10:15 ` Manivannan Sadhasivam
2023-02-16 12:33 ` Damien Le Moal
2023-02-15 3:21 ` [PATCH 03/12] pci: epf-test: Fix DMA transfer completion detection Damien Le Moal
2023-02-16 10:18 ` Manivannan Sadhasivam
2023-02-15 3:21 ` [PATCH 04/12] pci: epf-test: Use driver registers as volatile Damien Le Moal
2023-02-16 10:23 ` Manivannan Sadhasivam
2023-02-15 3:21 ` [PATCH 05/12] pci: epf-test: Simplify dma support checks Damien Le Moal
2023-02-16 10:27 ` Manivannan Sadhasivam
2023-02-15 3:21 ` [PATCH 06/12] pci: epf-test: Simplify transfers result print Damien Le Moal
2023-02-16 10:39 ` Manivannan Sadhasivam
2023-02-15 3:21 ` [PATCH 07/12] pci: epf-test: Add debug and error messages Damien Le Moal
2023-02-15 11:34 ` Greg Kroah-Hartman
2023-02-15 11:44 ` Damien Le Moal
2023-02-15 11:34 ` Greg Kroah-Hartman
2023-02-15 11:45 ` Damien Le Moal
2023-02-15 12:01 ` Greg Kroah-Hartman
2023-02-15 12:18 ` Damien Le Moal
2023-02-15 13:24 ` Greg Kroah-Hartman
2023-02-15 13:49 ` Arnd Bergmann
2023-02-15 22:55 ` Damien Le Moal
2023-02-15 3:21 ` [PATCH 08/12] misc: pci_endpoint_test: Free IRQs before removing the device Damien Le Moal
2023-02-16 10:46 ` Manivannan Sadhasivam
2023-02-15 3:21 ` [PATCH 09/12] misc: pci_endpoint_test: Do not write status in IRQ handler Damien Le Moal
2023-02-16 10:51 ` Manivannan Sadhasivam
2023-02-15 3:21 ` [PATCH 10/12] misc: pci_endpoint_test: Re-init completion for every test Damien Le Moal
2023-02-16 10:55 ` Manivannan Sadhasivam
2023-02-16 12:35 ` Damien Le Moal
2023-02-15 3:21 ` [PATCH 11/12] misc: pci_endpoint_test: Simplify pci_endpoint_test_msi_irq() Damien Le Moal
2023-02-16 10:57 ` Manivannan Sadhasivam
2023-02-15 3:21 ` Damien Le Moal [this message]
2023-02-15 11:34 ` [PATCH 12/12] misc: pci_endpoint_test: Add debug and error messages Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215032155.74993-13-damien.lemoal@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=rick.wertenbroek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).