From: Sinan Kaya <okaya@kernel.org>
To: Huacai Chen <chenhuacai@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
huangshuai@loongson.cn
Cc: Huacai Chen <chenhuacai@loongson.cn>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci <linux-pci@vger.kernel.org>,
Xuefeng Li <lixuefeng@loongson.cn>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>
Subject: Re: [PATCH V2 1/4] PCI/portdrv: Don't disable device during shutdown
Date: Mon, 7 Jun 2021 23:43:05 +0300 [thread overview]
Message-ID: <21b1495f-689f-2d75-d896-2a33c03b186b@kernel.org> (raw)
In-Reply-To: <CAAhV-H4paNzoF4tEJd1_Z2VgBr64t3evfjdmrrA3CZMw=AXrGw@mail.gmail.com>
On 6/4/2021 12:24 PM, Huacai Chen wrote:
>> So you need to explain why we need to allow DMA from those devices
>> even after we shutdown the port. "It makes reboot work" is not a
>> sufficient explanation.
> I think only the designer of LS7A can tell us why. So, Mr. Shuai
> Huang, could you please explain this?
>
Could there be some kind of a shutdown/init problem on your graphics
card driver?
During shutdown, remove() callback of all endpoints get called. This is
the opportunity for your graphics driver to put hardware into safe
state.
If there is a problem with the hardware/driver, it should be a quirk as
opposed to changing the default safe behavior for all devices.
The port driver here prevents memory from getting corrupted by rogue
hardware. There is a window during kexec where hardware can write to
system memory addresses if IOVA addresses and system memory addresses
overlap.
next prev parent reply other threads:[~2021-06-07 20:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 7:14 [PATCH V2 0/4] PCI: Loongson-related pci quirks Huacai Chen
2021-05-28 7:15 ` [PATCH V2 1/4] PCI/portdrv: Don't disable device during shutdown Huacai Chen
2021-05-28 21:43 ` Bjorn Helgaas
2021-06-04 9:24 ` Huacai Chen
2021-06-07 20:43 ` Sinan Kaya [this message]
2021-06-12 4:31 ` Huacai Chen
2021-05-28 7:15 ` [PATCH V2 2/4] PCI: Move loongson pci quirks to quirks.c Huacai Chen
2021-06-05 21:15 ` Bjorn Helgaas
2021-06-06 8:14 ` LoongArch (was: Re: [PATCH V2 2/4] PCI: Move loongson pci quirks to quirks.c) Jiaxun Yang
2021-06-07 0:51 ` Huacai Chen
2021-05-28 7:15 ` [PATCH V2 3/4] PCI: Improve the MRRS quirk for LS7A Huacai Chen
2021-05-28 20:32 ` Bjorn Helgaas
2021-06-04 9:43 ` Huacai Chen
2021-06-05 21:34 ` Bjorn Helgaas
2021-06-12 4:16 ` Huacai Chen
2021-05-28 7:15 ` [PATCH V2 4/4] PCI: Add quirk for multifunction devices of LS7A Huacai Chen
2021-05-28 20:51 ` Bjorn Helgaas
2021-06-04 9:59 ` Huacai Chen
2021-06-05 21:28 ` Bjorn Helgaas
2021-06-06 8:01 ` Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21b1495f-689f-2d75-d896-2a33c03b186b@kernel.org \
--to=okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=helgaas@kernel.org \
--cc=huangshuai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-pci@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).