linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Clint Sbisa <csbisa@amazon.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
	linux-arm-kernel@lists.infradead.org, will@kernel.org,
	catalin.marinas@arm.com, Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH] arm64: Enable PCI write-combine resources under sysfs
Date: Tue, 15 Sep 2020 09:25:57 +1000	[thread overview]
Message-ID: <2b539df4c9ec703458e46da2fc879ee3b310b31c.camel@kernel.crashing.org> (raw)
In-Reply-To: <20200914225740.GP904879@nvidia.com>

On Mon, 2020-09-14 at 19:57 -0300, Jason Gunthorpe wrote:
> On Tue, Sep 15, 2020 at 08:00:27AM +1000, Benjamin Herrenschmidt wrote:
> > On Tue, 2020-09-15 at 07:42 +1000, Benjamin Herrenschmidt wrote:
> > > 
> > > > which is back to my original question, how do you do DMA using
> > > > /sys/xx/resources? Why not use VFIO like everything else?
> > > 
> > > Note: All this doesnt' change the fact that sys/xx/resources_wc
> > > exists
> > > for other archs and I see no reasons so far not to have it on ARM...
> > 
> > Also... it looks like VFIO also doesn't provide a way to do WC yet
> > unfortunately :-(
> 
> Yes, but if the driving reason for this patch is because a VFIO user
> like EFA DPDK is trying to work around VFIO limitations, then I'd say
> the VFIO mmap should be amended, and not so much worring about sysfs.

I don't think the two are exclusive.

> While there is no reason for ARM to not show the sysfs, it really
> should never be used. Modern kernels in secure boot don't even show
> it, for instance.

It's useful for random things, I've used it quite a bit in a previous
life for things like in-lab hw testing etc...  There's tooling out
there, esp. in the more 'embedded' side of thing that uses this, I
don't see a good reason not to provide the same level of functionality.

So Lorenzo, imho, we should merge the patch.

As for fixing VFIO, definitely something to revive. The main contention
point was which "interface" to use to request write combine.

Let's restart that conversation with the appropriate folks, the last I
remember, the question was to figure out what interface to provide
userspace for the functionality.

Clint, do you want to drive this as well ?

Cheers,
Ben.


  reply	other threads:[~2020-09-14 23:26 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 15:18 [PATCH] arm64: Enable PCI write-combine resources under sysfs Clint Sbisa
2020-08-31 23:24 ` Benjamin Herrenschmidt
2020-09-01 18:37 ` Bjorn Helgaas
2020-09-01 23:22   ` Benjamin Herrenschmidt
2020-09-02  8:57     ` Will Deacon
2020-09-02 11:32 ` Lorenzo Pieralisi
2020-09-02 14:29   ` Clint Sbisa
2020-09-02 16:47     ` Lorenzo Pieralisi
2020-09-02 17:21       ` Catalin Marinas
2020-09-02 17:54         ` Lorenzo Pieralisi
2020-09-02 23:03           ` Benjamin Herrenschmidt
2020-09-02 23:08         ` Benjamin Herrenschmidt
2020-09-02 23:08           ` Benjamin Herrenschmidt
2020-09-02 23:07       ` Benjamin Herrenschmidt
2020-09-03 11:08         ` Lorenzo Pieralisi
2020-09-03 14:36           ` Clint Sbisa
2020-09-03 22:26           ` Benjamin Herrenschmidt
2020-09-07 23:33           ` Benjamin Herrenschmidt
2020-09-10  9:46             ` Lorenzo Pieralisi
2020-09-10 10:54               ` Leon Romanovsky
2020-09-10 12:37               ` Jason Gunthorpe
2020-09-10 15:17                 ` Lorenzo Pieralisi
2020-09-10 17:10                   ` Jason Gunthorpe
2020-09-10 21:46                     ` Benjamin Herrenschmidt
2020-09-10 23:29                       ` Jason Gunthorpe
2020-09-11  0:39                         ` Benjamin Herrenschmidt
2020-09-11 14:21                           ` Jason Gunthorpe
2020-09-11 21:42                           ` Clint Sbisa
2020-09-14 14:17                             ` Jason Gunthorpe
2020-09-14 14:24                               ` Clint Sbisa
2020-09-14 14:38                                 ` Jason Gunthorpe
2020-09-14 21:42                                   ` Benjamin Herrenschmidt
2020-09-14 22:00                                     ` Benjamin Herrenschmidt
2020-09-14 22:32                                       ` Clint Sbisa
2020-09-14 22:57                                       ` Jason Gunthorpe
2020-09-14 23:25                                         ` Benjamin Herrenschmidt [this message]
2020-09-15 10:18                                           ` Lorenzo Pieralisi
2020-09-15 11:05                                             ` Jason Gunthorpe
2020-09-15 23:17                                               ` Benjamin Herrenschmidt
2020-09-15 23:40                                                 ` Jason Gunthorpe
2020-09-16  7:59                                                   ` Benjamin Herrenschmidt
2020-09-16 12:12                                                     ` Jason Gunthorpe
2020-09-16 14:09                                                       ` Lorenzo Pieralisi
2020-09-16 14:14                                                         ` Jason Gunthorpe
2020-09-16 23:59                                                       ` Benjamin Herrenschmidt
2020-09-17 10:28                                                         ` Lorenzo Pieralisi
2020-09-17 11:32                                                           ` Jason Gunthorpe
2020-09-17 14:01                                                             ` Lorenzo Pieralisi
2020-09-17 16:08                                                               ` Will Deacon
2020-09-16 12:48                                                     ` Leon Romanovsky
2020-09-16  8:33                                                   ` Will Deacon
2020-09-16  8:48                                                     ` Catalin Marinas
2020-09-16 14:15                                                       ` Lorenzo Pieralisi
2020-09-16 17:00                                                         ` Catalin Marinas
2020-09-16 21:29                                                           ` Benjamin Herrenschmidt
2020-09-16 12:08                                                     ` Jason Gunthorpe
2020-09-15 23:00                                             ` Benjamin Herrenschmidt
2020-09-15 23:12                                               ` Clint Sbisa
2020-09-14 21:41                               ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b539df4c9ec703458e46da2fc879ee3b310b31c.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=csbisa@amazon.com \
    --cc=helgaas@kernel.org \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).