From: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
To: Alan Douglas <adouglas@cadence.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"kishon@ti.com" <kishon@ti.com>,
"jesper.nilsson@axis.com" <jesper.nilsson@axis.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/10] misc: pci_endpoint_test: Add MSI-X support
Date: Mon, 30 Apr 2018 17:30:20 +0100 [thread overview]
Message-ID: <3485fade-56fd-0078-a330-41187445c984@synopsys.com> (raw)
In-Reply-To: <SN6PR07MB45124A237879C78453495C50D8820@SN6PR07MB4512.namprd07.prod.outlook.com>
Hi Alan,
On 30/04/2018 16:35, Alan Douglas wrote:
> Hi Gustavo,
>
> On April 27, 2018, 4:57 p.m. Gustavo Pimentel wrote:
>> Add MSI-X support and update driver documentation accordingly.
>>
>> Add new driver parameter to allow interruption type selection.
>>
>> Modify the Legacy/MSI/MSI-X test process, by:
>> - Add and use a specific register located in a BAR, which defines the interrupt
>> type is been triggered.
>> - Move the interrupt ID number from the command section to a register
>> located in a BAR.
>>
>> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
>> ---
>> Documentation/misc-devices/pci-endpoint-test.txt | 3 +
>> drivers/misc/pci_endpoint_test.c | 121 +++++++++++++++--------
>> drivers/pci/endpoint/functions/pci-epf-test.c | 78 +++++++++++----
>> 3 files changed, 143 insertions(+), 59 deletions(-)
>>
> In testing these changes I found that pci_epc_raise_irq() also needs to be
> updated in pci-epc-core.c, since it has interrupt_num parameter as u8
Yes, indeed. I updated it together with the pci-epc.h file.
Thanks Alan, well spotted!
Regards,
Gustavo
>
> Thanks,
> Alan
>
next prev parent reply other threads:[~2018-04-30 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 16:57 [PATCH 00/10] Add MSI-X support on pcitest tool Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 01/10] PCI: endpoint: Add MSI-X interfaces Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 02/10] PCI: dwc: Add MSI-X callbacks handler Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 03/10] PCI: cadence: Update cdns_pcie_ep_raise_irq function signature Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 04/10] PCI: dwc: Rework MSI callbacks handler Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 05/10] PCI: dwc: Add legacy interrupt callback handler Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 06/10] misc: pci_endpoint_test: Add MSI-X support Gustavo Pimentel
2018-04-30 15:35 ` Alan Douglas
2018-04-30 16:30 ` Gustavo Pimentel [this message]
2018-04-27 16:57 ` [PATCH 07/10] misc: pci_endpoint_test: Replace lower into upper case characters Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 08/10] PCI: endpoint: functions/pci-epf-test: " Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 09/10] tools: PCI: Add MSI-X support Gustavo Pimentel
2018-04-27 16:57 ` [PATCH 10/10] misc: pci_endpoint_test: Use pci_irq_vector function Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3485fade-56fd-0078-a330-41187445c984@synopsys.com \
--to=gustavo.pimentel@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=adouglas@cadence.com \
--cc=bhelgaas@google.com \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).