From: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Lucas Stach <l.stach@pengutronix.de>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Tim Harvey <tharvey@gateworks.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"patchwork-lst@pengutronix.de" <patchwork-lst@pengutronix.de>
Subject: Re: [PATCH] PCI: dwc: skip MSI init if MSIs have been explicitly disabled
Date: Fri, 1 Mar 2019 10:10:18 +0000 [thread overview]
Message-ID: <3c088f9c-8def-4ef1-e810-d68a63348b30@synopsys.com> (raw)
In-Reply-To: <20190228132936.GA17873@e107981-ln.cambridge.arm.com>
On 28/02/2019 13:29, Lorenzo Pieralisi wrote:
> On Wed, Feb 27, 2019 at 05:52:19PM +0100, Lucas Stach wrote:
>> Since 7c5925afbc58 (PCI: dwc: Move MSI IRQs allocation to IRQ domains
>> hierarchical API) the MSI init claims one of the controller IRQs as a
>> chained IRQ line for the MSI controller. On some designs, like the i.MX6,
>> this line is shared with a PCIe legacy IRQ. When the line is claimed for
>> the MSI domain, any device trying to use this legacy IRQs will fail to
>> request this IRQ line.
>>
>> As MSI and legacy IRQs are already mutually exclusive on the DWC core,
>> as the core won't forward any legacy IRQs once any MSI has been enabled,
>> users wishing to use legacy IRQs already need to explictly disable MSI
>> support (usually via the pci=nomsi kernel commandline option). To avoid
>> any issues with MSI conflicting with legacy IRQs, just skip all of the
>> DWC MSI initalization, including the IRQ line claim, when MSI is disabled.
>>
>> Fixes: c5925afbc58
>> (PCI: dwc: Move MSI IRQs allocation to IRQ domains hierarchical API)
>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>> Tested-by: Tim Harvey <tharvey@gateworks.com>
>> ---
>> drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I request Gustavo's ACK to proceed, thanks.
>
> Lorenzo
>
>> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
>> index 29a05759a294..f4a8494f616b 100644
>> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
>> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
>> @@ -433,7 +433,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
>> if (ret)
>> pci->num_viewport = 2;
>>
>> - if (IS_ENABLED(CONFIG_PCI_MSI)) {
>> + if (IS_ENABLED(CONFIG_PCI_MSI) && pci_msi_enabled()) {
>> /*
>> * If a specific SoC driver needs to change the
>> * default number of vectors, it needs to implement
>> --
>> 2.20.1
>>
Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
next prev parent reply other threads:[~2019-03-01 10:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 16:52 [PATCH] PCI: dwc: skip MSI init if MSIs have been explicitly disabled Lucas Stach
2019-02-27 17:25 ` Fabio Estevam
2019-02-27 17:43 ` Tim Harvey
2019-02-28 13:29 ` Lorenzo Pieralisi
2019-03-01 10:10 ` Gustavo Pimentel [this message]
2019-03-01 12:29 ` Lorenzo Pieralisi
2019-03-04 19:25 ` Bjorn Helgaas
2019-03-04 19:39 ` Lucas Stach
2019-03-04 20:18 ` Marc Zyngier
2019-03-06 9:53 ` Gustavo Pimentel
2019-03-06 11:39 ` Lucas Stach
2019-03-06 15:59 ` Tim Harvey
2019-04-15 14:34 ` Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c088f9c-8def-4ef1-e810-d68a63348b30@synopsys.com \
--to=gustavo.pimentel@synopsys.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=patchwork-lst@pengutronix.de \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).