From: Tim Harvey <tharvey@gateworks.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
patchwork-lst@pengutronix.de, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] PCI: dwc: skip MSI init if MSIs have been explicitly disabled
Date: Wed, 27 Feb 2019 09:43:03 -0800 [thread overview]
Message-ID: <CAJ+vNU3HxaVWmkG634rcTzRaxGZBzqNVTPKNp+jx8d5iMATUSQ@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5B5AyHPkvB9RqP6D43NW2gxUTiF=70=B2y+MXWMLzpH_g@mail.gmail.com>
On Wed, Feb 27, 2019 at 9:25 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Lucas,
>
> On Wed, Feb 27, 2019 at 1:53 PM Lucas Stach <l.stach@pengutronix.de> wrote:
> >
> > Since 7c5925afbc58 (PCI: dwc: Move MSI IRQs allocation to IRQ domains
> > hierarchical API) the MSI init claims one of the controller IRQs as a
> > chained IRQ line for the MSI controller. On some designs, like the i.MX6,
> > this line is shared with a PCIe legacy IRQ. When the line is claimed for
> > the MSI domain, any device trying to use this legacy IRQs will fail to
> > request this IRQ line.
> >
> > As MSI and legacy IRQs are already mutually exclusive on the DWC core,
> > as the core won't forward any legacy IRQs once any MSI has been enabled,
> > users wishing to use legacy IRQs already need to explictly disable MSI
> > support (usually via the pci=nomsi kernel commandline option). To avoid
> > any issues with MSI conflicting with legacy IRQs, just skip all of the
> > DWC MSI initalization, including the IRQ line claim, when MSI is disabled.
>
> Thanks for the patch.
>
> > Fixes: c5925afbc58
> > (PCI: dwc: Move MSI IRQs allocation to IRQ domains hierarchical API)
>
> Nit: the commit ID is missing the digit 7 as the first number.
>
> While at it, the Fixes lines should written as a single line
>
> Fixes: 7c5925afbc58 ("PCI: dwc: Move MSI IRQs allocation to IRQ
> domains hierarchical API")
>
> The " " symbols for the commit Subject is also missing in the commit log.
Lucas,
Also I think its worth having this in linux-stable for 4.20 and 4.19
(was introduced in 4.17)
Thanks,
Tim
next prev parent reply other threads:[~2019-02-27 17:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 16:52 [PATCH] PCI: dwc: skip MSI init if MSIs have been explicitly disabled Lucas Stach
2019-02-27 17:25 ` Fabio Estevam
2019-02-27 17:43 ` Tim Harvey [this message]
2019-02-28 13:29 ` Lorenzo Pieralisi
2019-03-01 10:10 ` Gustavo Pimentel
2019-03-01 12:29 ` Lorenzo Pieralisi
2019-03-04 19:25 ` Bjorn Helgaas
2019-03-04 19:39 ` Lucas Stach
2019-03-04 20:18 ` Marc Zyngier
2019-03-06 9:53 ` Gustavo Pimentel
2019-03-06 11:39 ` Lucas Stach
2019-03-06 15:59 ` Tim Harvey
2019-04-15 14:34 ` Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+vNU3HxaVWmkG634rcTzRaxGZBzqNVTPKNp+jx8d5iMATUSQ@mail.gmail.com \
--to=tharvey@gateworks.com \
--cc=bhelgaas@google.com \
--cc=festevam@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).