* [PATCH][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword
@ 2020-07-16 21:15 Gustavo A. R. Silva
2020-07-17 7:18 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-16 21:15 UTC (permalink / raw)
To: Marek Vasut, Yoshihiro Shimoda, Lorenzo Pieralisi, Rob Herring,
Bjorn Helgaas
Cc: linux-pci, linux-renesas-soc, linux-kernel, Gustavo A. R. Silva
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/pci/controller/pci-rcar-gen2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
index 326171cb1a97..2ec7093a7588 100644
--- a/drivers/pci/controller/pci-rcar-gen2.c
+++ b/drivers/pci/controller/pci-rcar-gen2.c
@@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
pr_warn("unknown window size %ld - defaulting to 256M\n",
priv->window_size);
priv->window_size = SZ_256M;
- /* fall-through */
+ fallthrough;
case SZ_256M:
val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword
2020-07-16 21:15 [PATCH][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword Gustavo A. R. Silva
@ 2020-07-17 7:18 ` Geert Uytterhoeven
2020-07-22 3:25 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-07-17 7:18 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Marek Vasut, Yoshihiro Shimoda, Lorenzo Pieralisi, Rob Herring,
Bjorn Helgaas, linux-pci, Linux-Renesas,
Linux Kernel Mailing List, Gustavo A. R. Silva
Hi Gustavo,
Thanks for your patch!
On Thu, Jul 16, 2020 at 11:11 PM Gustavo A. R. Silva
<gustavoars@kernel.org> wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
Which unnecessary marking is being removed?
I don't see any.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
For the actual patch contents:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword
2020-07-17 7:18 ` Geert Uytterhoeven
@ 2020-07-22 3:25 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-22 3:25 UTC (permalink / raw)
To: Geert Uytterhoeven, Gustavo A. R. Silva
Cc: Marek Vasut, Yoshihiro Shimoda, Lorenzo Pieralisi, Rob Herring,
Bjorn Helgaas, linux-pci, Linux-Renesas,
Linux Kernel Mailing List
Hi Geert,
On 7/17/20 02:18, Geert Uytterhoeven wrote:
> Hi Gustavo,
>
> Thanks for your patch!
>
> On Thu, Jul 16, 2020 at 11:11 PM Gustavo A. R. Silva
> <gustavoars@kernel.org> wrote:
>> Replace the existing /* fall through */ comments and its variants with
>> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
>> fall-through markings when it is the case.
>
> Which unnecessary marking is being removed?
> I don't see any.
>
There is none. I will remove those lines and send v2 with a URL
to the proper documentation for Linux v5.7 instead of 'lastest',
see:
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
I'll add your Reviewed-by tag. :)
>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> For the actual patch contents:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
Thanks!
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-22 3:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 21:15 [PATCH][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-07-17 7:18 ` Geert Uytterhoeven
2020-07-22 3:25 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).