* [PATCH] pci: fix iov.c kernel-doc warnings
@ 2013-01-10 1:12 Randy Dunlap
2013-01-10 22:19 ` Don Dutile
2013-01-11 18:15 ` Bjorn Helgaas
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2013-01-10 1:12 UTC (permalink / raw)
To: linux-pci, Bjorn Helgaas; +Cc: Linus Torvalds
From: Randy Dunlap <rdunlap@infradead.org>
Fix kernel-doc warning in iov.c:
Warning(drivers/pci/iov.c:752): No description found for parameter 'numvfs'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/pci/iov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-38-rc2.orig/drivers/pci/iov.c
+++ lnx-38-rc2/drivers/pci/iov.c
@@ -739,7 +739,7 @@ EXPORT_SYMBOL_GPL(pci_num_vf);
/**
* pci_sriov_set_totalvfs -- reduce the TotalVFs available
* @dev: the PCI PF device
- * numvfs: number that should be used for TotalVFs supported
+ * @numvfs: number that should be used for TotalVFs supported
*
* Should be called from PF driver's probe routine with
* device's mutex held.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pci: fix iov.c kernel-doc warnings
2013-01-10 1:12 [PATCH] pci: fix iov.c kernel-doc warnings Randy Dunlap
@ 2013-01-10 22:19 ` Don Dutile
2013-01-11 0:53 ` Randy Dunlap
2013-01-11 18:15 ` Bjorn Helgaas
1 sibling, 1 reply; 4+ messages in thread
From: Don Dutile @ 2013-01-10 22:19 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-pci, Bjorn Helgaas, Linus Torvalds
On 01/09/2013 08:12 PM, Randy Dunlap wrote:
> From: Randy Dunlap<rdunlap@infradead.org>
>
> Fix kernel-doc warning in iov.c:
>
> Warning(drivers/pci/iov.c:752): No description found for parameter 'numvfs'
>
> Signed-off-by: Randy Dunlap<rdunlap@infradead.org>
> ---
> drivers/pci/iov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-38-rc2.orig/drivers/pci/iov.c
> +++ lnx-38-rc2/drivers/pci/iov.c
> @@ -739,7 +739,7 @@ EXPORT_SYMBOL_GPL(pci_num_vf);
> /**
> * pci_sriov_set_totalvfs -- reduce the TotalVFs available
> * @dev: the PCI PF device
> - * numvfs: number that should be used for TotalVFs supported
> + * @numvfs: number that should be used for TotalVFs supported
> *
> * Should be called from PF driver's probe routine with
> * device's mutex held.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks for cleanup; /my bad.
Should checkpatch report this issue? if it does, then
my (double-down) bad for missing that correction when I ran it against the patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pci: fix iov.c kernel-doc warnings
2013-01-10 22:19 ` Don Dutile
@ 2013-01-11 0:53 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2013-01-11 0:53 UTC (permalink / raw)
To: Don Dutile; +Cc: linux-pci, Bjorn Helgaas, Linus Torvalds
On 01/10/13 14:19, Don Dutile wrote:
> On 01/09/2013 08:12 PM, Randy Dunlap wrote:
>> From: Randy Dunlap<rdunlap@infradead.org>
>>
>> Fix kernel-doc warning in iov.c:
>>
>> Warning(drivers/pci/iov.c:752): No description found for parameter 'numvfs'
>>
>> Signed-off-by: Randy Dunlap<rdunlap@infradead.org>
>> ---
>> drivers/pci/iov.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lnx-38-rc2.orig/drivers/pci/iov.c
>> +++ lnx-38-rc2/drivers/pci/iov.c
>> @@ -739,7 +739,7 @@ EXPORT_SYMBOL_GPL(pci_num_vf);
>> /**
>> * pci_sriov_set_totalvfs -- reduce the TotalVFs available
>> * @dev: the PCI PF device
>> - * numvfs: number that should be used for TotalVFs supported
>> + * @numvfs: number that should be used for TotalVFs supported
>> *
>> * Should be called from PF driver's probe routine with
>> * device's mutex held.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Thanks for cleanup; /my bad.
> Should checkpatch report this issue? if it does, then
> my (double-down) bad for missing that correction when I ran it against the patch.
checkpatch doesn't check for missing kernel-doc notation.
I run 'make htmldocs' on each kernel to look for kernel-doc errors
and warnings.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pci: fix iov.c kernel-doc warnings
2013-01-10 1:12 [PATCH] pci: fix iov.c kernel-doc warnings Randy Dunlap
2013-01-10 22:19 ` Don Dutile
@ 2013-01-11 18:15 ` Bjorn Helgaas
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2013-01-11 18:15 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-pci, Linus Torvalds
On Wed, Jan 9, 2013 at 6:12 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning in iov.c:
>
> Warning(drivers/pci/iov.c:752): No description found for parameter 'numvfs'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks, Randy. I applied this to my for-linus branch and it will
appear in v3.8 along with the code it applies to.
Bjorn
> ---
> drivers/pci/iov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-38-rc2.orig/drivers/pci/iov.c
> +++ lnx-38-rc2/drivers/pci/iov.c
> @@ -739,7 +739,7 @@ EXPORT_SYMBOL_GPL(pci_num_vf);
> /**
> * pci_sriov_set_totalvfs -- reduce the TotalVFs available
> * @dev: the PCI PF device
> - * numvfs: number that should be used for TotalVFs supported
> + * @numvfs: number that should be used for TotalVFs supported
> *
> * Should be called from PF driver's probe routine with
> * device's mutex held.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-11 18:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-10 1:12 [PATCH] pci: fix iov.c kernel-doc warnings Randy Dunlap
2013-01-10 22:19 ` Don Dutile
2013-01-11 0:53 ` Randy Dunlap
2013-01-11 18:15 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).