From: Murali Karicheri <m-karicheri2@ti.com>
To: Richard Zhu <richard.zhu@freescale.com>
Cc: <linux-pci@vger.kernel.org>, <shawn.guo@freescale.com>,
<festevam@gmail.com>, <l.stach@pengutronix.de>,
<tharvey@gateworks.com>, Richard Zhu <r65037@freescale.com>
Subject: Re: [PATCH v8 5/9] PCI: imx6: Add imx6sx pcie support
Date: Mon, 27 Oct 2014 14:24:27 -0400 [thread overview]
Message-ID: <544E8DDB.9000008@ti.com> (raw)
In-Reply-To: <1413782724-30795-6-git-send-email-richard.zhu@freescale.com>
> dw_pcie_wr_own_conf(pp, PCI_BASE_ADDRESS_0, 4, 0);
>
> diff --git a/drivers/pci/host/pcie-designware.h b/drivers/pci/host/pcie-designware.h
> index 1a59600..6061355 100644
> --- a/drivers/pci/host/pcie-designware.h
> +++ b/drivers/pci/host/pcie-designware.h
> @@ -75,7 +75,7 @@ struct pcie_host_ops {
> int (*wr_other_conf)(struct pcie_port *pp, struct pci_bus *bus,
> unsigned int devfn, int where, int size, u32 val);
> int (*link_up)(struct pcie_port *pp);
> - void (*host_init)(struct pcie_port *pp);
> + int (*host_init)(struct pcie_port *pp);
Richard,
Please update the drivers/pci/host/pci-keystine.c as well for
host_init() as pci-keystone is already merged to v3.18rc1. Please update
the driver if you are changing API for pcie-designware core.
Murali
> void (*msi_set_irq)(struct pcie_port *pp, int irq);
> void (*msi_clear_irq)(struct pcie_port *pp, int irq);
> u32 (*get_msi_data)(struct pcie_port *pp);
> diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c
> index 6dea9e4..b8fd76b 100644
> --- a/drivers/pci/host/pcie-spear13xx.c
> +++ b/drivers/pci/host/pcie-spear13xx.c
> @@ -258,10 +258,12 @@ static int spear13xx_pcie_link_up(struct pcie_port *pp)
> return 0;
> }
>
> -static void spear13xx_pcie_host_init(struct pcie_port *pp)
> +static int spear13xx_pcie_host_init(struct pcie_port *pp)
> {
> spear13xx_pcie_establish_link(pp);
> spear13xx_pcie_enable_interrupts(pp);
> +
> + return 0;
> }
>
> static struct pcie_host_ops spear13xx_pcie_host_ops = {
-
Murali Karicheri
Linux Kernel, Texas Instruments
next prev parent reply other threads:[~2014-10-27 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 5:25 [PATCH v8]PCI: imx6: enable pcie on imx6sx sdb and imx6qdl sabreauto Richard Zhu
2014-10-20 5:25 ` [PATCH v8 1/9] PCI: designware: Refine setup_rc and add msi data restore Richard Zhu
2014-10-20 5:25 ` [PATCH v8 2/9] PCI: designware: Fix one potential assignment error of cfg start Richard Zhu
2014-10-21 10:27 ` Lucas Stach
2014-10-20 5:25 ` [PATCH v8 3/9] ARM: imx6sx: Add imx6sx pcie related gpr bits definitions Richard Zhu
2014-10-20 5:25 ` [PATCH v8 4/9] PCI: imx6: Wait the clocks to stabilize after ref_en Richard Zhu
2014-10-20 5:25 ` [PATCH v8 5/9] PCI: imx6: Add imx6sx pcie support Richard Zhu
2014-10-27 18:24 ` Murali Karicheri [this message]
2014-10-31 2:43 ` Richard.Zhu
2014-10-20 5:25 ` [PATCH v8 6/9] ARM: imx6qdl: Enable pcie on imx6qdl sabreauto Richard Zhu
2014-10-20 5:25 ` [PATCH v8 7/9] ARM: imx6: Update dts and binding for imx6sx pcie Richard Zhu
2014-10-20 5:25 ` [PATCH v8 8/9] ARM: imx6sx: Add syscon into gpc dts Richard Zhu
2014-10-20 5:25 ` [PATCH v8 9/9] ARM: imx6sx: Enable pcie on imx6sx sdb board Richard Zhu
2014-10-21 8:18 ` [PATCH v8]PCI: imx6: enable pcie on imx6sx sdb and imx6qdl sabreauto Lucas Stach
2014-10-21 9:54 ` Hong-Xing.Zhu
2014-10-21 15:37 ` Bjorn Helgaas
2014-10-22 2:34 ` Hong-Xing.Zhu
2014-10-22 2:48 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E8DDB.9000008@ti.com \
--to=m-karicheri2@ti.com \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=richard.zhu@freescale.com \
--cc=shawn.guo@freescale.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).