linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: nitirawa@codeaurora.org
To: Lukas Wunner <lukas@wunner.de>, Keith Busch <kbusch@kernel.org>
Cc: Vidya Sagar <vidyas@nvidia.com>, Keith Busch <kbusch@kernel.org>,
	robh+dt@kernel.org, rafael.j.wysocki@intel.com, hch@lst.de,
	bhelgaas@google.com, mmaddireddy@nvidia.com, kthota@nvidia.com,
	sagar.tv@gmail.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Query related to shutting down NVMe during system suspend
Date: Thu, 10 Feb 2022 18:06:59 +0530	[thread overview]
Message-ID: <65a50f83e87d4cf8b1ac1b740b4fa35b@codeaurora.org> (raw)
In-Reply-To: <20220210054019.GA929@wunner.de>

On 2022-02-10 11:10, Lukas Wunner wrote:
> On Thu, Feb 10, 2022 at 09:41:04AM +0530, Vidya Sagar wrote:
>> On 2/10/2022 1:56 AM, Keith Busch wrote:
>> > Christoph prefers to append quirks for platforms that need full device
>> > shutdown on s2idle instead of changing the driver default.
>> >
>> > We use dmi matching for our current platform quirk list. I do not know
>> > what the equivalent is for device-tree based platforms. Do you know?
>> 
>> I'm afraid I don't.
> 
> of_machine_is_compatible()

Thanks Lukas and keith . Yes it worked using of_machine_is_compatible as 
it checks root node of device tree for a given compatible value.
@keith - I have posted the change using above API to enable nvme quick 
suspend quirks for sc7280 platform. Please can you review it.

      reply	other threads:[~2022-02-10 12:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 16:22 Query related to shutting down NVMe during system suspend Vidya Sagar
2022-02-01 16:30 ` Keith Busch
2022-02-01 16:58   ` Vidya Sagar
2022-02-07 10:57     ` nitirawa
2022-02-07 12:11       ` Vidya Sagar
2022-02-07 15:44         ` nitirawa
2022-02-07 15:47           ` Keith Busch
2022-02-01 17:17   ` Rafael J. Wysocki
2022-02-09 20:26 ` Keith Busch
2022-02-09 21:17   ` nitirawa
2022-02-09 21:47     ` Keith Busch
2022-02-10  4:11   ` Vidya Sagar
2022-02-10  5:40     ` Lukas Wunner
2022-02-10 12:36       ` nitirawa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65a50f83e87d4cf8b1ac1b740b4fa35b@codeaurora.org \
    --to=nitirawa@codeaurora.org \
    --cc=bhelgaas@google.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kthota@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mmaddireddy@nvidia.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=robh+dt@kernel.org \
    --cc=sagar.tv@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).