From: nitirawa@codeaurora.org
To: Keith Busch <kbusch@kernel.org>
Cc: Vidya Sagar <vidyas@nvidia.com>,
rafael.j.wysocki@intel.com, keith.busch@intel.com, hch@lst.de,
bhelgaas@google.com, mmaddireddy@nvidia.com, kthota@nvidia.com,
sagar.tv@gmail.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Query related to shutting down NVMe during system suspend
Date: Thu, 10 Feb 2022 02:47:47 +0530 [thread overview]
Message-ID: <bc80ec7d1ca2c56feded1a6848c285ef@codeaurora.org> (raw)
In-Reply-To: <20220209202639.GB1616420@dhcp-10-100-145-180.wdc.com>
On 2022-02-10 01:56, Keith Busch wrote:
> On Tue, Feb 01, 2022 at 09:52:28PM +0530, Vidya Sagar wrote:
>> Hi Rafael & Christoph,
>> My query is regarding the comment and the code that follows after it
>> at
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nvme/host/pci.c?h=v5.17-rc2#n3243
>> What I understood from it is that, there is an underlying assumption
>> that the power to the devices is not removed during the suspend call.
>> In the case of device-tree based platforms like Tegra194, power is
>> indeed removed to the devices during suspend-resume process. Hence,
>> the
>> NVMe devices need to be taken through the shutdown path irrespective
>> of
>> whether the ASPM states are enabled or not.
>> I would like to hear from you the best method to follow to achieve
>> this.
>
> Christoph prefers to append quirks for platforms that need full device
> shutdown on s2idle instead of changing the driver default.
>
> We use dmi matching for our current platform quirk list. I do not know
> what the equivalent is for device-tree based platforms. Do you know?
Hi Keith,
IMO, the NVME driver is not associated with any device tree, Instead PCI
driver is associated with device tree.
So unlike ACPI based platform where we have platform specific DMI
matching, we don't have equivalent check for DT based platform.
Do we see any concern if we introduce a module param with default not
set to quick suspend.
For platform that need full shutdown durring resume , they can set it to
quick suspend.
next prev parent reply other threads:[~2022-02-09 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 16:22 Query related to shutting down NVMe during system suspend Vidya Sagar
2022-02-01 16:30 ` Keith Busch
2022-02-01 16:58 ` Vidya Sagar
2022-02-07 10:57 ` nitirawa
2022-02-07 12:11 ` Vidya Sagar
2022-02-07 15:44 ` nitirawa
2022-02-07 15:47 ` Keith Busch
2022-02-01 17:17 ` Rafael J. Wysocki
2022-02-09 20:26 ` Keith Busch
2022-02-09 21:17 ` nitirawa [this message]
2022-02-09 21:47 ` Keith Busch
2022-02-10 4:11 ` Vidya Sagar
2022-02-10 5:40 ` Lukas Wunner
2022-02-10 12:36 ` nitirawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc80ec7d1ca2c56feded1a6848c285ef@codeaurora.org \
--to=nitirawa@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=keith.busch@intel.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sagar.tv@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).