From: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To: Keith Busch <keith.busch@intel.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"okaya@kernel.org" <okaya@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zheng, Joey" <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH v2 2/2] PCI: pciehp: Add HXT quirk for Command Completed errata
Date: Tue, 20 Nov 2018 10:19:39 +0000 [thread overview]
Message-ID: <66917a57b8ca46bcbabb40934d6b374f@HXTBJIDCEMVIW01.hxtcorp.net> (raw)
In-Reply-To: 20181119161642.GA26595@localhost.localdomain
Hi, Keith,
Following is the discussion adding the first quirk in this file,
https://lore.kernel.org/lkml/8770820b-85a0-172b-7230-3a44524e6c9f@molgen.mpg.de/T/#u
From the discussion, I guess putting the code here is to make it just
the quirk for pcie hotplug.
Thanks.
Shunyong.
On 2018/11/20 0:19, Keith Busch wrote:
> On Wed, Nov 07, 2018 at 03:25:05PM +0800, Shunyong Yang wrote:
>> The HXT SD4800 PCI controller does not set the Command Completed
>> bit unless writes to the Slot Command register change "Control"
>> bits.
>>
>> This patch adds SD4800 to the quirk.
>>
>> Cc: Joey Zheng <yu.zheng@hxt-semitech.com>
>> Signed-off-by: Shunyong Yang <shunyong.yang@hxt-semitech.com>
>>
>> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
>> index 7dd443aea5a5..91db67963aea 100644
>> --- a/drivers/pci/hotplug/pciehp_hpc.c
>> +++ b/drivers/pci/hotplug/pciehp_hpc.c
>> @@ -920,3 +920,5 @@ static void quirk_cmd_compl(struct pci_dev *pdev)
>> PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl);
>> DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0401,
>> PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl);
>> +DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_HXT, 0x0401,
>> + PCI_CLASS_BRIDGE_PCI, 8, quirk_cmd_compl);
>
> I guess you're just appending to where this quirk is already defined,
> but why are the quirks even in the core driver instead of pci/quirks.c?
>
prev parent reply other threads:[~2018-11-20 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 3:15 [PATCH] PCI: Add HXT vendor ID and ACS quirk Shunyong Yang
2018-11-05 23:12 ` Sinan Kaya
2018-11-06 1:34 ` Yang, Shunyong
2018-11-07 7:24 ` [PATCH v2 1/2] " Shunyong Yang
2019-02-01 23:19 ` Bjorn Helgaas
2019-02-11 0:52 ` Yang, Shunyong
2022-02-10 22:53 ` Bjorn Helgaas
2018-11-07 7:25 ` [PATCH v2 2/2] PCI: pciehp: Add HXT quirk for Command Completed errata Shunyong Yang
2018-11-19 1:07 ` Yang, Shunyong
2018-12-07 2:31 ` Yang, Shunyong
2018-11-19 16:16 ` Keith Busch
2018-11-20 10:19 ` Yang, Shunyong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66917a57b8ca46bcbabb40934d6b374f@HXTBJIDCEMVIW01.hxtcorp.net \
--to=shunyong.yang@hxt-semitech.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).