From: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "okaya@kernel.org" <okaya@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zheng, Joey" <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH v2 1/2] PCI: Add HXT vendor ID and ACS quirk
Date: Mon, 11 Feb 2019 00:52:29 +0000 [thread overview]
Message-ID: <6b4a41788f0d4b1c8388ebfb4d5abea4@HXTBJIDCEMVIW01.hxtcorp.net> (raw)
In-Reply-To: 20190201231947.GV229773@google.com
Hi, Bjorn,
Thank you for reminding me. I will check with our IC team for these
design issues.
Sorry for the delay as I was taking Chinese New Year holiday.
Shunyong.
On 2019/2/2 7:19, Bjorn Helgaas wrote:
> On Wed, Nov 07, 2018 at 03:24:12PM +0800, Shunyong Yang wrote:
>> Add the HXT vendor ID to pci_ids.h and use it in quirks. As the
>> design of HXT SD4800 ACS feature is the same as QCOM QDF2xxx,
>> pci_quirk_qcom_rp_acs() is reused for SD4800 quirk.
>>
>> cc: Joey Zheng <yu.zheng@hxt-semitech.com>
>> Reviewed-by: Sinan Kaya <okaya@kernel.org>
>> Signed-off-by: Shunyong Yang <shunyong.yang@hxt-semitech.com>
>
> I applied both of these to pci/misc for v5.1, thanks!
>
> As I'm sure you know, both the ACS and the pciehp issues are cases where
> the part does not conform to the PCIe spec. Hopefully future parts will
> change the design so they *do* conform to the spec so we don't have to add
> quirks for every new part. Adding quirks works around the problem, but
> it's a hassle for customers (and developers and distributors) because they
> need kernel updates when they wouldn't otherwise.
>
> Bjorn
>
>> ---
>> v2:
>> Add Reviewed-by: Sinan Kaya.
>>
>> v1:
>> Initial version.
>> ---
>>
>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
>> index 4700d24e5d55..1e00ef6a88f4 100644
>> --- a/drivers/pci/quirks.c
>> +++ b/drivers/pci/quirks.c
>> @@ -4495,6 +4495,8 @@ static int pci_quirk_mf_endpoint_acs(struct pci_dev *dev, u16 acs_flags)
>> /* QCOM QDF2xxx root ports */
>> { PCI_VENDOR_ID_QCOM, 0x0400, pci_quirk_qcom_rp_acs },
>> { PCI_VENDOR_ID_QCOM, 0x0401, pci_quirk_qcom_rp_acs },
>> + /* HXT SD4800 root ports. The ACS design is same as QCOM QDF2xxx */
>> + { PCI_VENDOR_ID_HXT, 0x0401, pci_quirk_qcom_rp_acs },
>> /* Intel PCH root ports */
>> { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pci_quirk_intel_pch_acs },
>> { PCI_VENDOR_ID_INTEL, PCI_ANY_ID, pci_quirk_intel_spt_pch_acs },
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 69f0abe1ba1a..e60a6bc38298 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2565,6 +2565,8 @@
>>
>> #define PCI_VENDOR_ID_HYGON 0x1d94
>>
>> +#define PCI_VENDOR_ID_HXT 0x1dbf
>> +
>> #define PCI_VENDOR_ID_TEKRAM 0x1de1
>> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29
>>
>> --
>> 1.8.3.1
>>
>
next prev parent reply other threads:[~2019-02-11 0:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 3:15 [PATCH] PCI: Add HXT vendor ID and ACS quirk Shunyong Yang
2018-11-05 23:12 ` Sinan Kaya
2018-11-06 1:34 ` Yang, Shunyong
2018-11-07 7:24 ` [PATCH v2 1/2] " Shunyong Yang
2019-02-01 23:19 ` Bjorn Helgaas
2019-02-11 0:52 ` Yang, Shunyong [this message]
2022-02-10 22:53 ` Bjorn Helgaas
2018-11-07 7:25 ` [PATCH v2 2/2] PCI: pciehp: Add HXT quirk for Command Completed errata Shunyong Yang
2018-11-19 1:07 ` Yang, Shunyong
2018-12-07 2:31 ` Yang, Shunyong
2018-11-19 16:16 ` Keith Busch
2018-11-20 10:19 ` Yang, Shunyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b4a41788f0d4b1c8388ebfb4d5abea4@HXTBJIDCEMVIW01.hxtcorp.net \
--to=shunyong.yang@hxt-semitech.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).