From: Heiner Kallweit <hkallweit1@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: [PATCH] PCI: Change CLS info in pci_apply_final_quirks to debug level
Date: Wed, 9 Dec 2020 15:00:51 +0100 [thread overview]
Message-ID: <785a8518-cdcb-a3e1-add6-6c8964b46bf7@gmail.com> (raw)
CLS is relevant only for devices using MWI, in addition
not really helpful messages like the following are printed:
PCI: CLS 0 bytes, default 64
Therefore change CLS info to debug level.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/pci/quirks.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index d9cbe69b8..af8d8ddfe 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -157,9 +157,6 @@ static int __init pci_apply_final_quirks(void)
u8 cls = 0;
u8 tmp;
- if (pci_cache_line_size)
- pr_info("PCI: CLS %u bytes\n", pci_cache_line_size << 2);
-
pci_apply_fixup_final_quirks = true;
for_each_pci_dev(dev) {
pci_fixup_device(pci_fixup_final, dev);
@@ -182,11 +179,11 @@ static int __init pci_apply_final_quirks(void)
}
}
- if (!pci_cache_line_size) {
- pr_info("PCI: CLS %u bytes, default %u\n", cls << 2,
- pci_dfl_cache_line_size << 2);
- pci_cache_line_size = cls ? cls : pci_dfl_cache_line_size;
- }
+ if (!pci_cache_line_size)
+ pci_cache_line_size = cls ?: pci_dfl_cache_line_size;
+
+ pr_debug("PCI: CLS %u bytes, default %u\n", pci_cache_line_size << 2,
+ pci_dfl_cache_line_size << 2);
return 0;
}
--
2.29.2
reply other threads:[~2020-12-09 14:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=785a8518-cdcb-a3e1-add6-6c8964b46bf7@gmail.com \
--to=hkallweit1@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).