linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: Change CLS info in pci_apply_final_quirks to debug level
@ 2020-12-09 14:00 Heiner Kallweit
  0 siblings, 0 replies; only message in thread
From: Heiner Kallweit @ 2020-12-09 14:00 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: linux-pci

CLS is relevant only for devices using MWI, in addition
not really helpful messages like the following are printed:
PCI: CLS 0 bytes, default 64
Therefore change CLS info to debug level.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/pci/quirks.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index d9cbe69b8..af8d8ddfe 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -157,9 +157,6 @@ static int __init pci_apply_final_quirks(void)
 	u8 cls = 0;
 	u8 tmp;
 
-	if (pci_cache_line_size)
-		pr_info("PCI: CLS %u bytes\n", pci_cache_line_size << 2);
-
 	pci_apply_fixup_final_quirks = true;
 	for_each_pci_dev(dev) {
 		pci_fixup_device(pci_fixup_final, dev);
@@ -182,11 +179,11 @@ static int __init pci_apply_final_quirks(void)
 		}
 	}
 
-	if (!pci_cache_line_size) {
-		pr_info("PCI: CLS %u bytes, default %u\n", cls << 2,
-			pci_dfl_cache_line_size << 2);
-		pci_cache_line_size = cls ? cls : pci_dfl_cache_line_size;
-	}
+	if (!pci_cache_line_size)
+		pci_cache_line_size = cls ?: pci_dfl_cache_line_size;
+
+	pr_debug("PCI: CLS %u bytes, default %u\n", pci_cache_line_size << 2,
+		 pci_dfl_cache_line_size << 2);
 
 	return 0;
 }
-- 
2.29.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-09 14:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 14:00 [PATCH] PCI: Change CLS info in pci_apply_final_quirks to debug level Heiner Kallweit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).