From: "Jian Yang (杨戬)" <Jian.Yang@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jieyy Yang (杨洁)" <Jieyy.Yang@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Chuanjia Liu (柳传嘉)" <Chuanjia.Liu@mediatek.com>,
"Qizhong Cheng (程啟忠)" <Qizhong.Cheng@mediatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"kw@linux.com" <kw@linux.com>,
"Jianjun Wang (王建军)" <Jianjun.Wang@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Ryder Lee" <Ryder.Lee@mediatek.com>,
"David-YH Chiu (邱鈺翔)" <David-YH.Chiu@mediatek.com>,
"Rex-BC Chen (陳柏辰)" <Rex-BC.Chen@mediatek.com>
Subject: Re: [PATCH 2/2] dt-bindings: PCI: mediatek-gen3: Add support for controlling power and reset
Date: Thu, 9 Feb 2023 06:48:09 +0000 [thread overview]
Message-ID: <7f96a46c330459961e2fc18afd92fdfd66ab2bf5.camel@mediatek.com> (raw)
In-Reply-To: <CAL_Jsq+eAQ-M9a+9g7Kk3GC9WjE_4mZXXrsdm4PucOJ4p2QYVQ@mail.gmail.com>
Dear Rob,
Thanks for your comment.
On Fri, 2023-02-03 at 10:07 -0600, Rob Herring wrote:
> On Tue, Jan 10, 2023 at 9:28 PM Jian Yang <jian.yang@mediatek.com>
> wrote:
> >
> > From: "jian.yang" <jian.yang@mediatek.com>
> >
> > Add new properties to support control power supplies and reset pin
> > of
> > a downstream component.
> >
> > Signed-off-by: jian.yang <jian.yang@mediatek.com>
> > ---
> > .../bindings/pci/mediatek-pcie-gen3.yaml | 23
> > +++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 7e8c7a2a5f9b..46149cc63989 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -84,6 +84,29 @@ properties:
> > items:
> > enum: [ phy, mac ]
> >
> > + pcie1v8-supply:
> > + description:
> > + The regulator phandle that provides 1.8V power to downstream
> > component.
> > +
> > + pcie3v3-supply:
> > + description:
> > + The regulator phandle that provides 3.3V power to downstream
> > component.
> > +
> > + pcie12v-supply:
> > + description:
> > + The regulator phandle that provides 12V power to downstream
> > component.
>
> While in some bindings we've allowed these in the host bridge node,
> that is a mistake. These should be in the root port node. You
> probably
> don't have one in DT, so add one.
In Mediatek's PCIe structure, there is only one root port under a host
bridge. I am wondering if you think it's necessary to add a root port
node in our host bridge node based on that structure?
And I'm a bit confused about how to declare a property which should be
added in a root port node. I would be grateful if you could provide me
some good example about it.
> > +
> > + dsc-reset-gpios:
> > + description:
> > + The reset GPIO of a downstream component.
> > + maxItems: 1
> > +
> > + dsc-reset-msleep:
>
> Doesn't the PCI spec define this time? We're talking about PERST#,
> right?
The "dsc-reset-gpios" represents an extra reset pin other than PERST#
required by a downstream component. I tried to add a property here so
that users can control the delay time between the assertion and
deassertion according to their requirement, but Krzysztof mentioned
that there is an ongoing discussion about a "GPIO delay" driver can
handle this. So I will remove the "dsc-reset-msleep" in V2 patch.
> > + description:
> > + The delay time between assertion and de-assertion of a
> > downstream
> > + component's reset GPIO.
> > + maxItems: 1
> > +
> > clocks:
> > minItems: 4
> > maxItems: 6
> > --
> > 2.18.0
> >
Best regards,
Jian Yang
prev parent reply other threads:[~2023-02-09 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 3:28 [PATCH 0/2] PCI: mediatek-gen3: Support controlling power and reset of downstream componennt Jian Yang
2023-01-11 3:28 ` [PATCH 1/2] PCI: mediatek-gen3: Add power and reset control feature for downstream component Jian Yang
2023-01-11 3:28 ` [PATCH 2/2] dt-bindings: PCI: mediatek-gen3: Add support for controlling power and reset Jian Yang
2023-01-11 9:30 ` Krzysztof Kozlowski
2023-02-03 9:38 ` Jian Yang (杨戬)
2023-02-03 12:32 ` Krzysztof Kozlowski
2023-02-10 5:45 ` Jian Yang (杨戬)
2023-02-03 16:07 ` Rob Herring
2023-02-09 6:48 ` Jian Yang (杨戬) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f96a46c330459961e2fc18afd92fdfd66ab2bf5.camel@mediatek.com \
--to=jian.yang@mediatek.com \
--cc=Chuanjia.Liu@mediatek.com \
--cc=David-YH.Chiu@mediatek.com \
--cc=Jianjun.Wang@mediatek.com \
--cc=Jieyy.Yang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Qizhong.Cheng@mediatek.com \
--cc=Rex-BC.Chen@mediatek.com \
--cc=Ryder.Lee@mediatek.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).