From: Rob Herring <robh@kernel.org>
To: Jian Yang <jian.yang@mediatek.com>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
chuanjia.liu@mediatek.com, jieyy.yang@mediatek.com,
qizhong.cheng@mediatek.com, rex-bc.chen@mediatek.com,
david-yh.chiu@mediatek.com
Subject: Re: [PATCH 2/2] dt-bindings: PCI: mediatek-gen3: Add support for controlling power and reset
Date: Fri, 3 Feb 2023 10:07:26 -0600 [thread overview]
Message-ID: <CAL_Jsq+eAQ-M9a+9g7Kk3GC9WjE_4mZXXrsdm4PucOJ4p2QYVQ@mail.gmail.com> (raw)
In-Reply-To: <20230111032830.20447-3-jian.yang@mediatek.com>
On Tue, Jan 10, 2023 at 9:28 PM Jian Yang <jian.yang@mediatek.com> wrote:
>
> From: "jian.yang" <jian.yang@mediatek.com>
>
> Add new properties to support control power supplies and reset pin of
> a downstream component.
>
> Signed-off-by: jian.yang <jian.yang@mediatek.com>
> ---
> .../bindings/pci/mediatek-pcie-gen3.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 7e8c7a2a5f9b..46149cc63989 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -84,6 +84,29 @@ properties:
> items:
> enum: [ phy, mac ]
>
> + pcie1v8-supply:
> + description:
> + The regulator phandle that provides 1.8V power to downstream component.
> +
> + pcie3v3-supply:
> + description:
> + The regulator phandle that provides 3.3V power to downstream component.
> +
> + pcie12v-supply:
> + description:
> + The regulator phandle that provides 12V power to downstream component.
While in some bindings we've allowed these in the host bridge node,
that is a mistake. These should be in the root port node. You probably
don't have one in DT, so add one.
> +
> + dsc-reset-gpios:
> + description:
> + The reset GPIO of a downstream component.
> + maxItems: 1
> +
> + dsc-reset-msleep:
Doesn't the PCI spec define this time? We're talking about PERST#, right?
> + description:
> + The delay time between assertion and de-assertion of a downstream
> + component's reset GPIO.
> + maxItems: 1
> +
> clocks:
> minItems: 4
> maxItems: 6
> --
> 2.18.0
>
next prev parent reply other threads:[~2023-02-03 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 3:28 [PATCH 0/2] PCI: mediatek-gen3: Support controlling power and reset of downstream componennt Jian Yang
2023-01-11 3:28 ` [PATCH 1/2] PCI: mediatek-gen3: Add power and reset control feature for downstream component Jian Yang
2023-01-11 3:28 ` [PATCH 2/2] dt-bindings: PCI: mediatek-gen3: Add support for controlling power and reset Jian Yang
2023-01-11 9:30 ` Krzysztof Kozlowski
2023-02-03 9:38 ` Jian Yang (杨戬)
2023-02-03 12:32 ` Krzysztof Kozlowski
2023-02-10 5:45 ` Jian Yang (杨戬)
2023-02-03 16:07 ` Rob Herring [this message]
2023-02-09 6:48 ` Jian Yang (杨戬)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+eAQ-M9a+9g7Kk3GC9WjE_4mZXXrsdm4PucOJ4p2QYVQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=bhelgaas@google.com \
--cc=chuanjia.liu@mediatek.com \
--cc=david-yh.chiu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jian.yang@mediatek.com \
--cc=jianjun.wang@mediatek.com \
--cc=jieyy.yang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=qizhong.cheng@mediatek.com \
--cc=rex-bc.chen@mediatek.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).