* [PATCH] PCI: iproc: Enable iProc config read for PAXBv2
@ 2019-04-26 9:20 Srinath Mannam
2019-04-26 16:27 ` Ray Jui
2019-04-30 15:01 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Srinath Mannam @ 2019-04-26 9:20 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Ray Jui, Scott Branden
Cc: bcm-kernel-feedback-list, linux-pci, linux-arm-kernel,
linux-kernel, Srinath Mannam
iProc config read flag has to enable for PAXBv2 instead of PAXB.
Fixes: f78e60a29d4ff ("PCI: iproc: Reject unconfigured physical functions from PAXC")
Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
---
drivers/pci/controller/pcie-iproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
index c20fd6b..9d5cbc7 100644
--- a/drivers/pci/controller/pcie-iproc.c
+++ b/drivers/pci/controller/pcie-iproc.c
@@ -1347,7 +1347,6 @@ static int iproc_pcie_rev_init(struct iproc_pcie *pcie)
break;
case IPROC_PCIE_PAXB:
regs = iproc_pcie_reg_paxb;
- pcie->iproc_cfg_read = true;
pcie->has_apb_err_disable = true;
if (pcie->need_ob_cfg) {
pcie->ob_map = paxb_ob_map;
@@ -1356,6 +1355,7 @@ static int iproc_pcie_rev_init(struct iproc_pcie *pcie)
break;
case IPROC_PCIE_PAXB_V2:
regs = iproc_pcie_reg_paxb_v2;
+ pcie->iproc_cfg_read = true;
pcie->has_apb_err_disable = true;
if (pcie->need_ob_cfg) {
pcie->ob_map = paxb_v2_ob_map;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: iproc: Enable iProc config read for PAXBv2
2019-04-26 9:20 [PATCH] PCI: iproc: Enable iProc config read for PAXBv2 Srinath Mannam
@ 2019-04-26 16:27 ` Ray Jui
2019-04-30 15:01 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Ray Jui @ 2019-04-26 16:27 UTC (permalink / raw)
To: Srinath Mannam, Bjorn Helgaas, Lorenzo Pieralisi, Ray Jui, Scott Branden
Cc: bcm-kernel-feedback-list, linux-pci, linux-arm-kernel, linux-kernel
Hi Srinath,
On 4/26/2019 2:20 AM, Srinath Mannam wrote:
> iProc config read flag has to enable for PAXBv2 instead of PAXB.
>
> Fixes: f78e60a29d4ff ("PCI: iproc: Reject unconfigured physical functions from PAXC")
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> ---
> drivers/pci/controller/pcie-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index c20fd6b..9d5cbc7 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -1347,7 +1347,6 @@ static int iproc_pcie_rev_init(struct iproc_pcie *pcie)
> break;
> case IPROC_PCIE_PAXB:
> regs = iproc_pcie_reg_paxb;
> - pcie->iproc_cfg_read = true;
> pcie->has_apb_err_disable = true;
> if (pcie->need_ob_cfg) {
> pcie->ob_map = paxb_ob_map;
> @@ -1356,6 +1355,7 @@ static int iproc_pcie_rev_init(struct iproc_pcie *pcie)
> break;
> case IPROC_PCIE_PAXB_V2:
> regs = iproc_pcie_reg_paxb_v2;
> + pcie->iproc_cfg_read = true;
> pcie->has_apb_err_disable = true;
> if (pcie->need_ob_cfg) {
> pcie->ob_map = paxb_v2_ob_map;
>
Fix looks good to me. Thanks!
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: iproc: Enable iProc config read for PAXBv2
2019-04-26 9:20 [PATCH] PCI: iproc: Enable iProc config read for PAXBv2 Srinath Mannam
2019-04-26 16:27 ` Ray Jui
@ 2019-04-30 15:01 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2019-04-30 15:01 UTC (permalink / raw)
To: Srinath Mannam
Cc: Bjorn Helgaas, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
linux-pci, linux-arm-kernel, linux-kernel
On Fri, Apr 26, 2019 at 02:50:04PM +0530, Srinath Mannam wrote:
> iProc config read flag has to enable for PAXBv2 instead of PAXB.
>
> Fixes: f78e60a29d4ff ("PCI: iproc: Reject unconfigured physical functions from PAXC")
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> ---
> drivers/pci/controller/pcie-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/iproc, thank you.
Lorenzo
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index c20fd6b..9d5cbc7 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -1347,7 +1347,6 @@ static int iproc_pcie_rev_init(struct iproc_pcie *pcie)
> break;
> case IPROC_PCIE_PAXB:
> regs = iproc_pcie_reg_paxb;
> - pcie->iproc_cfg_read = true;
> pcie->has_apb_err_disable = true;
> if (pcie->need_ob_cfg) {
> pcie->ob_map = paxb_ob_map;
> @@ -1356,6 +1355,7 @@ static int iproc_pcie_rev_init(struct iproc_pcie *pcie)
> break;
> case IPROC_PCIE_PAXB_V2:
> regs = iproc_pcie_reg_paxb_v2;
> + pcie->iproc_cfg_read = true;
> pcie->has_apb_err_disable = true;
> if (pcie->need_ob_cfg) {
> pcie->ob_map = paxb_v2_ob_map;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-30 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-26 9:20 [PATCH] PCI: iproc: Enable iProc config read for PAXBv2 Srinath Mannam
2019-04-26 16:27 ` Ray Jui
2019-04-30 15:01 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).