From: Marc Zyngier <maz@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Marek Behún" <kabel@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 10/14] PCI: aardvark: Enable MSI-X support
Date: Thu, 28 Oct 2021 16:24:08 +0100 [thread overview]
Message-ID: <87r1c59nqf.wl-maz@kernel.org> (raw)
In-Reply-To: <20211028113724.gm6zhqt7qcyxtgkq@pali>
On Thu, 28 Oct 2021 12:37:24 +0100,
Pali Rohár <pali@kernel.org> wrote:
>
> On Thursday 28 October 2021 12:30:30 Lorenzo Pieralisi wrote:
> > On Thu, Oct 28, 2021 at 01:13:02PM +0200, Pali Rohár wrote:
> >
> > [...]
> >
> > > > > In commit message I originally tried to explain it that after applying
> > > > > all previous patches which are fixing MSI and Multi-MSI support (part of
> > > > > them is enforcement to use only MSI numbers 0..31), it makes driver
> > > > > compatible with also MSI-X interrupts.
> > > > >
> > > > > If you want to rewrite commit message, let us know, there is no problem.
> > > >
> > > > I think we should.
> > > >
> > > > > > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > > > > > Reviewed-by: Marek Behún <kabel@kernel.org>
> > > >
> > > > By the way, this tag should be removed. Marek signed it off, that
> > > > applies to other patches in this series as well.
> > >
> > > Ok! Is this the only issue with this patch series? Or something other
> > > needs to be fixed?
> >
> > The series looks fine to me - only thing for patch[4-10] I'd like
> > to have evidence MarcZ is happy with the approach
>
> Marc, could you look at patches 4-10 if you are happy with them? Link:
> https://lore.kernel.org/linux-pci/20211012164145.14126-5-kabel@kernel.org/
Started with patch #4, and saw that you are still using
irq_find_mapping + generic_handle_irq which I objected to every time I
looked at this patch ([1], [2]).
My NAK still stands, and I haven't looked any further, because you
obviously don't really care about review comments.
M.
[1] https://lore.kernel.org/r/8735r0qfab.wl-maz@kernel.org
[2] https://lore.kernel.org/r/871r6kqf2d.wl-maz@kernel.org
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-10-28 15:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 16:41 [PATCH 00/14] PCI: aardvark controller fixes BATCH 2 Marek Behún
2021-10-12 16:41 ` [PATCH 01/14] PCI: pci-bridge-emul: Fix emulation of W1C bits Marek Behún
2021-10-12 16:41 ` [PATCH 02/14] PCI: aardvark: Fix return value of MSI domain .alloc() method Marek Behún
2021-10-27 11:26 ` Lorenzo Pieralisi
2021-10-27 11:31 ` Pali Rohár
2021-10-12 16:41 ` [PATCH 03/14] PCI: aardvark: Read all 16-bits from PCIE_MSI_PAYLOAD_REG Marek Behún
2021-10-12 16:41 ` [PATCH 04/14] PCI: aardvark: Fix support for MSI interrupts Marek Behún
2021-10-12 16:41 ` [PATCH 05/14] PCI: aardvark: Fix reading MSI interrupt number Marek Behún
2021-10-12 16:41 ` [PATCH 06/14] PCI: aardvark: Clear all MSIs at setup Marek Behún
2021-10-12 16:41 ` [PATCH 07/14] PCI: aardvark: Refactor unmasking summary MSI interrupt Marek Behún
2021-10-12 16:41 ` [PATCH 08/14] PCI: aardvark: Fix masking MSI interrupts Marek Behún
2021-10-12 16:41 ` [PATCH 09/14] PCI: aardvark: Fix setting MSI address Marek Behún
2021-10-12 16:41 ` [PATCH 10/14] PCI: aardvark: Enable MSI-X support Marek Behún
2021-10-27 14:12 ` Lorenzo Pieralisi
2021-10-27 14:23 ` Pali Rohár
2021-10-28 11:08 ` Lorenzo Pieralisi
2021-10-28 11:13 ` Pali Rohár
2021-10-28 11:30 ` Lorenzo Pieralisi
2021-10-28 11:37 ` Pali Rohár
2021-10-28 15:24 ` Marc Zyngier [this message]
2021-10-28 15:29 ` Pali Rohár
2021-10-28 15:51 ` Marek Behún
2021-10-28 16:22 ` Marc Zyngier
2021-10-28 16:25 ` Marek Behún
2021-10-28 17:00 ` Marc Zyngier
2021-10-28 17:47 ` Lorenzo Pieralisi
2021-10-28 18:24 ` Marek Behún
2021-10-12 16:41 ` [PATCH 11/14] PCI: aardvark: Fix support for bus mastering and PCI_COMMAND on emulated bridge Marek Behún
2021-10-12 16:41 ` [PATCH 12/14] PCI: aardvark: Set PCI Bridge Class Code to PCI Bridge Marek Behún
2021-10-28 18:30 ` Lorenzo Pieralisi
2021-10-28 18:45 ` Pali Rohár
2021-10-28 20:43 ` Bjorn Helgaas
2021-10-12 16:41 ` [PATCH 13/14] PCI: aardvark: Fix support for PCI_BRIDGE_CTL_BUS_RESET on emulated bridge Marek Behún
2021-10-12 16:41 ` [PATCH 14/14] PCI: aardvark: Fix support for PCI_ROM_ADDRESS1 " Marek Behún
2021-10-19 18:36 ` [PATCH 00/14] PCI: aardvark controller fixes BATCH 2 Pali Rohár
2021-10-28 18:33 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1c59nqf.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bhelgaas@google.com \
--cc=kabel@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).