[PATCH v2] dt-bindings: PCI: apple: Add missing 'power-domains' property

[PATCH v2] dt-bindings: PCI: apple: Add missing 'power-domains' property

[Rob Herring]

The 'unevaluatedProperties' schema checks is not fully working and doesn't
catch some cases where there's a $ref to another schema. A fix is pending,
but results in new warnings in examples.

The Apple PCIe host schema is missing 'power-domains' in the schema.
The example has 3 power domains. However, this is wrong too as actual
dts files have a single power domain and Sven confirmed 1 is correct.

Cc: Sven Peter <sven@svenpeter.dev>
Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
 - Correct the power-domains to be 1 and update the example
---
 Documentation/devicetree/bindings/pci/apple,pcie.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/apple,pcie.yaml b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
index daf602ac0d0f..aa38680aaaca 100644
--- a/Documentation/devicetree/bindings/pci/apple,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
@@ -68,6 +68,9 @@ properties:
   iommu-map: true
   iommu-map-mask: true
 
+  power-domains:
+    maxItems: 1
+
 required:
   - compatible
   - reg
@@ -134,7 +137,7 @@ examples:
         ranges = <0x43000000 0x6 0xa0000000 0x6 0xa0000000 0x0 0x20000000>,
                  <0x02000000 0x0 0xc0000000 0x6 0xc0000000 0x0 0x40000000>;
 
-        power-domains = <&ps_apcie>, <&ps_apcie_gp>, <&ps_pcie_ref>;
+        power-domains = <&ps_apcie_gp>;
         pinctrl-0 = <&pcie_pins>;
         pinctrl-names = "default";
 
-- 
2.34.1

Re: [PATCH v2] dt-bindings: PCI: apple: Add missing 'power-domains' property

[Sven Peter]

> On 31. May 2022, at 23:58, Rob Herring <robh@kernel.org> wrote:
> 
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> The Apple PCIe host schema is missing 'power-domains' in the schema.
> The example has 3 power domains. However, this is wrong too as actual
> dts files have a single power domain and Sven confirmed 1 is correct.
> 
> Cc: Sven Peter <sven@svenpeter.dev>
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Sven Peter <sven@svenpeter.dev>

Re: [PATCH v2] dt-bindings: PCI: apple: Add missing 'power-domains' property

[Rob Herring]

On Tue, 31 May 2022 16:58:14 -0500, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
> 
> The Apple PCIe host schema is missing 'power-domains' in the schema.
> The example has 3 power domains. However, this is wrong too as actual
> dts files have a single power domain and Sven confirmed 1 is correct.
> 
> Cc: Sven Peter <sven@svenpeter.dev>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
>  - Correct the power-domains to be 1 and update the example
> ---
>  Documentation/devicetree/bindings/pci/apple,pcie.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Applied, thanks!