From: Sherry Sun <sherry.sun@nxp.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "hch@infradead.org" <hch@infradead.org>,
"vincent.whitchurch@axis.com" <vincent.whitchurch@axis.com>,
"sudeep.dutt@intel.com" <sudeep.dutt@intel.com>,
"ashutosh.dixit@intel.com" <ashutosh.dixit@intel.com>,
"arnd@arndb.de" <arnd@arndb.de>, "kishon@ti.com" <kishon@ti.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>, Andy Duan <fugang.duan@nxp.com>
Subject: RE: [PATCH V5 0/2] Change vring space from nomal memory to dma coherent memory
Date: Wed, 28 Oct 2020 06:05:28 +0000 [thread overview]
Message-ID: <AM0PR04MB4947032368486CC9874C812692170@AM0PR04MB4947.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20201028055836.GA244690@kroah.com>
Hi Greg,
> Subject: Re: [PATCH V5 0/2] Change vring space from nomal memory to dma
> coherent memory
>
> On Wed, Oct 28, 2020 at 10:03:03AM +0800, Sherry Sun wrote:
> > Changes in V5:
> > 1. Reorganize the vop_mmap function code in patch 1, which is done by
> Christoph.
> > 2. Completely remove the unnecessary code related to reassign the used
> > ring for card in patch 2.
> >
> > The original vop driver only supports dma coherent device, as it
> > allocates and maps vring by _get_free_pages and dma_map_single, but
> > not use dma_sync_single_for_cpu/device to sync the updates of
> > device_page/vring between EP and RC, which will cause memory
> > synchronization problem for device don't support hardware dma coherent.
> >
> > And allocate vrings use dma_alloc_coherent is a common way in kernel,
> > as the memory interacted between two systems should use consistent
> > memory to avoid caching effects. So here add noncoherent platform
> support for vop driver.
> > Also add some related dma changes to make sure noncoherent platform
> > works well.
> >
> > Sherry Sun (2):
> > misc: vop: change the way of allocating vrings and device page
> > misc: vop: do not allocate and reassign the used ring
> >
> > drivers/misc/mic/bus/vop_bus.h | 2 +
> > drivers/misc/mic/host/mic_boot.c | 9 ++
> > drivers/misc/mic/host/mic_main.c | 43 ++------
> > drivers/misc/mic/vop/vop_debugfs.c | 4 -
> > drivers/misc/mic/vop/vop_main.c | 70 +-----------
> > drivers/misc/mic/vop/vop_vringh.c | 166 ++++++++++-------------------
> > include/uapi/linux/mic_common.h | 9 +-
> > 7 files changed, 85 insertions(+), 218 deletions(-)
>
> Have you all seen:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%
> 2Flore.kernel.org%2Fr%2F8c1443136563de34699d2c084df478181c205db4.16
> 03854416.git.sudeep.dutt%40intel.com&data=04%7C01%7Csherry.sun%
> 40nxp.com%7Cc19c987667434969847e08d87b0685e8%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0%7C0%7C637394615238940323%7CUnknown%7CTW
> FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> VCI6Mn0%3D%7C1000&sdata=Zq%2FtHWTq%2BuIVBYXFGoeBmq0JJzYd
> 9zDyv4NVN4TpC%2FU%3D&reserved=0
>
> Looks like this code is asking to just be deleted, is that ok with you?
Yes, I saw that patch. I'm ok with it.
Best regards
Sherry
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2020-10-29 2:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 2:03 [PATCH V5 0/2] Change vring space from nomal memory to dma coherent memory Sherry Sun
2020-10-28 2:03 ` [PATCH V5 1/2] misc: vop: change the way of allocating vrings and device page Sherry Sun
2020-10-28 2:03 ` [PATCH V5 2/2] misc: vop: do not allocate and reassign the used ring Sherry Sun
2020-10-28 5:58 ` [PATCH V5 0/2] Change vring space from nomal memory to dma coherent memory Greg KH
2020-10-28 6:05 ` Sherry Sun [this message]
2020-10-28 7:07 ` Greg KH
2020-10-28 7:11 ` Sherry Sun
2020-10-28 10:17 ` [EXT] " Andy Duan
2020-10-28 11:13 ` Greg KH
2020-10-28 15:11 ` Andy Duan
2020-10-28 15:42 ` Greg KH
2020-10-29 1:51 ` Sherry Sun
2020-10-29 2:03 ` Dutt, Sudeep
2020-10-28 9:09 ` Vincent Whitchurch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4947032368486CC9874C812692170@AM0PR04MB4947.eurprd04.prod.outlook.com \
--to=sherry.sun@nxp.com \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=fugang.duan@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=kishon@ti.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sudeep.dutt@intel.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).