linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'
@ 2022-07-19 21:50 Rob Herring
  2022-07-20  1:31 ` Hongxing Zhu
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2022-07-19 21:50 UTC (permalink / raw)
  To: Richard Zhu, Lucas Stach, Bjorn Helgaas, Krzysztof Kozlowski,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team
  Cc: linux-pci, linux-arm-kernel, devicetree, linux-kernel

'reset-gpio-active-high' is missing a type definition and is not a common
property. The type is boolean.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 252e5b72aee0..376e739bcad4 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -144,6 +144,7 @@ properties:
     description: If present then the reset sequence using the GPIO
       specified in the "reset-gpio" property is reversed (H=reset state,
       L=operation state) (optional required).
+    type: boolean
 
   vpcie-supply:
     description: Should specify the regulator in charge of PCIe port power.
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'
  2022-07-19 21:50 [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high' Rob Herring
@ 2022-07-20  1:31 ` Hongxing Zhu
  2022-07-20 21:07 ` Bjorn Helgaas
  2022-07-22 21:59 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Hongxing Zhu @ 2022-07-20  1:31 UTC (permalink / raw)
  To: Rob Herring, Lucas Stach, Bjorn Helgaas, Krzysztof Kozlowski,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	dl-linux-imx
  Cc: linux-pci, linux-arm-kernel, devicetree, linux-kernel

Hi Rob:
Thanks for your kindly help.

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2022年7月20日 5:51
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; Lucas Stach
> <l.stach@pengutronix.de>; Bjorn Helgaas <bhelgaas@google.com>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> Pengutronix Kernel Team <kernel@pengutronix.de>; Fabio Estevam
> <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>
> Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for
> 'reset-gpio-active-high'
> 
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Richard Zhu <hongxing.zhu@nxp.com>

Best Regards
Richard Zhu
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 252e5b72aee0..376e739bcad4 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -144,6 +144,7 @@ properties:
>      description: If present then the reset sequence using the GPIO
>        specified in the "reset-gpio" property is reversed (H=reset state,
>        L=operation state) (optional required).
> +    type: boolean
> 
>    vpcie-supply:
>      description: Should specify the regulator in charge of PCIe port power.
> --
> 2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'
  2022-07-19 21:50 [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high' Rob Herring
  2022-07-20  1:31 ` Hongxing Zhu
@ 2022-07-20 21:07 ` Bjorn Helgaas
  2022-07-22 21:59 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2022-07-20 21:07 UTC (permalink / raw)
  To: Rob Herring
  Cc: Richard Zhu, Lucas Stach, Bjorn Helgaas, Krzysztof Kozlowski,
	Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, linux-pci, linux-arm-kernel, devicetree,
	linux-kernel

On Tue, Jul 19, 2022 at 03:50:31PM -0600, Rob Herring wrote:
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

You've merged previous updates, Rob, so I assume you'll do the same
with this.

> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 252e5b72aee0..376e739bcad4 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -144,6 +144,7 @@ properties:
>      description: If present then the reset sequence using the GPIO
>        specified in the "reset-gpio" property is reversed (H=reset state,
>        L=operation state) (optional required).
> +    type: boolean
>  
>    vpcie-supply:
>      description: Should specify the regulator in charge of PCIe port power.
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high'
  2022-07-19 21:50 [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high' Rob Herring
  2022-07-20  1:31 ` Hongxing Zhu
  2022-07-20 21:07 ` Bjorn Helgaas
@ 2022-07-22 21:59 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-07-22 21:59 UTC (permalink / raw)
  To: Rob Herring
  Cc: Richard Zhu, Shawn Guo, Pengutronix Kernel Team, Fabio Estevam,
	Bjorn Helgaas, NXP Linux Team, Sascha Hauer, linux-pci,
	Lucas Stach, linux-arm-kernel, devicetree, linux-kernel,
	Krzysztof Kozlowski

On Tue, 19 Jul 2022 15:50:31 -0600, Rob Herring wrote:
> 'reset-gpio-active-high' is missing a type definition and is not a common
> property. The type is boolean.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-22 21:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 21:50 [PATCH] dt-bindings: PCI: fsl,imx6q-pcie: Add missing type for 'reset-gpio-active-high' Rob Herring
2022-07-20  1:31 ` Hongxing Zhu
2022-07-20 21:07 ` Bjorn Helgaas
2022-07-22 21:59 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).