* [PATCH] PCI: xilinx-nwl: Fix Multi MSI data programming
@ 2019-02-13 14:25 Bharat Kumar Gogada
2019-02-13 16:40 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Bharat Kumar Gogada @ 2019-02-13 14:25 UTC (permalink / raw)
To: bhelgaas, lorenzo.pieralisi
Cc: linux-pci, linux-arm-kernel, linux-kernel, Bharat Kumar Gogada
The current Multi MSI data programming fails if a
end point is connected with switch.
Fix Multi MSI data, by programming data with required alignment.
Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
---
drivers/pci/controller/pcie-xilinx-nwl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c
index 81538d7..36669c5 100644
--- a/drivers/pci/controller/pcie-xilinx-nwl.c
+++ b/drivers/pci/controller/pcie-xilinx-nwl.c
@@ -484,7 +484,7 @@ static int nwl_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
mutex_lock(&msi->lock);
bit = bitmap_find_next_zero_area(msi->bitmap, INT_PCI_MSI_NR, 0,
- nr_irqs, 0);
+ nr_irqs, nr_irqs - 1);
if (bit >= INT_PCI_MSI_NR) {
mutex_unlock(&msi->lock);
return -ENOSPC;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: xilinx-nwl: Fix Multi MSI data programming
2019-02-13 14:25 [PATCH] PCI: xilinx-nwl: Fix Multi MSI data programming Bharat Kumar Gogada
@ 2019-02-13 16:40 ` Lorenzo Pieralisi
2019-02-14 11:30 ` Bharat Kumar Gogada
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Pieralisi @ 2019-02-13 16:40 UTC (permalink / raw)
To: Bharat Kumar Gogada; +Cc: bhelgaas, linux-pci, linux-arm-kernel, linux-kernel
On Wed, Feb 13, 2019 at 07:55:39PM +0530, Bharat Kumar Gogada wrote:
> The current Multi MSI data programming fails if a
> end point is connected with switch.
>
> Fix Multi MSI data, by programming data with required alignment.
I have no idea what this means. If you are fixing a bug describe
it properly and provide a Fixes: tag with the commit you are fixing.
Thanks,
Lorenzo
> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
> ---
> drivers/pci/controller/pcie-xilinx-nwl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c
> index 81538d7..36669c5 100644
> --- a/drivers/pci/controller/pcie-xilinx-nwl.c
> +++ b/drivers/pci/controller/pcie-xilinx-nwl.c
> @@ -484,7 +484,7 @@ static int nwl_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
>
> mutex_lock(&msi->lock);
> bit = bitmap_find_next_zero_area(msi->bitmap, INT_PCI_MSI_NR, 0,
> - nr_irqs, 0);
> + nr_irqs, nr_irqs - 1);
> if (bit >= INT_PCI_MSI_NR) {
> mutex_unlock(&msi->lock);
> return -ENOSPC;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] PCI: xilinx-nwl: Fix Multi MSI data programming
2019-02-13 16:40 ` Lorenzo Pieralisi
@ 2019-02-14 11:30 ` Bharat Kumar Gogada
0 siblings, 0 replies; 3+ messages in thread
From: Bharat Kumar Gogada @ 2019-02-14 11:30 UTC (permalink / raw)
To: lorenzo.pieralisi; +Cc: bhelgaas, linux-pci, linux-arm-kernel, linux-kernel
> Subject: Re: [PATCH] PCI: xilinx-nwl: Fix Multi MSI data programming
>
> On Wed, Feb 13, 2019 at 07:55:39PM +0530, Bharat Kumar Gogada wrote:
> > The current Multi MSI data programming fails if a end point is
> > connected with switch.
> >
> > Fix Multi MSI data, by programming data with required alignment.
>
> I have no idea what this means. If you are fixing a bug describe it properly
> and provide a Fixes: tag with the commit you are fixing.
>
Thanks Lorenzo for your time. Will add above details and re send.
Regards,
Bharat
>
>
> > Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
> > ---
> > drivers/pci/controller/pcie-xilinx-nwl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c
> > b/drivers/pci/controller/pcie-xilinx-nwl.c
> > index 81538d7..36669c5 100644
> > --- a/drivers/pci/controller/pcie-xilinx-nwl.c
> > +++ b/drivers/pci/controller/pcie-xilinx-nwl.c
> > @@ -484,7 +484,7 @@ static int nwl_irq_domain_alloc(struct irq_domain
> > *domain, unsigned int virq,
> >
> > mutex_lock(&msi->lock);
> > bit = bitmap_find_next_zero_area(msi->bitmap, INT_PCI_MSI_NR, 0,
> > - nr_irqs, 0);
> > + nr_irqs, nr_irqs - 1);
> > if (bit >= INT_PCI_MSI_NR) {
> > mutex_unlock(&msi->lock);
> > return -ENOSPC;
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-14 11:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 14:25 [PATCH] PCI: xilinx-nwl: Fix Multi MSI data programming Bharat Kumar Gogada
2019-02-13 16:40 ` Lorenzo Pieralisi
2019-02-14 11:30 ` Bharat Kumar Gogada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).