From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"bjorn@helgaas.com" <bjorn@helgaas.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] drivers: block: save return value of pci_find_capability() in u8
Date: Mon, 7 Dec 2020 01:48:41 +0000 [thread overview]
Message-ID: <BYAPR04MB4965B160F84F31303855501C86CE0@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20201207012600.GA2238381@bjorn-Precision-5520
Bjorn,
On 12/6/20 17:26, Bjorn Helgaas wrote:
> There's a patch pending via the PCI tree to change the return type to
> u8. We can do one of:
I did not know about the pending patch, if that is going to change the
return
type then this patch makes sense.
>
> - Ignore this. It only changes something on the stack, so no real
> space saving and there's no problem assigning the u8 return value
> to the "int".
> - The maintainer could ack it and I could merge it via the PCI tree
> so it happens in the correct order (after the interface change).
If we want it in 5.11 then I think PCI tree is a right way go about it.
> - The PCI core interface change will be merged for v5.11, so we
> could hold this until v5.12.
> I don't really have a preference. The only place there would really
> be a benefit would be if we store the return value in a struct, where
> we could potentially save three bytes.
Totally agree.
> Bjorn
Whoever is going to apply please add :-
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
next prev parent reply other threads:[~2020-12-07 1:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 19:43 [PATCH] drivers: block: save return value of pci_find_capability() in u8 Puranjay Mohan
2020-12-06 23:08 ` Chaitanya Kulkarni
2020-12-07 1:26 ` Bjorn Helgaas
2020-12-07 1:30 ` Damien Le Moal
2020-12-07 18:38 ` Jens Axboe
2020-12-07 1:48 ` Chaitanya Kulkarni [this message]
2020-12-07 16:17 ` Ben Dooks
2020-12-07 2:25 ` Damien Le Moal
2020-12-07 14:52 ` Christoph Hellwig
2020-12-07 16:04 ` Bjorn Helgaas
2020-12-07 17:53 ` Puranjay Mohan
2020-12-07 18:07 ` Keith Busch
2020-12-07 18:35 ` Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965B160F84F31303855501C86CE0@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=bjorn@helgaas.com \
--cc=helgaas@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).