From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Puranjay Mohan <puranjay12@gmail.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"bjorn@helgaas.com" <bjorn@helgaas.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] drivers: block: save return value of pci_find_capability() in u8
Date: Mon, 7 Dec 2020 02:25:25 +0000 [thread overview]
Message-ID: <CH2PR04MB65226012BF740A12FC754ED6E7CE0@CH2PR04MB6522.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20201206194300.14221-1-puranjay12@gmail.com
On 2020/12/07 4:43, Puranjay Mohan wrote:
> Callers of pci_find_capability should save the return value in u8.
> change type of variables from int to u8 to match the specification.
>
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> ---
> drivers/block/mtip32xx/mtip32xx.c | 2 +-
> drivers/block/skd_main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 153e2cdecb4d..da57d37c6d20 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -3936,7 +3936,7 @@ static DEFINE_HANDLER(7);
>
> static void mtip_disable_link_opts(struct driver_data *dd, struct pci_dev *pdev)
> {
> - int pos;
> + u8 pos;
> unsigned short pcie_dev_ctrl;
>
> pos = pci_find_capability(pdev, PCI_CAP_ID_EXP);
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index a962b4551bed..16d59569129b 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -3136,7 +3136,7 @@ MODULE_DEVICE_TABLE(pci, skd_pci_tbl);
>
> static char *skd_pci_info(struct skd_device *skdev, char *str)
> {
> - int pcie_reg;
> + u8 pcie_reg;
>
> strcpy(str, "PCIe (");
> pcie_reg = pci_find_capability(skdev->pdev, PCI_CAP_ID_EXP);
>
Acked-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2020-12-07 2:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 19:43 [PATCH] drivers: block: save return value of pci_find_capability() in u8 Puranjay Mohan
2020-12-06 23:08 ` Chaitanya Kulkarni
2020-12-07 1:26 ` Bjorn Helgaas
2020-12-07 1:30 ` Damien Le Moal
2020-12-07 18:38 ` Jens Axboe
2020-12-07 1:48 ` Chaitanya Kulkarni
2020-12-07 16:17 ` Ben Dooks
2020-12-07 2:25 ` Damien Le Moal [this message]
2020-12-07 14:52 ` Christoph Hellwig
2020-12-07 16:04 ` Bjorn Helgaas
2020-12-07 17:53 ` Puranjay Mohan
2020-12-07 18:07 ` Keith Busch
2020-12-07 18:35 ` Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR04MB65226012BF740A12FC754ED6E7CE0@CH2PR04MB6522.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=bjorn@helgaas.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=puranjay12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).