From: "Zouwei (Samuel)" <zou_wei@huawei.com>
To: "Wangzhou (B)" <wangzhou1@hisilicon.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"amurray@thegoodpenguin.co.uk" <amurray@thegoodpenguin.co.uk>,
"bhelgaas@google.com" <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static
Date: Thu, 23 Apr 2020 03:09:20 +0000 [thread overview]
Message-ID: <C3CD0DF8AD11A84CB25A1426DE537C61E5951DC6@dggeml524-mbx.china.huawei.com> (raw)
In-Reply-To: <5EA10481.1080604@hisilicon.com>
Hi Wang,
Thanks for your review and reply.
I will modify and send the v2 soon.
Thanks
Zou Wei
-----邮件原件-----
发件人: Wangzhou (B)
发送时间: 2020年4月23日 10:59
收件人: Zouwei (Samuel) <zou_wei@huawei.com>; lorenzo.pieralisi@arm.com; amurray@thegoodpenguin.co.uk; bhelgaas@google.com
抄送: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static
On 2020/4/22 17:47, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
> symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-hisi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..b440f40 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,8 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
> return 0;
> }
>
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
> + }
why adding "}"? BTW, static is OK here.
> .bus_shift = 20,
> .init = hisi_pcie_platform_init,
> .pci_ops = {
>
prev parent reply other threads:[~2020-04-23 3:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 9:47 [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static Zou Wei
2020-04-23 2:59 ` Zhou Wang
2020-04-23 3:09 ` Zouwei (Samuel) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C3CD0DF8AD11A84CB25A1426DE537C61E5951DC6@dggeml524-mbx.china.huawei.com \
--to=zou_wei@huawei.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).