* [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static
@ 2020-04-22 9:47 Zou Wei
2020-04-23 2:59 ` Zhou Wang
0 siblings, 1 reply; 3+ messages in thread
From: Zou Wei @ 2020-04-22 9:47 UTC (permalink / raw)
To: wangzhou1, lorenzo.pieralisi, amurray, bhelgaas
Cc: linux-pci, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/pci/controller/dwc/pcie-hisi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
index 6d9e1b2..b440f40 100644
--- a/drivers/pci/controller/dwc/pcie-hisi.c
+++ b/drivers/pci/controller/dwc/pcie-hisi.c
@@ -362,7 +362,8 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
return 0;
}
-struct pci_ecam_ops hisi_pcie_platform_ops = {
+static struct pci_ecam_ops hisi_pcie_platform_ops = {
+ }
.bus_shift = 20,
.init = hisi_pcie_platform_init,
.pci_ops = {
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static
2020-04-22 9:47 [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static Zou Wei
@ 2020-04-23 2:59 ` Zhou Wang
2020-04-23 3:09 ` 答复: " Zouwei (Samuel)
0 siblings, 1 reply; 3+ messages in thread
From: Zhou Wang @ 2020-04-23 2:59 UTC (permalink / raw)
To: Zou Wei, lorenzo.pieralisi, amurray, bhelgaas; +Cc: linux-pci, linux-kernel
On 2020/4/22 17:47, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
> symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-hisi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..b440f40 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,8 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
> return 0;
> }
>
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
> + }
why adding "}"? BTW, static is OK here.
> .bus_shift = 20,
> .init = hisi_pcie_platform_init,
> .pci_ops = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* 答复: [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static
2020-04-23 2:59 ` Zhou Wang
@ 2020-04-23 3:09 ` Zouwei (Samuel)
0 siblings, 0 replies; 3+ messages in thread
From: Zouwei (Samuel) @ 2020-04-23 3:09 UTC (permalink / raw)
To: Wangzhou (B), lorenzo.pieralisi, amurray, bhelgaas
Cc: linux-pci, linux-kernel
Hi Wang,
Thanks for your review and reply.
I will modify and send the v2 soon.
Thanks
Zou Wei
-----邮件原件-----
发件人: Wangzhou (B)
发送时间: 2020年4月23日 10:59
收件人: Zouwei (Samuel) <zou_wei@huawei.com>; lorenzo.pieralisi@arm.com; amurray@thegoodpenguin.co.uk; bhelgaas@google.com
抄送: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static
On 2020/4/22 17:47, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
> symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-hisi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..b440f40 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,8 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
> return 0;
> }
>
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
> + }
why adding "}"? BTW, static is OK here.
> .bus_shift = 20,
> .init = hisi_pcie_platform_init,
> .pci_ops = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-23 3:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 9:47 [PATCH -next] PCI: dwc: Make hisi_pcie_platform_ops static Zou Wei
2020-04-23 2:59 ` Zhou Wang
2020-04-23 3:09 ` 答复: " Zouwei (Samuel)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).