[PATCH] lspci: Correct Root Capabilities "CRS Software Visibility" bit

[PATCH] lspci: Correct Root Capabilities "CRS Software Visibility" bit

[Bjorn Helgaas]

lspci incorrectly tests bit 4, not bit 0, for "CRS Software Visibility" in
the Root Capabilities register, so it shows "RootCap: CRSVisible-" even for
devices that do support Software Visibility.

Use the correct definition for PCI_EXP_RTCAP_CRSVIS.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 lib/header.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/header.h b/lib/header.h
index db85df1..8ee7565 100644
--- a/lib/header.h
+++ b/lib/header.h
@@ -842,7 +842,7 @@
 #define  PCI_EXP_RTCTL_PMEIE	0x0008	/* PME Interrupt Enable */
 #define  PCI_EXP_RTCTL_CRSVIS	0x0010	/* Configuration Request Retry Status Visible to SW */
 #define PCI_EXP_RTCAP		0x1e	/* Root Capabilities */
-#define  PCI_EXP_RTCAP_CRSVIS	0x0010	/* Configuration Request Retry Status Visible to SW */
+#define  PCI_EXP_RTCAP_CRSVIS	0x0001	/* Configuration Request Retry Status Visible to SW */
 #define PCI_EXP_RTSTA		0x20	/* Root Status */
 #define  PCI_EXP_RTSTA_PME_REQID   0x0000ffff /* PME Requester ID */
 #define  PCI_EXP_RTSTA_PME_STATUS  0x00010000 /* PME Status */

Re: [PATCH] lspci: Correct Root Capabilities "CRS Software Visibility" bit

[Rajat Jain]

Thanks, this will help.

Best Regards,

Rajat

On Mon, Sep 1, 2014 at 9:03 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> lspci incorrectly tests bit 4, not bit 0, for "CRS Software Visibility" in
> the Root Capabilities register, so it shows "RootCap: CRSVisible-" even for
> devices that do support Software Visibility.
>
> Use the correct definition for PCI_EXP_RTCAP_CRSVIS.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  lib/header.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/header.h b/lib/header.h
> index db85df1..8ee7565 100644
> --- a/lib/header.h
> +++ b/lib/header.h
> @@ -842,7 +842,7 @@
>  #define  PCI_EXP_RTCTL_PMEIE   0x0008  /* PME Interrupt Enable */
>  #define  PCI_EXP_RTCTL_CRSVIS  0x0010  /* Configuration Request Retry Status Visible to SW */
>  #define PCI_EXP_RTCAP          0x1e    /* Root Capabilities */
> -#define  PCI_EXP_RTCAP_CRSVIS  0x0010  /* Configuration Request Retry Status Visible to SW */
> +#define  PCI_EXP_RTCAP_CRSVIS  0x0001  /* Configuration Request Retry Status Visible to SW */
>  #define PCI_EXP_RTSTA          0x20    /* Root Status */
>  #define  PCI_EXP_RTSTA_PME_REQID   0x0000ffff /* PME Requester ID */
>  #define  PCI_EXP_RTSTA_PME_STATUS  0x00010000 /* PME Status */
>

Re: [PATCH] lspci: Correct Root Capabilities "CRS Software Visibility" bit

[Martin Mares]

Hi!

> lspci incorrectly tests bit 4, not bit 0, for "CRS Software Visibility" in
> the Root Capabilities register, so it shows "RootCap: CRSVisible-" even for
> devices that do support Software Visibility.
> 
> Use the correct definition for PCI_EXP_RTCAP_CRSVIS.

Thanks, applied.

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj@ucw.cz>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
"The generation of random numbers is too important to be left to chance."