From: Rajat Jain <rajatja@google.com>
To: Dmitry Torokhov <dtor@google.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, rajatxjain@gmail.com,
jsbarnes@google.com
Subject: Re: [PATCH] PCI: ACPI: Allow internal devices to be marked as untrusted
Date: Thu, 27 Jan 2022 15:02:20 -0800 [thread overview]
Message-ID: <CACK8Z6GCPU8ZYQgwCJ5jWJ5NLQM3y+g6Ry=59-oVV3CHGe_8Aw@mail.gmail.com> (raw)
In-Reply-To: <CAE_wzQ_XxONXx5bgDNLAWM_UbV0r8hP9fW6s5sgRYRVSHQWjLw@mail.gmail.com>
Hi Dmitry,
On Wed, Jan 19, 2022 at 6:25 PM Dmitry Torokhov <dtor@google.com> wrote:
>
> Hi Rajat,
>
> On Wed, Jan 19, 2022 at 4:04 PM Rajat Jain <rajatja@google.com> wrote:
> >
> > Today the pci_dev->untrusted is set for any devices sitting downstream
> > an external facing port (determined via "ExternalFacingPort" property).
> > This however, disallows any internal devices to be marked as untrusted.
> >
> > There are use-cases though, where a platform would like to treat an
> > internal device as untrusted (perhaps because it runs untrusted
> > firmware, or offers an attack surface by handling untrusted network
> > data etc).
> >
> > This patch introduces a new "UntrustedDevice" property that can be used
> > by the firmware to mark any device as untrusted.
> >
> > Signed-off-by: Rajat Jain <rajatja@google.com>
> > ---
> > drivers/pci/pci-acpi.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> > index a42dbf448860..3d9e5fa49451 100644
> > --- a/drivers/pci/pci-acpi.c
> > +++ b/drivers/pci/pci-acpi.c
> > @@ -1350,12 +1350,25 @@ static void pci_acpi_set_external_facing(struct pci_dev *dev)
> > dev->external_facing = 1;
> > }
> >
> > +static void pci_acpi_set_untrusted(struct pci_dev *dev)
> > +{
> > + u8 val;
> > +
> > + if (device_property_read_u8(&dev->dev, "UntrustedDevice", &val))
> > + return;
> > +
> > + /* These PCI devices are not trustworthy */
> > + if (val)
> > + dev->untrusted = 1;
>
> Should this all be replaced with:
>
> dev->untrusted = device_property_read_bool(&dev->dev, "UntrustedDevice");
The device_property_read_bool() seems to be merely checking for
property presence (and ignoring its value).
I checked with our BIOS / ACPI team. Per them, the ACPI properties
always have a value associated with them.
So if I switch to device_property_read_bool(), "UntrustedDevice"
property with a value of "0" in ACPI shall be marked as an untrusted
device by the kernel. I understand that this may be a confusing corner
case of bad ACPI, but I was thinking it may be better to use the ACPI
value also in the kernel to decide. Thus I think the use of
device_property_read_u8() (the current code) may be better. WDYT?
Thanks & Best Regards,
Rajat
>
> ?
>
> Also, is this ACPI-specific? Why won't we need this for DT systems (or
> do we already have this)?.
>
> Thanks,
> Dmitry
next prev parent reply other threads:[~2022-01-27 23:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 0:04 [PATCH] PCI: ACPI: Allow internal devices to be marked as untrusted Rajat Jain
2022-01-20 2:25 ` Dmitry Torokhov
2022-01-20 15:08 ` Rajat Jain
2022-01-27 23:02 ` Rajat Jain [this message]
2022-01-21 21:41 ` Bjorn Helgaas
2022-01-22 14:46 ` Greg Kroah-Hartman
2022-01-24 6:27 ` Mika Westerberg
2022-01-25 10:58 ` Mika Westerberg
2022-01-25 11:15 ` Greg Kroah-Hartman
2022-01-25 12:55 ` Mika Westerberg
2022-01-25 14:45 ` Rafael J. Wysocki
2022-01-27 22:26 ` Rajat Jain
2022-01-28 7:48 ` Mika Westerberg
2022-01-28 21:34 ` Rajat Jain
2022-01-30 14:30 ` Rafael J. Wysocki
2022-01-31 6:41 ` Mika Westerberg
2022-01-31 19:57 ` Rajat Jain
2022-02-02 2:05 ` Rajat Jain
2022-01-28 9:55 ` Jean-Philippe Brucker
2022-01-25 14:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACK8Z6GCPU8ZYQgwCJ5jWJ5NLQM3y+g6Ry=59-oVV3CHGe_8Aw@mail.gmail.com' \
--to=rajatja@google.com \
--cc=bhelgaas@google.com \
--cc=dtor@google.com \
--cc=jsbarnes@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rajatxjain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).