From: Zhenzhong Duan <zhenzhong.duan@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 1/2] PCI: export pci_match_device()
Date: Mon, 26 Oct 2020 10:52:10 +0800 [thread overview]
Message-ID: <CAFH1YnNQ5fL3TFQg_UqcFH6-fgmR8ZN9WkFUF9ZWNtb8k6zvvA@mail.gmail.com> (raw)
In-Reply-To: <20201022152148.GA23673@infradead.org>
On Thu, Oct 22, 2020 at 11:21 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Oct 21, 2020 at 04:10:29PM +0800, Zhenzhong Duan wrote:
> > pci_match_id() is deprecated as it doesn't catch any dynamic ids that
> > a driver might want to check for.
> >
> > Export pci_match_device() as a replacement which supports both dynamic
> > and static ids.
>
> You don't actually seems to add any user outside of the PCI core,
> so I think you only need to drop the static specifier and add a
> prototype.
Thanks for review, will do it. I'll combine the two patches into one
if no need to export.
prev parent reply other threads:[~2020-10-26 2:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 8:10 [PATCH 1/2] PCI: export pci_match_device() Zhenzhong Duan
2020-10-21 8:10 ` [PATCH 2/2] PCI: add support for dynamic ID when checking for duplicate IDs Zhenzhong Duan
2020-10-22 15:21 ` [PATCH 1/2] PCI: export pci_match_device() Christoph Hellwig
2020-10-26 2:52 ` Zhenzhong Duan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFH1YnNQ5fL3TFQg_UqcFH6-fgmR8ZN9WkFUF9ZWNtb8k6zvvA@mail.gmail.com \
--to=zhenzhong.duan@gmail.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).