From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Lukas Wunner <lukas@wunner.de>,
Bjorn Helgaas <helgaas@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
kedar.a.dongre@intel.com, Linux PCI <linux-pci@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] PCI: Blacklist power management of Gigabyte X299 DESIGNARE EX PCIe ports
Date: Thu, 20 Dec 2018 11:23:07 +0100 [thread overview]
Message-ID: <CAJZ5v0hZFY=TyGcP26dOGfGw4NAOaHkE4wjLTjsKUOFg7iCd2Q@mail.gmail.com> (raw)
In-Reply-To: <20181220100642.GY2469@lahna.fi.intel.com>
On Thu, Dec 20, 2018 at 11:06 AM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Wed, Dec 19, 2018 at 06:09:15PM +0100, Lukas Wunner wrote:
> > > I think better example where this fails is normal Thunderbolt device
> > > (not host) which includes PCIe switch and there is an PCIe endpoint, say
> > > network interface connected to one of the downstream ports. That
> > > downstream port has "Slot implemented" set but is not hotplug capable.
> > >
> > > So the device would work correctly but if you take the recent "Runtime
> > > D3, RTD3" system such as Lenovo Carbon X1 6th gen it keeps the whole
> > > PCIe hierarchy from entering D3cold. I would rather not to break that ;-)
> >
> > Yeah but as you say, those are Downstream Ports. What if you constrain
> > it to Root Ports?
>
> Yes, that could work. I did not test it yet, though. Thinking this bit
> further maybe we can contstrain it to ports that have slot implemented
> set and have an ACPI companion instead of just root ports? Point being
> that ports without ACPI companion could not possibly get ACPI Notify()
> either.
I like this idea. We can basically assume, at least to begin with,
that ACPI companions of PCIe ports are there for a reason. That
reason very well may be to provide a way to handle notifications.
prev parent reply other threads:[~2018-12-20 10:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 11:20 [PATCH] PCI: Blacklist power management of Gigabyte X299 DESIGNARE EX PCIe ports Mika Westerberg
2018-12-04 17:55 ` Rafael J. Wysocki
2018-12-04 18:34 ` Mika Westerberg
2018-12-04 20:40 ` Lukas Wunner
2018-12-05 9:20 ` Mika Westerberg
2018-12-05 9:48 ` Lukas Wunner
2018-12-05 10:40 ` Mika Westerberg
2018-12-05 13:22 ` Lukas Wunner
2018-12-05 13:46 ` Mika Westerberg
2018-12-14 9:24 ` Mika Westerberg
2018-12-17 20:28 ` Bjorn Helgaas
2018-12-18 8:55 ` Mika Westerberg
2018-12-18 20:58 ` Bjorn Helgaas
2018-12-19 13:23 ` Mika Westerberg
2018-12-19 14:45 ` Bjorn Helgaas
2018-12-19 15:15 ` Mika Westerberg
2018-12-19 17:09 ` Lukas Wunner
2018-12-20 10:06 ` Mika Westerberg
2018-12-20 10:23 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0hZFY=TyGcP26dOGfGw4NAOaHkE4wjLTjsKUOFg7iCd2Q@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=helgaas@kernel.org \
--cc=kedar.a.dongre@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).