From: Rob Herring <robh@kernel.org>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: PCI <linux-pci@vger.kernel.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Sekhar Nori" <nsekhar@ti.com>
Subject: Re: [PATCH 1/2] PCI: dra7xx: Fix link removal on probe error
Date: Tue, 14 Dec 2021 16:42:53 -0600 [thread overview]
Message-ID: <CAL_Jsq+GQTcx1EGKHug2ZcDZufrKM-4k6PB0vQeTCTG42MHzvA@mail.gmail.com> (raw)
In-Reply-To: <20211214221450.589884-1-luca@lucaceresoli.net>
On Tue, Dec 14, 2021 at 4:15 PM Luca Ceresoli <luca@lucaceresoli.net> wrote:
>
> If a devm_phy_get() calls fails with phy_count==N (N > 0), then N links
> have already been added by device_link_add() and won't be deleted by
> device_link_del() because the code calls 'return' and not 'goto err_link'.
>
> Fix in a very simple way by doing all the devm_phy_get() calls before all
> the device_link_add() calls.
>
> Fixes: 7a4db656a635 ("PCI: dra7xx: Create functional dependency between PCIe and PHY")
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> drivers/pci/controller/dwc/pci-dra7xx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index f7f1490e7beb..2ccc53869e13 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -757,7 +757,9 @@ static int dra7xx_pcie_probe(struct platform_device *pdev)
> phy[i] = devm_phy_get(dev, name);
> if (IS_ERR(phy[i]))
> return PTR_ERR(phy[i]);
> + }
>
> + for (i = 0; i < phy_count; i++) {
> link[i] = device_link_add(dev, &phy[i]->dev, DL_FLAG_STATELESS);
I think this should happen automatically now with fw_devlink being
enabled by default. Can you try?
> if (!link[i]) {
> ret = -EINVAL;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-12-14 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 22:14 [PATCH 1/2] PCI: dra7xx: Fix link removal on probe error Luca Ceresoli
2021-12-14 22:14 ` [PATCH 2/2] PCI: dra7xx: Fix clk disabling in some error paths Luca Ceresoli
2021-12-14 22:42 ` Rob Herring [this message]
2021-12-16 9:08 ` [PATCH 1/2] PCI: dra7xx: Fix link removal on probe error Luca Ceresoli
2022-01-11 10:35 ` Luca Ceresoli
2022-01-15 16:02 ` Rob Herring
2022-05-11 16:41 ` Lorenzo Pieralisi
2022-05-12 14:07 ` Luca Ceresoli
2022-05-14 3:46 ` Saravana Kannan
2022-05-17 7:32 ` Luca Ceresoli
2022-05-19 20:25 ` Saravana Kannan
2022-05-23 13:28 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+GQTcx1EGKHug2ZcDZufrKM-4k6PB0vQeTCTG42MHzvA@mail.gmail.com \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=luca@lucaceresoli.net \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).