linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, vidyas@nvidia.com,
	mmaddireddy@nvidia.com
Subject: Re: [PATCH V3 1/2] dt-bindings: PCI: tegra234: Add ECAM support
Date: Tue, 15 Nov 2022 12:00:09 -0600	[thread overview]
Message-ID: <CAL_Jsq+HWqLLk5dwYxNc0sKuiguT1DeTSFke+GSML5UACD=yFA@mail.gmail.com> (raw)
In-Reply-To: <f8148686-796f-62a6-e424-733966f7db0b@nvidia.com>

On Tue, Nov 15, 2022 at 10:03 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>
>
> On 15/11/2022 02:01, Rob Herring wrote:
> > On Mon, Nov 14, 2022 at 03:53:32PM +0000, Jon Hunter wrote:
> >> From: Vidya Sagar <vidyas@nvidia.com>
> >>
> >> Add support for ECAM aperture that is only supported for Tegra234
> >> devices.
> >>
> >> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> >> Co-developed-by: Jon Hunter <jonathanh@nvidia.com>
> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> >> ---
> >> Changes since V2:
> >> - Avoid duplication of reg items and reg-names
> >> Changes since V1:
> >> - Restricted the ECAM aperture to only Tegra234 devices that support it.
> >>
> >>   .../bindings/pci/nvidia,tegra194-pcie.yaml    | 34 +++++++++++++++++--
> >>   .../devicetree/bindings/pci/snps,dw-pcie.yaml |  2 +-
> >>   2 files changed, 33 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> >> index 75da3e8eecb9..fe81d52c7277 100644
> >> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> >> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> >> @@ -27,6 +27,7 @@ properties:
> >>         - nvidia,tegra234-pcie
> >>
> >>     reg:
> >> +    minItems: 4
> >>       items:
> >>         - description: controller's application logic registers
> >>         - description: configuration registers
> >> @@ -35,13 +36,16 @@ properties:
> >>             available for software access.
> >>         - description: aperture where the Root Port's own configuration
> >>             registers are available.
> >> +      - description: aperture to access the configuration space through ECAM.
> >>
> >>     reg-names:
> >> +    minItems: 4
> >>       items:
> >>         - const: appl
> >>         - const: config
> >>         - const: atu_dma
> >>         - const: dbi
> >> +      - const: ecam
> >
> > Wouldn't this be mutually exclusive with 'config'? 'config' is not
> > really h/w, but an just an iATU window typically.
>
> Yes that is true, however, I was chatting with Sagar and we really need
> both ranges to be defined.
>
> > Where's the driver change to use this?
>
> For Linux there is not one. However, we need this for our port of the
> EDK2 bootloader [0] that parses device-tree and can support booting
> Linux with either device-tree or ACPI. We wanted to have a common
> device-tree we can use for EDK2 and Linux.

Ok, makes sense.

Acked-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2022-11-15 18:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 15:53 [PATCH V3 0/2] Add ECAM aperture for Tegra234 Jon Hunter
2022-11-14 15:53 ` [PATCH V3 1/2] dt-bindings: PCI: tegra234: Add ECAM support Jon Hunter
2022-11-14 16:41   ` Krzysztof Kozlowski
2022-11-15  2:01   ` Rob Herring
2022-11-15 16:02     ` Jon Hunter
2022-11-15 18:00       ` Rob Herring [this message]
2022-11-17 21:38   ` Thierry Reding
2022-12-05 23:41     ` Rob Herring
2022-12-06 16:44       ` Thierry Reding
2022-12-06 21:14         ` Rob Herring
2022-12-07 10:21           ` Thierry Reding
2022-12-09 10:17           ` Serge Semin
2022-12-09 14:29             ` Rob Herring
2022-12-11 17:16               ` Serge Semin
2022-11-14 15:53 ` [PATCH V3 2/2] arm64: tegra: Add ECAM aperture info for all the PCIe controllers Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_Jsq+HWqLLk5dwYxNc0sKuiguT1DeTSFke+GSML5UACD=yFA@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mmaddireddy@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).