linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Sergey Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Jon Hunter <jonathanh@nvidia.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, vidyas@nvidia.com,
	mmaddireddy@nvidia.com
Subject: Re: [PATCH V3 1/2] dt-bindings: PCI: tegra234: Add ECAM support
Date: Mon, 5 Dec 2022 17:41:55 -0600	[thread overview]
Message-ID: <CAL_JsqKpyn=mWXv4tuS4U8AahNPkL6hpNQCfyRdf9bDY1EqSJg@mail.gmail.com> (raw)
In-Reply-To: <Y3ap1o2SbNvFw8Vd@orome>

On Thu, Nov 17, 2022 at 3:38 PM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Mon, Nov 14, 2022 at 03:53:32PM +0000, Jon Hunter wrote:
> > From: Vidya Sagar <vidyas@nvidia.com>
> >
> > Add support for ECAM aperture that is only supported for Tegra234
> > devices.
> >
> > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > Co-developed-by: Jon Hunter <jonathanh@nvidia.com>
> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> > ---
> > Changes since V2:
> > - Avoid duplication of reg items and reg-names
> > Changes since V1:
> > - Restricted the ECAM aperture to only Tegra234 devices that support it.
> >
> >  .../bindings/pci/nvidia,tegra194-pcie.yaml    | 34 +++++++++++++++++--
> >  .../devicetree/bindings/pci/snps,dw-pcie.yaml |  2 +-
> >  2 files changed, 33 insertions(+), 3 deletions(-)
>
> Both patches applied now.

linux-next now fails with this. I suspect it is due to Sergey's
changes to the DWC schema.

/builds/robherring/linux-dt/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.example.dtb:
pcie@14160000: reg-names:4: 'oneOf' conditional failed, one must be
fixed:
        'dbi' was expected
        'dbi2' was expected
        'ecam' is not one of ['elbi', 'app']
        'atu' was expected
        'dma' was expected
        'phy' was expected
        'config' was expected
        /builds/robherring/linux-dt/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.example.dtb:
pcie@14160000: reg-names:4: 'oneOf' conditional failed, one must be
fixed:
                'ecam' is not one of ['apb', 'mgmt', 'link', 'ulreg', 'appl']
                'ecam' is not one of ['atu_dma']
                'ecam' is not one of ['smu', 'mpu']
        From schema:
/builds/robherring/linux-dt/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml

  reply	other threads:[~2022-12-05 23:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 15:53 [PATCH V3 0/2] Add ECAM aperture for Tegra234 Jon Hunter
2022-11-14 15:53 ` [PATCH V3 1/2] dt-bindings: PCI: tegra234: Add ECAM support Jon Hunter
2022-11-14 16:41   ` Krzysztof Kozlowski
2022-11-15  2:01   ` Rob Herring
2022-11-15 16:02     ` Jon Hunter
2022-11-15 18:00       ` Rob Herring
2022-11-17 21:38   ` Thierry Reding
2022-12-05 23:41     ` Rob Herring [this message]
2022-12-06 16:44       ` Thierry Reding
2022-12-06 21:14         ` Rob Herring
2022-12-07 10:21           ` Thierry Reding
2022-12-09 10:17           ` Serge Semin
2022-12-09 14:29             ` Rob Herring
2022-12-11 17:16               ` Serge Semin
2022-11-14 15:53 ` [PATCH V3 2/2] arm64: tegra: Add ECAM aperture info for all the PCIe controllers Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_JsqKpyn=mWXv4tuS4U8AahNPkL6hpNQCfyRdf9bDY1EqSJg@mail.gmail.com' \
    --to=robh+dt@kernel.org \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mmaddireddy@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).