* [PATCH -next] PCI: dwc: Remove set but not used variable
@ 2020-09-17 7:17 Liu Shixin
2020-09-17 15:05 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Liu Shixin @ 2020-09-17 7:17 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas
Cc: linux-omap, linux-pci, linux-arm-kernel, linux-kernel, Liu Shixin
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/pci/controller/dwc/pci-dra7xx.c: In function 'dra7xx_pcie_establish_link':
drivers/pci/controller/dwc/pci-dra7xx.c:142:6: warning: unused variable 'exp_cap_off'
[-Wunused-variable]
After 3af45d34d30c ("PCI: dwc: Centralize link gen setting"), variable 'exp_cap_off'
is never used. Remove it to avoid build warning.
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
drivers/pci/controller/dwc/pci-dra7xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index 69cd43f74260..7bac7c54b2aa 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -139,7 +139,7 @@ static int dra7xx_pcie_establish_link(struct dw_pcie *pci)
struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
struct device *dev = pci->dev;
u32 reg;
- u32 exp_cap_off = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
+ dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
if (dw_pcie_link_up(pci)) {
dev_err(dev, "link is already up\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] PCI: dwc: Remove set but not used variable
2020-09-17 7:17 [PATCH -next] PCI: dwc: Remove set but not used variable Liu Shixin
@ 2020-09-17 15:05 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-09-17 15:05 UTC (permalink / raw)
To: Liu Shixin
Cc: Kishon Vijay Abraham I, Lorenzo Pieralisi, Bjorn Helgaas,
linux-omap, PCI, linux-arm-kernel, linux-kernel
On Thu, Sep 17, 2020 at 12:55 AM Liu Shixin <liushixin2@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/pci/controller/dwc/pci-dra7xx.c: In function 'dra7xx_pcie_establish_link':
> drivers/pci/controller/dwc/pci-dra7xx.c:142:6: warning: unused variable 'exp_cap_off'
> [-Wunused-variable]
>
> After 3af45d34d30c ("PCI: dwc: Centralize link gen setting"), variable 'exp_cap_off'
> is never used. Remove it to avoid build warning.
Already fixed in next.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-17 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 7:17 [PATCH -next] PCI: dwc: Remove set but not used variable Liu Shixin
2020-09-17 15:05 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).