linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: imx6: Add PHY reference clock source support
@ 2017-12-27 10:05 Ilya Ledvich
  2017-12-28 10:05 ` Richard Zhu
  0 siblings, 1 reply; 10+ messages in thread
From: Ilya Ledvich @ 2017-12-27 10:05 UTC (permalink / raw)
  To: Richard Zhu, Lucas Stach
  Cc: Bjorn Helgaas, linux-pci, Ilya Ledvich, linux-kernel, linux-arm-kernel

i.MX7D variant of the IP can use either Crystal Oscillator input
or internal clock input as a Reference Clock input for PCIe PHY.
Add support for an optional property 'pcie-phy-refclk-internal'.
If present then an internal clock input is used as PCIe PHY
reference clock source. By default an external oscillator input
is still used.

Verified on Compulab SBC-iMX7 Single Board Computer.

Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 5 +++++
 drivers/pci/dwc/pci-imx6.c                               | 8 +++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 7b1e48b..f9cf11e 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
@@ -50,6 +50,11 @@ Additional required properties for imx7d-pcie:
 	       - "pciephy"
 	       - "apps"
 
+Additional optional properties for imx7d-pcie:
+- pcie-phy-refclk-internal: If present then an internal PLL input is used as
+  PCIe PHY reference clock source. By default an external ocsillator input
+  is used.
+
 Example:
 
 	pcie@0x01000000 {
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index b734835..a616192 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -61,6 +61,7 @@ struct imx6_pcie {
 	u32			tx_swing_low;
 	int			link_gen;
 	struct regulator	*vpcie;
+	bool			pciephy_refclk_sel;
 };
 
 /* Parameters for the waiting for PCIe PHY PLL to lock on i.MX7 */
@@ -474,7 +475,9 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
 	switch (imx6_pcie->variant) {
 	case IMX7D:
 		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
-				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0);
+				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
+				   imx6_pcie->pciephy_refclk_sel ?
+				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL : 0);
 		break;
 	case IMX6SX:
 		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
@@ -840,6 +843,9 @@ static int imx6_pcie_probe(struct platform_device *pdev)
 		imx6_pcie->vpcie = NULL;
 	}
 
+	imx6_pcie->pciephy_refclk_sel =
+		of_property_read_bool(node, "pcie-phy-refclk-internal");
+
 	platform_set_drvdata(pdev, imx6_pcie);
 
 	ret = imx6_add_pcie_port(imx6_pcie, pdev);
-- 
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* RE: [PATCH] PCI: imx6: Add PHY reference clock source support
  2017-12-27 10:05 [PATCH] PCI: imx6: Add PHY reference clock source support Ilya Ledvich
@ 2017-12-28 10:05 ` Richard Zhu
  2017-12-31  8:31   ` [PATCH v2] " Ilya Ledvich
  0 siblings, 1 reply; 10+ messages in thread
From: Richard Zhu @ 2017-12-28 10:05 UTC (permalink / raw)
  To: Ilya Ledvich, Lucas Stach
  Cc: Bjorn Helgaas, linux-pci, linux-arm-kernel, linux-kernel

Hi Ilya:
I think the "ocsillator" in the binding document should be oscillator.
Thanks.

Best Regards
Richard

Best Regards
hongxing zhu
Linux BSP team
Office: 86-21-28937189
Email: hongxing.zhu@nxp.com


-----Original Message-----
From: Ilya Ledvich [mailto:ilya@compulab.co.il]=20
Sent: Wednesday, December 27, 2017 6:06 PM
To: Richard Zhu <hongxing.zhu@nxp.com>; Lucas Stach <l.stach@pengutronix.de=
>
Cc: Bjorn Helgaas <bhelgaas@google.com>; linux-pci@vger.kernel.org; linux-a=
rm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Ilya Ledvich <=
ilya@compulab.co.il>
Subject: [PATCH] PCI: imx6: Add PHY reference clock source support

i.MX7D variant of the IP can use either Crystal Oscillator input or interna=
l clock input as a Reference Clock input for PCIe PHY.
Add support for an optional property 'pcie-phy-refclk-internal'.
If present then an internal clock input is used as PCIe PHY reference clock=
 source. By default an external oscillator input is still used.

Verified on Compulab SBC-iMX7 Single Board Computer.

Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 5 +++++
 drivers/pci/dwc/pci-imx6.c                               | 8 +++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Doc=
umentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 7b1e48b..f9cf11e 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
@@ -50,6 +50,11 @@ Additional required properties for imx7d-pcie:
 	       - "pciephy"
 	       - "apps"
=20
+Additional optional properties for imx7d-pcie:
+- pcie-phy-refclk-internal: If present then an internal PLL input is=20
+used as
+  PCIe PHY reference clock source. By default an external ocsillator=20
+input
+  is used.
+
 Example:
=20
 	pcie@0x01000000 {
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c index =
b734835..a616192 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -61,6 +61,7 @@ struct imx6_pcie {
 	u32			tx_swing_low;
 	int			link_gen;
 	struct regulator	*vpcie;
+	bool			pciephy_refclk_sel;
 };
=20
 /* Parameters for the waiting for PCIe PHY PLL to lock on i.MX7 */ @@ -474=
,7 +475,9 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
 	switch (imx6_pcie->variant) {
 	case IMX7D:
 		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
-				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0);
+				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
+				   imx6_pcie->pciephy_refclk_sel ?
+				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL : 0);
 		break;
 	case IMX6SX:
 		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, @@ -840,6 +843,9=
 @@ static int imx6_pcie_probe(struct platform_device *pdev)
 		imx6_pcie->vpcie =3D NULL;
 	}
=20
+	imx6_pcie->pciephy_refclk_sel =3D
+		of_property_read_bool(node, "pcie-phy-refclk-internal");
+
 	platform_set_drvdata(pdev, imx6_pcie);
=20
 	ret =3D imx6_add_pcie_port(imx6_pcie, pdev);
--
1.9.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2] PCI: imx6: Add PHY reference clock source support
  2017-12-28 10:05 ` Richard Zhu
@ 2017-12-31  8:31   ` Ilya Ledvich
  2018-01-02 22:54     ` Fabio Estevam
  0 siblings, 1 reply; 10+ messages in thread
From: Ilya Ledvich @ 2017-12-31  8:31 UTC (permalink / raw)
  To: Richard Zhu, Lucas Stach
  Cc: Bjorn Helgaas, linux-pci, linux-arm-kernel, linux-kernel, Ilya Ledvich

i.MX7D variant of the IP can use either Crystal Oscillator input
or internal clock input as a Reference Clock input for PCIe PHY.
Add support for an optional property 'pcie-phy-refclk-internal'.
If present then an internal clock input is used as PCIe PHY
reference clock source. By default an external oscillator input
is still used.

Verified on Compulab SBC-iMX7 Single Board Computer.

Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 5 +++++
 drivers/pci/dwc/pci-imx6.c                               | 8 +++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 7b1e48b..581bc09 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
@@ -50,6 +50,11 @@ Additional required properties for imx7d-pcie:
 	       - "pciephy"
 	       - "apps"
 
+Additional optional properties for imx7d-pcie:
+- pcie-phy-refclk-internal: If present then an internal PLL input is used as
+  PCIe PHY reference clock source. By default an external oscillator input
+  is used.
+
 Example:
 
 	pcie@0x01000000 {
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index b734835..a616192 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -61,6 +61,7 @@ struct imx6_pcie {
 	u32			tx_swing_low;
 	int			link_gen;
 	struct regulator	*vpcie;
+	bool			pciephy_refclk_sel;
 };
 
 /* Parameters for the waiting for PCIe PHY PLL to lock on i.MX7 */
@@ -474,7 +475,9 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
 	switch (imx6_pcie->variant) {
 	case IMX7D:
 		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
-				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0);
+				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
+				   imx6_pcie->pciephy_refclk_sel ?
+				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL : 0);
 		break;
 	case IMX6SX:
 		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
@@ -840,6 +843,9 @@ static int imx6_pcie_probe(struct platform_device *pdev)
 		imx6_pcie->vpcie = NULL;
 	}
 
+	imx6_pcie->pciephy_refclk_sel =
+		of_property_read_bool(node, "pcie-phy-refclk-internal");
+
 	platform_set_drvdata(pdev, imx6_pcie);
 
 	ret = imx6_add_pcie_port(imx6_pcie, pdev);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] PCI: imx6: Add PHY reference clock source support
  2017-12-31  8:31   ` [PATCH v2] " Ilya Ledvich
@ 2018-01-02 22:54     ` Fabio Estevam
  2018-01-04 13:52       ` [PATCH v3] " Ilya Ledvich
  0 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2018-01-02 22:54 UTC (permalink / raw)
  To: Ilya Ledvich
  Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Richard Zhu, linux-pci, linux-kernel, Rob Herring, Bjorn Helgaas,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Lucas Stach

Hi Ilya,

+ Rob and dt list

On Sun, Dec 31, 2017 at 6:31 AM, Ilya Ledvich <ilya@compulab.co.il> wrote:
> i.MX7D variant of the IP can use either Crystal Oscillator input
> or internal clock input as a Reference Clock input for PCIe PHY.
> Add support for an optional property 'pcie-phy-refclk-internal'.
> If present then an internal clock input is used as PCIe PHY
> reference clock source. By default an external oscillator input
> is still used.
>
> Verified on Compulab SBC-iMX7 Single Board Computer.
>
> Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 5 +++++
>  drivers/pci/dwc/pci-imx6.c                               | 8 +++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index 7b1e48b..581bc09 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -50,6 +50,11 @@ Additional required properties for imx7d-pcie:
>                - "pciephy"
>                - "apps"
>
> +Additional optional properties for imx7d-pcie:
> +- pcie-phy-refclk-internal: If present then an internal PLL input is used as
> +  PCIe PHY reference clock source. By default an external oscillator input
> +  is used.

Should this contain the vendor prefix, like fsl,pcie-phy-refclk-internal ?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v3] PCI: imx6: Add PHY reference clock source support
  2018-01-02 22:54     ` Fabio Estevam
@ 2018-01-04 13:52       ` Ilya Ledvich
  2018-01-08  3:13         ` Richard Zhu
  2018-01-08 10:43         ` Lucas Stach
  0 siblings, 2 replies; 10+ messages in thread
From: Ilya Ledvich @ 2018-01-04 13:52 UTC (permalink / raw)
  To: Richard Zhu, Lucas Stach
  Cc: Bjorn Helgaas, Rob Herring, linux-pci, linux-arm-kernel,
	linux-kernel, devicetree, Ilya Ledvich

i.MX7D variant of the IP can use either Crystal Oscillator input
or internal clock input as a Reference Clock input for PCIe PHY.
Add support for an optional property 'fsl,pcie-phy-refclk-internal'.
If present then an internal clock input is used as PCIe PHY
reference clock source. By default an external oscillator input
is still used.

Verified on Compulab SBC-iMX7 Single Board Computer.

Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
---
changes since V2:
	add a vendor prefix 'fsl' to a new property

 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 5 +++++
 drivers/pci/dwc/pci-imx6.c                               | 8 +++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
index 7b1e48b..1591a6a 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
@@ -50,6 +50,11 @@ Additional required properties for imx7d-pcie:
 	       - "pciephy"
 	       - "apps"
 
+Additional optional properties for imx7d-pcie:
+- fsl,pcie-phy-refclk-internal: If present then an internal PLL input is used
+  as PCIe PHY reference clock source. By default an external oscillator input
+  is used.
+
 Example:
 
 	pcie@0x01000000 {
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index b734835..36812d3 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -61,6 +61,7 @@ struct imx6_pcie {
 	u32			tx_swing_low;
 	int			link_gen;
 	struct regulator	*vpcie;
+	bool			pciephy_refclk_sel;
 };
 
 /* Parameters for the waiting for PCIe PHY PLL to lock on i.MX7 */
@@ -474,7 +475,9 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
 	switch (imx6_pcie->variant) {
 	case IMX7D:
 		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
-				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0);
+				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
+				   imx6_pcie->pciephy_refclk_sel ?
+				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL : 0);
 		break;
 	case IMX6SX:
 		regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
@@ -840,6 +843,9 @@ static int imx6_pcie_probe(struct platform_device *pdev)
 		imx6_pcie->vpcie = NULL;
 	}
 
+	imx6_pcie->pciephy_refclk_sel =
+		of_property_read_bool(node, "fsl,pcie-phy-refclk-internal");
+
 	platform_set_drvdata(pdev, imx6_pcie);
 
 	ret = imx6_add_pcie_port(imx6_pcie, pdev);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* RE: [PATCH v3] PCI: imx6: Add PHY reference clock source support
  2018-01-04 13:52       ` [PATCH v3] " Ilya Ledvich
@ 2018-01-08  3:13         ` Richard Zhu
  2018-01-08 10:43         ` Lucas Stach
  1 sibling, 0 replies; 10+ messages in thread
From: Richard Zhu @ 2018-01-08  3:13 UTC (permalink / raw)
  To: Ilya Ledvich, Lucas Stach
  Cc: devicetree, linux-pci, linux-kernel, Rob Herring, Bjorn Helgaas,
	linux-arm-kernel



Best Regards
hongxing zhu
Linux BSP team
Office: 86-21-28937189
Email: hongxing.zhu@nxp.com


> -----Original Message-----
> From: Ilya Ledvich [mailto:ilya@compulab.co.il]
> Sent: Thursday, January 04, 2018 9:53 PM
> To: Richard Zhu <hongxing.zhu@nxp.com>; Lucas Stach
> <l.stach@pengutronix.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>; Rob Herring
> <robh+dt@kernel.org>; linux-pci@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; Ilya Ledvich <ilya@compulab.co.il>
> Subject: [PATCH v3] PCI: imx6: Add PHY reference clock source support
> 
> i.MX7D variant of the IP can use either Crystal Oscillator input or internal
> clock input as a Reference Clock input for PCIe PHY.
> Add support for an optional property 'fsl,pcie-phy-refclk-internal'.
> If present then an internal clock input is used as PCIe PHY reference clock
> source. By default an external oscillator input is still used.
> 
> Verified on Compulab SBC-iMX7 Single Board Computer.
> 
> Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
Acked-by: Richard Zhu <hongxing.zhu@nxp.com >

Thanks.
Best Regards
Richard

> ---
> changes since V2:
> 	add a vendor prefix 'fsl' to a new property
> 
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 5 +++++
>  drivers/pci/dwc/pci-imx6.c                               | 8 +++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index 7b1e48b..1591a6a 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -50,6 +50,11 @@ Additional required properties for imx7d-pcie:
>  	       - "pciephy"
>  	       - "apps"
> 
> +Additional optional properties for imx7d-pcie:
> +- fsl,pcie-phy-refclk-internal: If present then an internal PLL input
> +is used
> +  as PCIe PHY reference clock source. By default an external oscillator
> +input
> +  is used.
> +
>  Example:
> 
>  	pcie@0x01000000 {
> diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c index
> b734835..36812d3 100644
> --- a/drivers/pci/dwc/pci-imx6.c
> +++ b/drivers/pci/dwc/pci-imx6.c
> @@ -61,6 +61,7 @@ struct imx6_pcie {
>  	u32			tx_swing_low;
>  	int			link_gen;
>  	struct regulator	*vpcie;
> +	bool			pciephy_refclk_sel;
>  };
> 
>  /* Parameters for the waiting for PCIe PHY PLL to lock on i.MX7 */ @@ -
> 474,7 +475,9 @@ static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
>  	switch (imx6_pcie->variant) {
>  	case IMX7D:
>  		regmap_update_bits(imx6_pcie->iomuxc_gpr,
> IOMUXC_GPR12,
> -				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0);
> +				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
> +				   imx6_pcie->pciephy_refclk_sel ?
> +				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL : 0);
>  		break;
>  	case IMX6SX:
>  		regmap_update_bits(imx6_pcie->iomuxc_gpr,
> IOMUXC_GPR12, @@ -840,6 +843,9 @@ static int imx6_pcie_probe(struct
> platform_device *pdev)
>  		imx6_pcie->vpcie = NULL;
>  	}
> 
> +	imx6_pcie->pciephy_refclk_sel =
> +		of_property_read_bool(node, "fsl,pcie-phy-refclk-internal");
> +
>  	platform_set_drvdata(pdev, imx6_pcie);
> 
>  	ret = imx6_add_pcie_port(imx6_pcie, pdev);
> --
> 1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3] PCI: imx6: Add PHY reference clock source support
  2018-01-04 13:52       ` [PATCH v3] " Ilya Ledvich
  2018-01-08  3:13         ` Richard Zhu
@ 2018-01-08 10:43         ` Lucas Stach
  2018-01-10 13:43           ` Ilya Ledvich
  1 sibling, 1 reply; 10+ messages in thread
From: Lucas Stach @ 2018-01-08 10:43 UTC (permalink / raw)
  To: Ilya Ledvich, Richard Zhu
  Cc: devicetree, linux-pci, linux-kernel, Rob Herring, Bjorn Helgaas,
	linux-arm-kernel

QW0gRG9ubmVyc3RhZywgZGVuIDA0LjAxLjIwMTgsIDE1OjUyICswMjAwIHNjaHJpZWIgSWx5YSBM
ZWR2aWNoOgo+IGkuTVg3RCB2YXJpYW50IG9mIHRoZSBJUCBjYW4gdXNlIGVpdGhlciBDcnlzdGFs
IE9zY2lsbGF0b3IgaW5wdXQKPiBvciBpbnRlcm5hbCBjbG9jayBpbnB1dCBhcyBhIFJlZmVyZW5j
ZSBDbG9jayBpbnB1dCBmb3IgUENJZSBQSFkuCj4gQWRkIHN1cHBvcnQgZm9yIGFuIG9wdGlvbmFs
IHByb3BlcnR5ICdmc2wscGNpZS1waHktcmVmY2xrLWludGVybmFsJy4KPiBJZiBwcmVzZW50IHRo
ZW4gYW4gaW50ZXJuYWwgY2xvY2sgaW5wdXQgaXMgdXNlZCBhcyBQQ0llIFBIWQo+IHJlZmVyZW5j
ZSBjbG9jayBzb3VyY2UuIEJ5IGRlZmF1bHQgYW4gZXh0ZXJuYWwgb3NjaWxsYXRvciBpbnB1dAo+
IGlzIHN0aWxsIHVzZWQuCj4gCj4gVmVyaWZpZWQgb24gQ29tcHVsYWIgU0JDLWlNWDcgU2luZ2xl
IEJvYXJkIENvbXB1dGVyLgoKU29ycnkgdG8gZ2V0IGluIGxhdGUgaGVyZSwgYnV0IEkgd291bGQg
cmF0aGVyIGhhdmUgdGhlIGV4dGVybmFsIGNsb2NrCmlucHV0IG1vZGVsZWQgYXMgYSByZWFsIGNs
b2NrIGFuZCBvbmx5IHVzZSB0aGUgaW50ZXJuYWwgY2xvY2sgaWYgdGhhdAppc24ndCBwcmVzZW50
LgoKQXJlIHlvdSBldmVuIHN1cmUgdGhhdCB0aGUgaS5NWDcgY2xvY2sgeW91IG1lbnRpb24gaXNu
J3QgdGhlIGFscmVhZHkKZG9jdW1lbnRlZCAicGNpZV9idXMiIGNsb2NrPyBUaGlzIG9uZSBpcyBh
bHNvIGFsbG93ZWQgdG8gYmUgc291cmNlZApleHRlcm5hbGx5IG9uIHRoZSBpLk1YNi4KClJlZ2Fy
ZHMsCkx1Y2FzCgo+IFNpZ25lZC1vZmYtYnk6IElseWEgTGVkdmljaCA8aWx5YUBjb21wdWxhYi5j
by5pbD4KPiAtLS0KPiBjaGFuZ2VzIHNpbmNlIFYyOgo+IAlhZGQgYSB2ZW5kb3IgcHJlZml4ICdm
c2wnIHRvIGEgbmV3IHByb3BlcnR5Cj4gCj4gwqBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu
ZGluZ3MvcGNpL2ZzbCxpbXg2cS1wY2llLnR4dCB8IDUgKysrKysKPiDCoGRyaXZlcnMvcGNpL2R3
Yy9wY2ktaW14Ni5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqB8IDgKPiArKysrKysrLQo+IMKgMiBmaWxlcyBjaGFuZ2VkLCAxMiBp
bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRp
b24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvZnNsLGlteDZxLXBjaWUudHh0IAo+IGIvRG9jdW1l
bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQKPiBpbmRl
eCA3YjFlNDhiLi4xNTkxYTZhIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl
ZS9iaW5kaW5ncy9wY2kvZnNsLGlteDZxLXBjaWUudHh0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9k
ZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQKPiBAQCAtNTAsNiArNTAs
MTEgQEAgQWRkaXRpb25hbCByZXF1aXJlZCBwcm9wZXJ0aWVzIGZvciBpbXg3ZC1wY2llOgo+IMKg
CcKgwqDCoMKgwqDCoMKgLSAicGNpZXBoeSIKPiDCoAnCoMKgwqDCoMKgwqDCoC0gImFwcHMiCj4g
wqAKPiArQWRkaXRpb25hbCBvcHRpb25hbCBwcm9wZXJ0aWVzIGZvciBpbXg3ZC1wY2llOgo+ICst
IGZzbCxwY2llLXBoeS1yZWZjbGstaW50ZXJuYWw6IElmIHByZXNlbnQgdGhlbiBhbiBpbnRlcm5h
bCBQTEwKPiBpbnB1dCBpcyB1c2VkCj4gK8KgwqBhcyBQQ0llIFBIWSByZWZlcmVuY2UgY2xvY2sg
c291cmNlLiBCeSBkZWZhdWx0IGFuIGV4dGVybmFsCj4gb3NjaWxsYXRvciBpbnB1dAo+ICvCoMKg
aXMgdXNlZC4KPiArCj4gwqBFeGFtcGxlOgo+IMKgCj4gwqAJcGNpZUAweDAxMDAwMDAwIHsKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvZHdjL3BjaS1pbXg2LmMgYi9kcml2ZXJzL3BjaS9kd2Mv
cGNpLWlteDYuYwo+IGluZGV4IGI3MzQ4MzUuLjM2ODEyZDMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy
cy9wY2kvZHdjL3BjaS1pbXg2LmMKPiArKysgYi9kcml2ZXJzL3BjaS9kd2MvcGNpLWlteDYuYwo+
IEBAIC02MSw2ICs2MSw3IEBAIHN0cnVjdCBpbXg2X3BjaWUgewo+IMKgCXUzMgkJCXR4X3N3aW5n
X2xvdzsKPiDCoAlpbnQJCQlsaW5rX2dlbjsKPiDCoAlzdHJ1Y3QgcmVndWxhdG9yCSp2cGNpZTsK
PiArCWJvb2wJCQlwY2llcGh5X3JlZmNsa19zZWw7Cj4gwqB9Owo+IMKgCj4gwqAvKiBQYXJhbWV0
ZXJzIGZvciB0aGUgd2FpdGluZyBmb3IgUENJZSBQSFkgUExMIHRvIGxvY2sgb24gaS5NWDcgKi8K
PiBAQCAtNDc0LDcgKzQ3NSw5IEBAIHN0YXRpYyB2b2lkIGlteDZfcGNpZV9pbml0X3BoeShzdHJ1
Y3QgaW14Nl9wY2llCj4gKmlteDZfcGNpZSkKPiDCoAlzd2l0Y2ggKGlteDZfcGNpZS0+dmFyaWFu
dCkgewo+IMKgCWNhc2UgSU1YN0Q6Cj4gwqAJCXJlZ21hcF91cGRhdGVfYml0cyhpbXg2X3BjaWUt
PmlvbXV4Y19ncHIsCj4gSU9NVVhDX0dQUjEyLAo+IC0JCQkJwqDCoMKgSU1YN0RfR1BSMTJfUENJ
RV9QSFlfUkVGQ0xLX1NFTCwKPiAwKTsKPiArCQkJCcKgwqDCoElNWDdEX0dQUjEyX1BDSUVfUEhZ
X1JFRkNMS19TRUwsCj4gKwkJCQnCoMKgwqBpbXg2X3BjaWUtPnBjaWVwaHlfcmVmY2xrX3NlbCA/
Cj4gKwkJCQnCoMKgwqBJTVg3RF9HUFIxMl9QQ0lFX1BIWV9SRUZDTEtfU0VMIDoKPiAwKTsKPiDC
oAkJYnJlYWs7Cj4gwqAJY2FzZSBJTVg2U1g6Cj4gwqAJCXJlZ21hcF91cGRhdGVfYml0cyhpbXg2
X3BjaWUtPmlvbXV4Y19ncHIsCj4gSU9NVVhDX0dQUjEyLAo+IEBAIC04NDAsNiArODQzLDkgQEAg
c3RhdGljIGludCBpbXg2X3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZQo+ICpwZGV2
KQo+IMKgCQlpbXg2X3BjaWUtPnZwY2llID0gTlVMTDsKPiDCoAl9Cj4gwqAKPiArCWlteDZfcGNp
ZS0+cGNpZXBoeV9yZWZjbGtfc2VsID0KPiArCQlvZl9wcm9wZXJ0eV9yZWFkX2Jvb2wobm9kZSwg
ImZzbCxwY2llLXBoeS1yZWZjbGstCj4gaW50ZXJuYWwiKTsKPiArCj4gwqAJcGxhdGZvcm1fc2V0
X2RydmRhdGEocGRldiwgaW14Nl9wY2llKTsKPiDCoAo+IMKgCXJldCA9IGlteDZfYWRkX3BjaWVf
cG9ydChpbXg2X3BjaWUsIHBkZXYpOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl
cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt
YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3] PCI: imx6: Add PHY reference clock source support
  2018-01-08 10:43         ` Lucas Stach
@ 2018-01-10 13:43           ` Ilya Ledvich
  2018-01-15  2:19             ` Richard Zhu
  2018-03-07 11:54             ` Lorenzo Pieralisi
  0 siblings, 2 replies; 10+ messages in thread
From: Ilya Ledvich @ 2018-01-10 13:43 UTC (permalink / raw)
  To: Lucas Stach, Richard Zhu
  Cc: devicetree, linux-pci, linux-kernel, Rob Herring, Bjorn Helgaas,
	linux-arm-kernel

SGkgTHVjYXMsCgpPbiAwMS8wOC8yMDE4IDEyOjQzIFBNLCBMdWNhcyBTdGFjaCB3cm90ZToKPiBB
bSBEb25uZXJzdGFnLCBkZW4gMDQuMDEuMjAxOCwgMTU6NTIgKzAyMDAgc2NocmllYiBJbHlhIExl
ZHZpY2g6Cj4+IGkuTVg3RCB2YXJpYW50IG9mIHRoZSBJUCBjYW4gdXNlIGVpdGhlciBDcnlzdGFs
IE9zY2lsbGF0b3IgaW5wdXQKPj4gb3IgaW50ZXJuYWwgY2xvY2sgaW5wdXQgYXMgYSBSZWZlcmVu
Y2UgQ2xvY2sgaW5wdXQgZm9yIFBDSWUgUEhZLgo+PiBBZGQgc3VwcG9ydCBmb3IgYW4gb3B0aW9u
YWwgcHJvcGVydHkgJ2ZzbCxwY2llLXBoeS1yZWZjbGstaW50ZXJuYWwnLgo+PiBJZiBwcmVzZW50
IHRoZW4gYW4gaW50ZXJuYWwgY2xvY2sgaW5wdXQgaXMgdXNlZCBhcyBQQ0llIFBIWQo+PiByZWZl
cmVuY2UgY2xvY2sgc291cmNlLiBCeSBkZWZhdWx0IGFuIGV4dGVybmFsIG9zY2lsbGF0b3IgaW5w
dXQKPj4gaXMgc3RpbGwgdXNlZC4KPj4KPj4gVmVyaWZpZWQgb24gQ29tcHVsYWIgU0JDLWlNWDcg
U2luZ2xlIEJvYXJkIENvbXB1dGVyLgo+IAo+IFNvcnJ5IHRvIGdldCBpbiBsYXRlIGhlcmUsIGJ1
dCBJIHdvdWxkIHJhdGhlciBoYXZlIHRoZSBleHRlcm5hbCBjbG9jawo+IGlucHV0IG1vZGVsZWQg
YXMgYSByZWFsIGNsb2NrIGFuZCBvbmx5IHVzZSB0aGUgaW50ZXJuYWwgY2xvY2sgaWYgdGhhdAo+
IGlzbid0IHByZXNlbnQuCj4gCgpJIHRyaWVkIHRvIGZvbGxvdyB0aGUgbG9naWMgZGVzY3JpYmVk
IGluIHRoZSBpTVg3IFRSTSwgd2hlcmUgZXh0ZXJuYWwgCm9zY2lsbGF0b3IgaXMgYSBkZWZhdWx0
IG9wdGlvbi4gQWRkaXRpb25hbGx5LCB0aGUgZXh0ZXJuYWwgY2xvY2sgaW5wdXQgCm1vZGVsIHlv
dSd2ZSBzdWdnZXN0ZWQsIHJlcXVpcmVzIGFkZGl0aW9uYWwgY2hhbmdlcyBpbiB0aGUgaU1YNyBT
YWJyZVNEIApib2FyZCAoYW5kIHByb2JhYmx5IG90aGVyIGJvYXJkcyB3aGljaCB1c2UgYW4gZXh0
ZXJuYWwgaW5wdXQgdG9vKSAKZGV2aWNldHJlZSBmaWxlcy4KCj4gQXJlIHlvdSBldmVuIHN1cmUg
dGhhdCB0aGUgaS5NWDcgY2xvY2sgeW91IG1lbnRpb24gaXNuJ3QgdGhlIGFscmVhZHkKPiBkb2N1
bWVudGVkICJwY2llX2J1cyIgY2xvY2s/IFRoaXMgb25lIGlzIGFsc28gYWxsb3dlZCB0byBiZSBz
b3VyY2VkCj4gZXh0ZXJuYWxseSBvbiB0aGUgaS5NWDYuCgpUbyB0aGUgYmVzdCBvZiBteSB1bmRl
cnN0YW5kaW5nIGl0J3Mgbm90IHRoZSBwY2llX2J1cyBjbG9jaywgYnV0IEknbSAKYWJzb2x1dGVs
eSBzdXJlLiBDb3VsZCBhbnlib2R5IGZyb20gdGhlIEJTUCB0ZWFtIGd1eXMgZWxhYm9yYXRlIG9u
IHRoaXMgCmlzc3VlPyBUaGFua3MgYSBsb3QhCkJlc3QgcmVnYXJkcywKSWx5YS4KCj4+IC0tLQo+
PiBjaGFuZ2VzIHNpbmNlIFYyOgo+PiAJYWRkIGEgdmVuZG9yIHByZWZpeCAnZnNsJyB0byBhIG5l
dyBwcm9wZXJ0eQo+Pgo+PiAgwqBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNp
L2ZzbCxpbXg2cS1wY2llLnR4dCB8IDUgKysrKysKPj4gIMKgZHJpdmVycy9wY2kvZHdjL3BjaS1p
bXg2LmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoHwgOAo+PiArKysrKysrLQo+PiAgwqAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2Vy
dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4KPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24v
ZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvZnNsLGlteDZxLXBjaWUudHh0Cj4+IGIvRG9jdW1lbnRh
dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQKPj4gaW5kZXgg
N2IxZTQ4Yi4uMTU5MWE2YSAxMDA2NDQKPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl
L2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQKPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9k
ZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQKPj4gQEAgLTUwLDYgKzUw
LDExIEBAIEFkZGl0aW9uYWwgcmVxdWlyZWQgcHJvcGVydGllcyBmb3IgaW14N2QtcGNpZToKPj4g
IMKgCcKgwqDCoMKgwqDCoMKgLSAicGNpZXBoeSIKPj4gIMKgCcKgwqDCoMKgwqDCoMKgLSAiYXBw
cyIKPj4gICAKPj4gK0FkZGl0aW9uYWwgb3B0aW9uYWwgcHJvcGVydGllcyBmb3IgaW14N2QtcGNp
ZToKPj4gKy0gZnNsLHBjaWUtcGh5LXJlZmNsay1pbnRlcm5hbDogSWYgcHJlc2VudCB0aGVuIGFu
IGludGVybmFsIFBMTAo+PiBpbnB1dCBpcyB1c2VkCj4+ICvCoMKgYXMgUENJZSBQSFkgcmVmZXJl
bmNlIGNsb2NrIHNvdXJjZS4gQnkgZGVmYXVsdCBhbiBleHRlcm5hbAo+PiBvc2NpbGxhdG9yIGlu
cHV0Cj4+ICvCoMKgaXMgdXNlZC4KPj4gKwo+PiAgwqBFeGFtcGxlOgo+PiAgIAo+PiAgwqAJcGNp
ZUAweDAxMDAwMDAwIHsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2R3Yy9wY2ktaW14Ni5j
IGIvZHJpdmVycy9wY2kvZHdjL3BjaS1pbXg2LmMKPj4gaW5kZXggYjczNDgzNS4uMzY4MTJkMyAx
MDA2NDQKPj4gLS0tIGEvZHJpdmVycy9wY2kvZHdjL3BjaS1pbXg2LmMKPj4gKysrIGIvZHJpdmVy
cy9wY2kvZHdjL3BjaS1pbXg2LmMKPj4gQEAgLTYxLDYgKzYxLDcgQEAgc3RydWN0IGlteDZfcGNp
ZSB7Cj4+ICDCoAl1MzIJCQl0eF9zd2luZ19sb3c7Cj4+ICDCoAlpbnQJCQlsaW5rX2dlbjsKPj4g
IMKgCXN0cnVjdCByZWd1bGF0b3IJKnZwY2llOwo+PiArCWJvb2wJCQlwY2llcGh5X3JlZmNsa19z
ZWw7Cj4+ICDCoH07Cj4+ICAgCj4+ICDCoC8qIFBhcmFtZXRlcnMgZm9yIHRoZSB3YWl0aW5nIGZv
ciBQQ0llIFBIWSBQTEwgdG8gbG9jayBvbiBpLk1YNyAqLwo+PiBAQCAtNDc0LDcgKzQ3NSw5IEBA
IHN0YXRpYyB2b2lkIGlteDZfcGNpZV9pbml0X3BoeShzdHJ1Y3QgaW14Nl9wY2llCj4+ICppbXg2
X3BjaWUpCj4+ICDCoAlzd2l0Y2ggKGlteDZfcGNpZS0+dmFyaWFudCkgewo+PiAgwqAJY2FzZSBJ
TVg3RDoKPj4gIMKgCQlyZWdtYXBfdXBkYXRlX2JpdHMoaW14Nl9wY2llLT5pb211eGNfZ3ByLAo+
PiBJT01VWENfR1BSMTIsCj4+IC0JCQkJwqDCoMKgSU1YN0RfR1BSMTJfUENJRV9QSFlfUkVGQ0xL
X1NFTCwKPj4gMCk7Cj4+ICsJCQkJwqDCoMKgSU1YN0RfR1BSMTJfUENJRV9QSFlfUkVGQ0xLX1NF
TCwKPj4gKwkJCQnCoMKgwqBpbXg2X3BjaWUtPnBjaWVwaHlfcmVmY2xrX3NlbCA/Cj4+ICsJCQkJ
wqDCoMKgSU1YN0RfR1BSMTJfUENJRV9QSFlfUkVGQ0xLX1NFTCA6Cj4+IDApOwo+PiAgwqAJCWJy
ZWFrOwo+PiAgwqAJY2FzZSBJTVg2U1g6Cj4+ICDCoAkJcmVnbWFwX3VwZGF0ZV9iaXRzKGlteDZf
cGNpZS0+aW9tdXhjX2dwciwKPj4gSU9NVVhDX0dQUjEyLAo+PiBAQCAtODQwLDYgKzg0Myw5IEBA
IHN0YXRpYyBpbnQgaW14Nl9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UKPj4gKnBk
ZXYpCj4+ICDCoAkJaW14Nl9wY2llLT52cGNpZSA9IE5VTEw7Cj4+ICDCoAl9Cj4+ICAgCj4+ICsJ
aW14Nl9wY2llLT5wY2llcGh5X3JlZmNsa19zZWwgPQo+PiArCQlvZl9wcm9wZXJ0eV9yZWFkX2Jv
b2wobm9kZSwgImZzbCxwY2llLXBoeS1yZWZjbGstCj4+IGludGVybmFsIik7Cj4+ICsKPj4gIMKg
CXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGlteDZfcGNpZSk7Cj4+ICAgCj4+ICDCoAlyZXQg
PSBpbXg2X2FkZF9wY2llX3BvcnQoaW14Nl9wY2llLCBwZGV2KTsKCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs
aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m
cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH v3] PCI: imx6: Add PHY reference clock source support
  2018-01-10 13:43           ` Ilya Ledvich
@ 2018-01-15  2:19             ` Richard Zhu
  2018-03-07 11:54             ` Lorenzo Pieralisi
  1 sibling, 0 replies; 10+ messages in thread
From: Richard Zhu @ 2018-01-15  2:19 UTC (permalink / raw)
  To: Ilya Ledvich, Lucas Stach
  Cc: devicetree, linux-pci, linux-kernel, Rob Herring, Bjorn Helgaas,
	linux-arm-kernel

DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBJbHlhIExlZHZpY2ggW21haWx0
bzppbHlhQGNvbXB1bGFiLmNvLmlsXSANClNlbnQ6IDIwMTjlubQx5pyIMTDml6UgMjE6NDQNClRv
OiBMdWNhcyBTdGFjaCA8bC5zdGFjaEBwZW5ndXRyb25peC5kZT47IFJpY2hhcmQgWmh1IDxob25n
eGluZy56aHVAbnhwLmNvbT4NCkNjOiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29t
PjsgUm9iIEhlcnJpbmcgPHJvYmgrZHRAa2VybmVsLm9yZz47IGxpbnV4LXBjaUB2Z2VyLmtlcm5l
bC5vcmc7IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsgbGludXgta2VybmVs
QHZnZXIua2VybmVsLm9yZzsgZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmcNClN1YmplY3Q6IFJl
OiBbUEFUQ0ggdjNdIFBDSTogaW14NjogQWRkIFBIWSByZWZlcmVuY2UgY2xvY2sgc291cmNlIHN1
cHBvcnQNCg0KSGkgTHVjYXMsDQoNCk9uIDAxLzA4LzIwMTggMTI6NDMgUE0sIEx1Y2FzIFN0YWNo
IHdyb3RlOg0KPiBBbSBEb25uZXJzdGFnLCBkZW4gMDQuMDEuMjAxOCwgMTU6NTIgKzAyMDAgc2No
cmllYiBJbHlhIExlZHZpY2g6DQo+PiBpLk1YN0QgdmFyaWFudCBvZiB0aGUgSVAgY2FuIHVzZSBl
aXRoZXIgQ3J5c3RhbCBPc2NpbGxhdG9yIGlucHV0IG9yIA0KPj4gaW50ZXJuYWwgY2xvY2sgaW5w
dXQgYXMgYSBSZWZlcmVuY2UgQ2xvY2sgaW5wdXQgZm9yIFBDSWUgUEhZLg0KPj4gQWRkIHN1cHBv
cnQgZm9yIGFuIG9wdGlvbmFsIHByb3BlcnR5ICdmc2wscGNpZS1waHktcmVmY2xrLWludGVybmFs
Jy4NCj4+IElmIHByZXNlbnQgdGhlbiBhbiBpbnRlcm5hbCBjbG9jayBpbnB1dCBpcyB1c2VkIGFz
IFBDSWUgUEhZIHJlZmVyZW5jZSANCj4+IGNsb2NrIHNvdXJjZS4gQnkgZGVmYXVsdCBhbiBleHRl
cm5hbCBvc2NpbGxhdG9yIGlucHV0IGlzIHN0aWxsIHVzZWQuDQo+Pg0KPj4gVmVyaWZpZWQgb24g
Q29tcHVsYWIgU0JDLWlNWDcgU2luZ2xlIEJvYXJkIENvbXB1dGVyLg0KPiANCj4gU29ycnkgdG8g
Z2V0IGluIGxhdGUgaGVyZSwgYnV0IEkgd291bGQgcmF0aGVyIGhhdmUgdGhlIGV4dGVybmFsIGNs
b2NrIA0KPiBpbnB1dCBtb2RlbGVkIGFzIGEgcmVhbCBjbG9jayBhbmQgb25seSB1c2UgdGhlIGlu
dGVybmFsIGNsb2NrIGlmIHRoYXQgDQo+IGlzbid0IHByZXNlbnQuDQo+IA0KDQpJIHRyaWVkIHRv
IGZvbGxvdyB0aGUgbG9naWMgZGVzY3JpYmVkIGluIHRoZSBpTVg3IFRSTSwgd2hlcmUgZXh0ZXJu
YWwgb3NjaWxsYXRvciBpcyBhIGRlZmF1bHQgb3B0aW9uLiBBZGRpdGlvbmFsbHksIHRoZSBleHRl
cm5hbCBjbG9jayBpbnB1dCBtb2RlbCB5b3UndmUgc3VnZ2VzdGVkLCByZXF1aXJlcyBhZGRpdGlv
bmFsIGNoYW5nZXMgaW4gdGhlIGlNWDcgU2FicmVTRCBib2FyZCAoYW5kIHByb2JhYmx5IG90aGVy
IGJvYXJkcyB3aGljaCB1c2UgYW4gZXh0ZXJuYWwgaW5wdXQgdG9vKSBkZXZpY2V0cmVlIGZpbGVz
Lg0KW1JpY2hhcmRdIE1heWJlIEx1Y2FzIHdhbnQgdG8gaGF2ZSB0aGUgaW50ZXJuYWwgUExMIGNs
b2NrIG1vZGUgYXMgdGhlIGlNWCBQQ0lFIGRlZmF1bHQgcmVmZXJlbmNlIGNsb2NrLiBBbmQgbWFy
ayB0aGUgZXh0ZXJuYWwgT1NDIGNsb2NrIGlucHV0IG1vZGUgZXhwbGljaXRseSwgYW5kIGRvY3Vt
ZW50ZWQgaW4gdGhlIERUIGJpbmRpbmcgZG9jdW1lbnQuDQoNCj4gQXJlIHlvdSBldmVuIHN1cmUg
dGhhdCB0aGUgaS5NWDcgY2xvY2sgeW91IG1lbnRpb24gaXNuJ3QgdGhlIGFscmVhZHkgDQo+IGRv
Y3VtZW50ZWQgInBjaWVfYnVzIiBjbG9jaz8gVGhpcyBvbmUgaXMgYWxzbyBhbGxvd2VkIHRvIGJl
IHNvdXJjZWQgDQo+IGV4dGVybmFsbHkgb24gdGhlIGkuTVg2Lg0KDQpUbyB0aGUgYmVzdCBvZiBt
eSB1bmRlcnN0YW5kaW5nIGl0J3Mgbm90IHRoZSBwY2llX2J1cyBjbG9jaywgYnV0IEknbSBhYnNv
bHV0ZWx5IHN1cmUuIENvdWxkIGFueWJvZHkgZnJvbSB0aGUgQlNQIHRlYW0gZ3V5cyBlbGFib3Jh
dGUgb24gdGhpcyBpc3N1ZT8gVGhhbmtzIGEgbG90IQ0KQmVzdCByZWdhcmRzLA0KW1JpY2hhcmRd
IGlNWCBQQ0lFIGlzIGludGVncmF0ZWQgb24gdGhlIEFYSSBidXMgaW4gdGhlIFNPQyBpbnRlcm5h
bGx5Lg0KVGhlICJwY2llX2J1c+KAnCBjbG9jayBtYXJrZWQgYXMgdGhlIGNsb2NrIHByb3ZpZGVk
IGJ5IHRoZSBSQywgYW5kIHVzZWQgYnkgdGhlIEVQIGluIHRoZSBpTVg2IHBsYXRmb3Jtcy4NCk9u
IGlNWDYgcGxhdGZvcm1zLCB0aGUgaW50ZXJuYWwgUExMIGlzIG91dHB1dCBmcm9tIExWRFMxIE4v
UCBwYWQsIGFuZCB1c2VkIGJ5IEVQIGluIHRoZSBIVyByZWZlcmVuY2UgZGVzaWducy4NCiAgICAg
ICAgICAgICAgICAgICAgICAgIGNsb2NrcyA9IDwmY2xrcyBJTVg2UURMX0NMS19QQ0lFX0FYST4s
DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8JmNsa3MgSU1YNlFETF9DTEtfTFZE
UzFfR0FURT4sDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8JmNsa3MgSU1YNlFE
TF9DTEtfUENJRV9SRUZfMTI1TT47DQogICAgICAgICAgICAgICAgICAgICAgICBjbG9jay1uYW1l
cyA9ICJwY2llIiwgInBjaWVfYnVzIiwgInBjaWVfcGh5IjsNCg0KSWx5YS4NCg0KPj4gLS0tDQo+
PiBjaGFuZ2VzIHNpbmNlIFYyOg0KPj4gCWFkZCBhIHZlbmRvciBwcmVmaXggJ2ZzbCcgdG8gYSBu
ZXcgcHJvcGVydHkNCj4+DQo+PiAgwqBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv
cGNpL2ZzbCxpbXg2cS1wY2llLnR4dCB8IDUgKysrKysNCj4+ICDCoGRyaXZlcnMvcGNpL2R3Yy9w
Y2ktaW14Ni5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqB8IDgNCj4+ICsrKysrKystDQo+PiAgwqAyIGZpbGVzIGNoYW5nZWQsIDEy
IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4+DQo+PiBkaWZmIC0tZ2l0IGEvRG9jdW1l
bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQNCj4+IGIv
RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQN
Cj4+IGluZGV4IDdiMWU0OGIuLjE1OTFhNmEgMTAwNjQ0DQo+PiAtLS0gYS9Eb2N1bWVudGF0aW9u
L2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2ZzbCxpbXg2cS1wY2llLnR4dA0KPj4gKysrIGIvRG9j
dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQNCj4+
IEBAIC01MCw2ICs1MCwxMSBAQCBBZGRpdGlvbmFsIHJlcXVpcmVkIHByb3BlcnRpZXMgZm9yIGlt
eDdkLXBjaWU6DQo+PiAgwqAJwqDCoMKgwqDCoMKgwqAtICJwY2llcGh5Ig0KPj4gIMKgCcKgwqDC
oMKgwqDCoMKgLSAiYXBwcyINCj4+ICAgDQo+PiArQWRkaXRpb25hbCBvcHRpb25hbCBwcm9wZXJ0
aWVzIGZvciBpbXg3ZC1wY2llOg0KPj4gKy0gZnNsLHBjaWUtcGh5LXJlZmNsay1pbnRlcm5hbDog
SWYgcHJlc2VudCB0aGVuIGFuIGludGVybmFsIFBMTA0KPj4gaW5wdXQgaXMgdXNlZA0KPj4gK8Kg
wqBhcyBQQ0llIFBIWSByZWZlcmVuY2UgY2xvY2sgc291cmNlLiBCeSBkZWZhdWx0IGFuIGV4dGVy
bmFsDQo+PiBvc2NpbGxhdG9yIGlucHV0DQo+PiArwqDCoGlzIHVzZWQuDQo+PiArDQo+PiAgwqBF
eGFtcGxlOg0KPj4gICANCj4+ICDCoAlwY2llQDB4MDEwMDAwMDAgew0KPj4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvcGNpL2R3Yy9wY2ktaW14Ni5jIGIvZHJpdmVycy9wY2kvZHdjL3BjaS1pbXg2LmMg
DQo+PiBpbmRleCBiNzM0ODM1Li4zNjgxMmQzIDEwMDY0NA0KPj4gLS0tIGEvZHJpdmVycy9wY2kv
ZHdjL3BjaS1pbXg2LmMNCj4+ICsrKyBiL2RyaXZlcnMvcGNpL2R3Yy9wY2ktaW14Ni5jDQo+PiBA
QCAtNjEsNiArNjEsNyBAQCBzdHJ1Y3QgaW14Nl9wY2llIHsNCj4+ICDCoAl1MzIJCQl0eF9zd2lu
Z19sb3c7DQo+PiAgwqAJaW50CQkJbGlua19nZW47DQo+PiAgwqAJc3RydWN0IHJlZ3VsYXRvcgkq
dnBjaWU7DQo+PiArCWJvb2wJCQlwY2llcGh5X3JlZmNsa19zZWw7DQo+PiAgwqB9Ow0KPj4gICAN
Cj4+ICDCoC8qIFBhcmFtZXRlcnMgZm9yIHRoZSB3YWl0aW5nIGZvciBQQ0llIFBIWSBQTEwgdG8g
bG9jayBvbiBpLk1YNyAqLyANCj4+IEBAIC00NzQsNyArNDc1LDkgQEAgc3RhdGljIHZvaWQgaW14
Nl9wY2llX2luaXRfcGh5KHN0cnVjdCBpbXg2X3BjaWUNCj4+ICppbXg2X3BjaWUpDQo+PiAgwqAJ
c3dpdGNoIChpbXg2X3BjaWUtPnZhcmlhbnQpIHsNCj4+ICDCoAljYXNlIElNWDdEOg0KPj4gIMKg
CQlyZWdtYXBfdXBkYXRlX2JpdHMoaW14Nl9wY2llLT5pb211eGNfZ3ByLA0KPj4gSU9NVVhDX0dQ
UjEyLA0KPj4gLQkJCQnCoMKgwqBJTVg3RF9HUFIxMl9QQ0lFX1BIWV9SRUZDTEtfU0VMLA0KPj4g
MCk7DQo+PiArCQkJCcKgwqDCoElNWDdEX0dQUjEyX1BDSUVfUEhZX1JFRkNMS19TRUwsDQo+PiAr
CQkJCcKgwqDCoGlteDZfcGNpZS0+cGNpZXBoeV9yZWZjbGtfc2VsID8NCj4+ICsJCQkJwqDCoMKg
SU1YN0RfR1BSMTJfUENJRV9QSFlfUkVGQ0xLX1NFTCA6DQo+PiAwKTsNCj4+ICDCoAkJYnJlYWs7
DQo+PiAgwqAJY2FzZSBJTVg2U1g6DQo+PiAgwqAJCXJlZ21hcF91cGRhdGVfYml0cyhpbXg2X3Bj
aWUtPmlvbXV4Y19ncHIsDQo+PiBJT01VWENfR1BSMTIsDQo+PiBAQCAtODQwLDYgKzg0Myw5IEBA
IHN0YXRpYyBpbnQgaW14Nl9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UNCj4+ICpw
ZGV2KQ0KPj4gIMKgCQlpbXg2X3BjaWUtPnZwY2llID0gTlVMTDsNCj4+ICDCoAl9DQo+PiAgIA0K
Pj4gKwlpbXg2X3BjaWUtPnBjaWVwaHlfcmVmY2xrX3NlbCA9DQo+PiArCQlvZl9wcm9wZXJ0eV9y
ZWFkX2Jvb2wobm9kZSwgImZzbCxwY2llLXBoeS1yZWZjbGstDQo+PiBpbnRlcm5hbCIpOw0KPj4g
Kw0KPj4gIMKgCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGlteDZfcGNpZSk7DQo+PiAgIA0K
Pj4gIMKgCXJldCA9IGlteDZfYWRkX3BjaWVfcG9ydChpbXg2X3BjaWUsIHBkZXYpOw0KX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l
bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6
Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v3] PCI: imx6: Add PHY reference clock source support
  2018-01-10 13:43           ` Ilya Ledvich
  2018-01-15  2:19             ` Richard Zhu
@ 2018-03-07 11:54             ` Lorenzo Pieralisi
  1 sibling, 0 replies; 10+ messages in thread
From: Lorenzo Pieralisi @ 2018-03-07 11:54 UTC (permalink / raw)
  To: Ilya Ledvich
  Cc: devicetree, Richard Zhu, linux-pci, linux-kernel, Rob Herring,
	Bjorn Helgaas, linux-arm-kernel, Lucas Stach

On Wed, Jan 10, 2018 at 03:43:41PM +0200, Ilya Ledvich wrote:
> Hi Lucas,
> 
> On 01/08/2018 12:43 PM, Lucas Stach wrote:
> >Am Donnerstag, den 04.01.2018, 15:52 +0200 schrieb Ilya Ledvich:
> >>i.MX7D variant of the IP can use either Crystal Oscillator input
> >>or internal clock input as a Reference Clock input for PCIe PHY.
> >>Add support for an optional property 'fsl,pcie-phy-refclk-internal'.
> >>If present then an internal clock input is used as PCIe PHY
> >>reference clock source. By default an external oscillator input
> >>is still used.
> >>
> >>Verified on Compulab SBC-iMX7 Single Board Computer.
> >
> >Sorry to get in late here, but I would rather have the external clock
> >input modeled as a real clock and only use the internal clock if that
> >isn't present.
> >
> 
> I tried to follow the logic described in the iMX7 TRM, where external
> oscillator is a default option. Additionally, the external clock input model
> you've suggested, requires additional changes in the iMX7 SabreSD board (and
> probably other boards which use an external input too) devicetree files.
> 
> >Are you even sure that the i.MX7 clock you mention isn't the already
> >documented "pcie_bus" clock? This one is also allowed to be sourced
> >externally on the i.MX6.
> 
> To the best of my understanding it's not the pcie_bus clock, but I'm
> absolutely sure. Could anybody from the BSP team guys elaborate on this
> issue? Thanks a lot!

I have marked this with "Changes Requested" according to Lucas'
feedback, please send a new version or let me know what I should
do with it, thanks.

Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-03-07 11:54 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-27 10:05 [PATCH] PCI: imx6: Add PHY reference clock source support Ilya Ledvich
2017-12-28 10:05 ` Richard Zhu
2017-12-31  8:31   ` [PATCH v2] " Ilya Ledvich
2018-01-02 22:54     ` Fabio Estevam
2018-01-04 13:52       ` [PATCH v3] " Ilya Ledvich
2018-01-08  3:13         ` Richard Zhu
2018-01-08 10:43         ` Lucas Stach
2018-01-10 13:43           ` Ilya Ledvich
2018-01-15  2:19             ` Richard Zhu
2018-03-07 11:54             ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).