From: Vaibhav Gupta <vaibhav.varodek@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Shannon Nelson <snelson@pensando.io>,
Jakub Kicinski <kuba@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Martin Habets <mhabets@solarflare.com>,
netdev@vger.kernel.org, bjorn@helgaas.com,
linux-kernel-mentees@lists.linuxfoundation.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
skhan@linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2 1/2] realtek/8139too: Remove Legacy Power Management
Date: Wed, 29 Apr 2020 20:11:45 +0530 [thread overview]
Message-ID: <CAPBsFfBtr12m1e9njtVct_V1RPSVYksuAdMjhgqUQ1WqFRLYsg@mail.gmail.com> (raw)
In-Reply-To: <CAPBsFfDjVSRHjf36WcAgteH9XocrmrNYTPW4fD2Rwi0neJF6ww@mail.gmail.com>
> >
> > Uncapitalize "legacy power management" in subject. I'd say "convert",
> > not "remove", to make it clear that the driver will still do power
> > management afterwards.
Sure!
> >
> > I think your to: and cc: list came from the get_maintainer.pl script,
yeah.
> > but you can trim it a bit by omitting people who have just made
> > occasional random fixups. These drivers are really unmaintained, so
> > Dave M, netdev, Rafael, linux-pm, linux-pci, and maybe LKML are
> > probably enough.
I will keep this in mind next time.
> >
> > On Tue, Apr 28, 2020 at 08:13:13PM +0530, Vaibhav Gupta wrote:
> > > Upgrade power management from legacy to generic using dev_pm_ops.
> >
> > Instead of the paragraphs below, which cover the stuff that's fairly
> > obvious, I think it would be more useful to include hints about where
> > the things you removed will be done now. That helps reviewers verify
> > that this doesn't break anything. E.g.,
> >
> > In the legacy PM model, drivers save and restore PCI state and set
> > the device power state directly. In the generic model, this is all
> > done by the PCI core in .suspend_noirq() (pci_pm_suspend_noirq())
> > and .resume_noirq() (pci_pm_resume_noirq()).
> >
> > This sort of thing could go in each commit log. The cover letter
> > doesn't normally go in the commit log, so you have to assume it will
> > be lost.
Okay. I will send v3 patch-series with changes. Thanks for
acknowledging :)
--Vaibhav Gupta
> >
> > > Remove "struct pci_driver.suspend" and "struct pci_driver.resume"
> > > bindings, and add "struct pci_driver.driver.pm" .
> > >
next prev parent reply other threads:[~2020-04-29 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 14:43 [Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove legacy power management callbacks Vaibhav Gupta
2020-04-28 14:43 ` [Linux-kernel-mentees] [PATCH v2 1/2] realtek/8139too: Remove Legacy Power Management Vaibhav Gupta
2020-04-28 17:19 ` Bjorn Helgaas
[not found] ` <CAPBsFfDjVSRHjf36WcAgteH9XocrmrNYTPW4fD2Rwi0neJF6ww@mail.gmail.com>
2020-04-29 14:41 ` Vaibhav Gupta [this message]
2020-04-28 14:43 ` [Linux-kernel-mentees] [PATCH v2 2/2] realtek/8139cp: " Vaibhav Gupta
2020-04-28 17:29 ` Bjorn Helgaas
2020-04-29 14:32 ` Vaibhav Gupta
2020-04-28 17:54 ` [Linux-kernel-mentees] [PATCH v2 0/2] realtek ethernet : remove legacy power management callbacks Heiner Kallweit
2020-04-29 14:23 ` Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPBsFfBtr12m1e9njtVct_V1RPSVYksuAdMjhgqUQ1WqFRLYsg@mail.gmail.com \
--to=vaibhav.varodek@gmail.com \
--cc=bjorn@helgaas.com \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=skhan@linuxfoundation.org \
--cc=snelson@pensando.io \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).