linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V1] PCI: dwc: Fixes N_FTS setup
@ 2022-09-19 14:31 Vidya Sagar
  2022-09-19 17:29 ` Bjorn Helgaas
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Vidya Sagar @ 2022-09-19 14:31 UTC (permalink / raw)
  To: jingoohan1, gustavo.pimentel, lpieralisi, robh, kw, bhelgaas
  Cc: linux-pci, linux-kernel, kthota, mmaddireddy, vidyas, sagar.tv

commit aeaa0bfe89654 ("PCI: dwc: Move N_FTS setup to common setup")
unnecessarily uses pci->link_gen in deriving the index to the
n_fts[] array also introducing the issue of accessing beyond the
boundaries of array for greater than Gen-2 speeds. This change fixes
that issue.

Fixes: aeaa0bfe8965 ("PCI: dwc: Move N_FTS setup to common setup")
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
 drivers/pci/controller/dwc/pcie-designware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index c6725c519a47..9e4d96e5a3f5 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -641,7 +641,7 @@ void dw_pcie_setup(struct dw_pcie *pci)
 	if (pci->n_fts[1]) {
 		val = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL);
 		val &= ~PORT_LOGIC_N_FTS_MASK;
-		val |= pci->n_fts[pci->link_gen - 1];
+		val |= pci->n_fts[1];
 		dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val);
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-10-27  8:15 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 14:31 [PATCH V1] PCI: dwc: Fixes N_FTS setup Vidya Sagar
2022-09-19 17:29 ` Bjorn Helgaas
2022-09-23 20:57 ` Han Jingoo
2022-09-26 11:19 ` [PATCH V2] PCI: dwc: Fix n_fts[] array overrun Vidya Sagar
2022-09-29  2:04   ` Han Jingoo
2022-09-29  4:57     ` Vidya Sagar
2022-09-29 16:49       ` Han Jingoo
2022-10-04 21:50   ` Rob Herring
2022-10-10  5:51     ` Vidya Sagar
2022-10-27  8:15   ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).