From: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: RE: [PATCH v6 1/5] misc: Add Synopsys DesignWare xData IP driver
Date: Wed, 24 Mar 2021 09:15:46 +0000 [thread overview]
Message-ID: <DM5PR12MB18355EDB515CE57C38ECF6D4DA639@DM5PR12MB1835.namprd12.prod.outlook.com> (raw)
In-Reply-To: <YFnmVEB86JcAENcN@kroah.com>
Hi Greg,
On Tue, Mar 23, 2021 at 13:0:4, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Fri, Feb 12, 2021 at 06:28:03PM +0100, Gustavo Pimentel wrote:
> > +static const struct attribute_group xdata_attr_group = {
> > + .attrs = default_attrs,
> > + .name = DW_XDATA_DRIVER_NAME,
> > +};
>
> ATTRIBUTE_GROUPS()?
Nicely catched!
>
> > +static int dw_xdata_pcie_probe(struct pci_dev *pdev,
> > + const struct pci_device_id *pid)
> > +{
> > + const struct dw_xdata_pcie_data *pdata = (void *)pid->driver_data;
> > + struct dw_xdata *dw;
> > + u64 addr;
> > + int err;
> > +
> > + /* Enable PCI device */
> > + err = pcim_enable_device(pdev);
> > + if (err) {
> > + pci_err(pdev, "enabling device failed\n");
> > + return err;
> > + }
> > +
> > + /* Mapping PCI BAR regions */
> > + err = pcim_iomap_regions(pdev, BIT(pdata->rg_bar), pci_name(pdev));
> > + if (err) {
> > + pci_err(pdev, "xData BAR I/O remapping failed\n");
> > + return err;
> > + }
> > +
> > + pci_set_master(pdev);
> > +
> > + /* Allocate memory */
> > + dw = devm_kzalloc(&pdev->dev, sizeof(*dw), GFP_KERNEL);
> > + if (!dw)
> > + return -ENOMEM;
> > +
> > + /* Data structure initialization */
> > + mutex_init(&dw->mutex);
> > +
> > + dw->rg_region.vaddr = pcim_iomap_table(pdev)[pdata->rg_bar];
> > + if (!dw->rg_region.vaddr)
> > + return -ENOMEM;
> > +
> > + dw->rg_region.vaddr += pdata->rg_off;
> > + dw->rg_region.paddr = pdev->resource[pdata->rg_bar].start;
> > + dw->rg_region.paddr += pdata->rg_off;
> > + dw->rg_region.sz = pdata->rg_sz;
> > +
> > + dw->max_wr_len = pcie_get_mps(pdev);
> > + dw->max_wr_len >>= 2;
> > +
> > + dw->max_rd_len = pcie_get_readrq(pdev);
> > + dw->max_rd_len >>= 2;
> > +
> > + dw->pdev = pdev;
> > +
> > + writel(0x0, &(__dw_regs(dw)->RAM_addr));
> > + writel(0x0, &(__dw_regs(dw)->RAM_port));
> > +
> > + addr = dw->rg_region.paddr + DW_XDATA_EP_MEM_OFFSET;
> > + writel(lower_32_bits(addr), &(__dw_regs(dw)->addr_lsb));
> > + writel(upper_32_bits(addr), &(__dw_regs(dw)->addr_msb));
> > + pci_dbg(pdev, "xData: target address = 0x%.16llx\n", addr);
> > +
> > + pci_dbg(pdev, "xData: wr_len=%zu, rd_len=%zu\n",
> > + dw->max_wr_len * 4, dw->max_rd_len * 4);
> > +
> > + /* Saving data structure reference */
> > + pci_set_drvdata(pdev, dw);
> > +
> > + /* Sysfs */
> > + err = sysfs_create_group(&pdev->dev.kobj, &xdata_attr_group);
>
> You just raced with userspace and lost :(
>
> Have the driver core properly create/remove your sysfs files, set the
> default groups pointer in your driver and all will be fine.
I've gone around and around, searched in other drivers, but I'm not
understanding your PoV or what I should do. Can you throw me a bone here?
I'm starting to pull my hair off, lol
I would like to ask you about something, it's you the maintainer of misc
drivers right?
After fixing this issue, does this driver have a chance to be pulled on
5.13?
-Gustavo
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2021-03-24 9:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 17:28 [PATCH v6 0/5] misc: Add Add Synopsys DesignWare xData IP driver Gustavo Pimentel
2021-02-12 17:28 ` [PATCH v6 1/5] misc: " Gustavo Pimentel
2021-03-23 13:00 ` Greg Kroah-Hartman
2021-03-24 9:15 ` Gustavo Pimentel [this message]
2021-03-24 9:25 ` Greg Kroah-Hartman
2021-02-12 17:28 ` [PATCH v6 2/5] misc: Add Synopsys DesignWare xData IP driver to Makefile and Kconfig Gustavo Pimentel
2021-02-12 17:28 ` [PATCH v6 3/5] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver Gustavo Pimentel
2021-02-12 17:28 ` [PATCH v6 4/5] MAINTAINERS: Add Synopsys xData IP driver maintainer Gustavo Pimentel
2021-02-12 17:28 ` [PATCH v6 5/5] docs: ABI: Add sysfs documentation interface of dw-xdata-pcie driver Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB18355EDB515CE57C38ECF6D4DA639@DM5PR12MB1835.namprd12.prod.outlook.com \
--to=gustavo.pimentel@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=dragan.cvetic@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).