From: "Thokala, Srikanth" <srikanth.thokala@intel.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"mgross@linux.intel.com" <mgross@linux.intel.com>,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>
Subject: RE: [PATCH v7 1/2] dt-bindings: PCI: Add Intel Keem Bay PCIe controller
Date: Wed, 17 Feb 2021 06:03:31 +0000 [thread overview]
Message-ID: <MWHPR11MB140611D7EE90A7170361039185869@MWHPR11MB1406.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YCMr3yCv5+cAjzDc@rocinante>
Hi Krzysztof,
Thank you for the review.
> -----Original Message-----
> From: Krzysztof Wilczyński <kw@linux.com>
> Sent: Wednesday, February 10, 2021 6:12 AM
> To: Thokala, Srikanth <srikanth.thokala@intel.com>
> Cc: bhelgaas@google.com; robh+dt@kernel.org; lorenzo.pieralisi@arm.com;
> linux-pci@vger.kernel.org; devicetree@vger.kernel.org;
> andriy.shevchenko@linux.intel.com; mgross@linux.intel.com; Raja
> Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@intel.com>;
> Sangannavar, Mallikarjunappa <mallikarjunappa.sangannavar@intel.com>
> Subject: Re: [PATCH v7 1/2] dt-bindings: PCI: Add Intel Keem Bay PCIe
> controller
>
> Hi Srikanth,
>
> Thank you for working on this new driver!
>
> [...]
> > +title: Intel Keem Bay PCIe controller endpoint mode
> [...]
> > +title: Intel Keem Bay PCIe controller root complex mode
> [...]
>
> Not sure if worth spending on this, but I've noticed that people often
> capitalise "Root Complex" and "Endpoint" when talking about PCIe
> controller
> features - you did the same in the cover letter, so I wonder if you want
> to keep this consistent.
Sure I will make change to keep it consistent.
Thanks!
Srikanth
>
> Krzysztof
next prev parent reply other threads:[~2021-02-17 6:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-24 23:47 [PATCH v7 0/2] PCI: keembay: Add support for Intel Keem Bay srikanth.thokala
2021-01-24 23:47 ` [PATCH v7 1/2] dt-bindings: PCI: Add Intel Keem Bay PCIe controller srikanth.thokala
2021-02-10 0:42 ` Krzysztof Wilczyński
2021-02-17 6:03 ` Thokala, Srikanth [this message]
2021-01-24 23:47 ` [PATCH v7 2/2] PCI: keembay: Add support for Intel Keem Bay srikanth.thokala
2021-02-09 19:01 ` Thokala, Srikanth
2021-02-10 0:36 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB140611D7EE90A7170361039185869@MWHPR11MB1406.namprd11.prod.outlook.com \
--to=srikanth.thokala@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kw@linux.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mgross@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).